New issue
Advanced search Search tips

Issue 877423 link

Starred by 1 user
Status: Verified
Owner:
kkhorimoto@chromium.org
Closed: Sep 6
Cc:
sczs@chromium.org
justincohen@chromium.org
rohitrao@chromium.org
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Reading list’s cancel button is not functional

Project Member Reported by rakurati@chromium.org, Aug 24 
App Version: 69.0.3497.58 beta
iOS Version: 12 beta 9 only
Device: iPhone, iPad

Steps to reproduce:
1. Launch chrome 
2. Add few articles to reading list
3. Open reading list
4. Swipe right to left on the article and tap on the delete button
5. Tap on cancel button

Observed results:
Notice that cancel button doesn’t respond

Expected results:
Cancel button should dismiss the edit mode

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: Not tested
Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA
Bug reproducible on current stable build (App Version, iOS Version): No on M68 (swipe function is available from UI refresh)
Bug reproducible on the current beta channel build (App Version, iOS Version): Yes on M69 

Link to video:
https://drive.google.com/file/d/1sHWqsFcl9XEDsThdf7YZ11El12J-N8PO/view?usp=sharing

Comment 1 by olivierrobin@chromium.org, Aug 24

Cc: kkhorimoto@chromium.org justincohen@chromium.org rohitrao@chromium.org
Owner: sczs@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by sczs@chromium.org, Aug 24

Cc: -kkhorimoto@chromium.org sczs@chromium.org
Labels: -Pri-2 M-70 Pri-1
Owner: kkhorimoto@chromium.org
PTAL kkhorimoto. I can also take a look if you don't have enough bandwidth.

Comment 3 by kkhorimoto@chromium.org, Aug 31

Status: Started (was: Assigned)

Comment 4 by kkhorimoto@chromium.org, Aug 31 

This is fixed by crrev.com/c/1198104
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3133b88a72c61683057d7b1970f68d15b67c0c17

commit 3133b88a72c61683057d7b1970f68d15b67c0c17
Author: Kurt Horimoto <kkhorimoto@chromium.org>
Date: Thu Sep 06 19:18:52 2018

[iOS] Defer removing empty sections until editing is stopped.

The swipe to delete gesture for UITableView will throw an exception if
the deleted row's section is removed before the animation finishes.
This CL updates ReadingListTableViewController to defer removing empty
sections until self.tableView.editing is reset to NO at the end of the
swipe animation.

Bug:  877425 ,  877423 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I74e29b761fc8458e8bb9a6dbe643a73b00a8b9a4
Reviewed-on: https://chromium-review.googlesource.com/1198104
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589237}
[modify] https://crrev.com/3133b88a72c61683057d7b1970f68d15b67c0c17/ios/chrome/browser/ui/reading_list/reading_list_table_view_controller.mm

Comment 6 by kkhorimoto@chromium.org, Sep 6

Labels: Merge-Request-70
Status: Fixed (was: Started)
Project Member

Comment 7 by sheriffbot@chromium.org, Sep 7

Labels: -Merge-Request-70 Hotlist-Merge-Approved Merge-Approved-70
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 10

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/055c5c8c6483b3ce9cda5e51da6fc94fd8becd5f

commit 055c5c8c6483b3ce9cda5e51da6fc94fd8becd5f
Author: Kurt Horimoto <kkhorimoto@chromium.org>
Date: Mon Sep 10 18:22:23 2018

[iOS] Defer removing empty sections until editing is stopped.

The swipe to delete gesture for UITableView will throw an exception if
the deleted row's section is removed before the animation finishes.
This CL updates ReadingListTableViewController to defer removing empty
sections until self.tableView.editing is reset to NO at the end of the
swipe animation.

Bug:  877425 ,  877423 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I74e29b761fc8458e8bb9a6dbe643a73b00a8b9a4
Reviewed-on: https://chromium-review.googlesource.com/1198104
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#589237}(cherry picked from commit 3133b88a72c61683057d7b1970f68d15b67c0c17)
Reviewed-on: https://chromium-review.googlesource.com/1217169
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#232}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/055c5c8c6483b3ce9cda5e51da6fc94fd8becd5f/ios/chrome/browser/ui/reading_list/reading_list_table_view_controller.mm

Comment 9 by vbarig...@chromium.org, Sep 11

Status: Verified (was: Fixed)
Verified on chrome canary version 71.0.3549.0 on iPad Air with iOS 12 beta 12 and iPhone 6s plus with iOS 12 beta 12, following the steps mentioned in comment #0.  Edit button is displayed.  Looks good.

Comment 10 by rakurati@chromium.org, Sep 14 

Verified in 70.0.3538.17 in iPhone 6s plus(iOS 12 beta 12) and iPad Air(iOS 12 beta 12)

Tapping on delete button will remove the article and also quits from edit mode, looks good.

Link to video:
https://drive.google.com/file/d/1EbED9_-wU0SQKYJzrqjfkADJYb0981J8/view?usp=sharing
►

Sign in to add a comment