Issue metadata
Sign in to add a comment
|
Regression:Screen-shot is seen black in colour in 'Report an issue' overlay.
Reported by
shruti.j...@etouch.net,
Aug 24
|
||||||||||||||||||||||
Issue description
Chrome Version:70.0.3531.0 (Official Build) Revisionc1d3760b59d4aa3a1d610c1ccdd0872a17f993ff-refs/branch-heads/3531@{#1}(64-bit)
OS:Mac(10.12.6, 10.13.1, 10.13.6,10.14)
Steps to reproduce:
1. Launch chrome and click on three dots and open wrench menu.
2. Under Help ,select 'Report an issue' option.
3. Observe screenshot in 'Report an issue' overlay.
Actual Result:Screen-shot is seen black in colour in 'Report an issue' overlay.
Expected Result:Screen-shot should be properly visible in 'Report an issue' overlay.
This is a regression issue, broken in 'M-70', and below is per-revision bisect-info:
Good Build:70.0.3529.0(Revision:)
Bad Build: 70.0.3530.0(Revision:)
You are probably looking for a change made after 584631 (known good), but no later than 584632 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
https://chromium.googlesource.com/chromium/src/+log/265ebe487012785f0264260bee26658c9bb46c4c..09cd5826e743af9dbcbde8ab36f73f5e0bd55f6c
Suspect:https://chromium.googlesource.com/chromium/src/+/09cd5826e743af9dbcbde8ab36f73f5e0bd55f6c
@ braveyao : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.
Kindly refer the attached screen-cast
Thank You.
,
Aug 24
Gave a quick glance to the changes between 70.3531 and 70.3532, https://chromium.googlesource.com/chromium/src/+log/a5a30e72b73764a8ccc70e551e312fc972fe2e79..67552a19956c647476f79ab12af45dc91762c3a5, and can't tell the offending cl easily. We need to find the owner of 'Report an issue' and find a way to enable it in chromium for a test.
,
Aug 31
Over to OWNER of the code in question. https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc?q=page_report_an_issue&sq=package:chromium&dr=C&l=317
,
Aug 31
Let's try a finer grained by bisect. At first glance, IOSurfaceCapturer sounds extremely related to the symptoms. I would ask: Can you reproduce the issue my forcing the feature on with --enable-features? What about turning it off via --disable-features flag?
,
Aug 31
Yes, disable IOSurfaceCapturer can make the problem disappear in latest Canary. But meantime, enable IOSurfaceCapturer will not cause any problem in earlier Canary versions. See the attachments of screenshots with Canary 75.3531 and 75.3532. You can see that the problem starts since 75.3532. And IOSurfaceCapturer has been enabled 100% everywhere, you can't see this problem on Stable too. Also the normal screencapture, i.e. go/Presentation, works fine too in latest Canary. I guess this is a render issue in Report An Issue, as IOSurfaceCapturer has twice the performance, e.g. higher framerate now.
,
Aug 31
Missed the screenshot with 70.3531. Attached it here.
,
Sep 6
adding label 'ET-MUM-Reported' as we need that label to track bugs.
,
Sep 6
As per comment #5&6 removing Needs-Bisect label.Please add if its required. Thank You!
,
Oct 5
Hi, some users of my Chrome extension have reported a similar issue with the chrome.tabs.captureVisibleTab creating all black images. They are *all* on v69. I also experienced this just after updating from Chrome 68 -> Chrome 69 along with some system updates (on Mac OS 10.13.6). After 2 hours of an utterly confounding debugging experience, I restarted my computer and the problem was resolved. I currently have one user on Windows 10.0.0 and Chrome 69.0.3497.100 who is still getting this issue after restart. They even recreated it on this very simple extension: https://github.com/mrcoles/test-chrome-extension-capturetab I have attached their chrome://versions content to this comment.
,
Oct 5
Hi peter, your issue totally has nothing to do with this one, which is about IOSurface capture to capture the screen on MaxOSX. Your problem is on windows and tabs.captureVidibleTab() will not invoke desktopCapture at all. So please file another issue.
,
Oct 15
Okay. It sounds like the problem may already be fixed? If so, feel free to close the issue. I'm assigning the issue to braveyao@ as it is most related to those changes.
,
Oct 15
It seems that it works again in M71, tested with Canary 71.3578. No idea what change fixed this. Definitely I didn't do any thing recently. Be aware that M70 may still not work. It's better to find out which cl fixed this and merge it back to M70. tommycli@, please double check and forward to the right owner.
,
Oct 15
Assigning to Feedback tool owners. Thanks.
,
Oct 15
No recent changes to the feedback app code that takes a screenshot. I don't develop on Mac, and I won't be able to bisect. Please assign to someone who can.
,
Oct 15
I just re-tested this on my Macbook Pro and it seems to be working fine on both Canary 71.0.3578.8 as well as Beta 70.3538.54. So I'm marking this as WONTFIX as I can't reproduce it. -- That being said, if this issue pops up again, I expect that either braveyao or someone on the Feedback component team to take ownership. The code I own as referenced in c#3 is the "Report an Issue" string definition. Both the Feedback component team and the IOSurfaceCapturer owners are more proximate. If the bug is Mac-specific and turning off IOSurfaceCapturer "fixes" the issue, I'm suspecting there is a interaction with IOSurfaceCapturer. Thanks you all. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by braveyao@chromium.org
, Aug 24