New issue
Advanced search Search tips

Issue 877412 link

Starred by 2 users
Status: Duplicate
Merged: issue 869643
Owner:
mmourgos@chromium.org
Closed: Dec 5
Cc:
omrilio@chromium.org
ajha@chromium.org
weidongg@chromium.org
newcomer@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Enforce 28 char limit in folder name entry field.

Project Member Reported by mmanchala@chromium.org, Aug 24 
Chrome Version: 70.0.3530.0/10998.0.0 dev-channel Celes,Kip and Daisy 
OS: Chrome

What steps will reproduce the problem?
(1)Sign into User -> Open App Launcher ->Now drag any App into another App so that Folder is created -> drag 20-22 apps so that next page in Folder will be created 
(2)Now give lengthy name to folder -> close the folder -> At Folder observe name (Ex: acnbhgdgbdjhfgudjgbhd......) will be seen and now hover mouse pointer on Folder name and observe tooltip(Ex: acnbhgdgbdj) i.e. name is truncated
(3)Now open that folder -> observe Folder name is truncated (Ex: acnbhgdgbdj is seen)
(Please refer Video and Screenshot)

Expected:  
a)Folder name Tooltip should not get  truncated on hovering mouse pointer on Folder name in App Launcher
b)Folder name should not get truncated in App Folder

Actual: Instead
a)Folder name Tooltip is truncated in App Launcher
b)Folder name also truncated in App Folder

This is Regression Issue as same is working fine in 70.0.3524.2/10983.0.0 dev-channel Daisy
Actual_FolderName.webm
3.6 MB View Download
Actual_FolderName.jpg
849 KB View Download
Expected_AppName.mp4
16.4 MB Download

Comment 1 by weidongg@chromium.org, Aug 24 

I think this is WAI, since the maximum folder name is 28 chars in the code: https://cs.chromium.org/chromium/src/ash/public/cpp/app_list/app_list_constants.cc?type=cs&q=kMaxFolderNameChars&g=0&l=113

Comment 2 by newcomer@chromium.org, Aug 27

Status: WontFix (was: Untriaged)
Wontfixing for WAI.

Comment 3 by mmanchala@chromium.org, Sep 4

Cc: -weidongg@chromium.org newcomer@chromium.org
Owner: weidongg@chromium.org
Status: Assigned (was: WontFix)
C#1>>

If the maximum folder name is 28 chars but the folder is taking more than 28(it is allowing to take more than 28 chars)at least we should get any Error Message like 'Folder name should be 28 chars' or it should not allow more than 28 chars

Reopening issue for confirmation

Thanks..!!

Comment 4 by newcomer@chromium.org, Sep 4

Labels: -Pri-1 -ReleaseBlock-Stable -M-70 M-71 Pri-2
As a folder tooltip bug, this has pretty low exposure in the wild. Moving this to M-71.

Comment 5 by weidongg@chromium.org, Sep 4

Labels: app-list-folder

Comment 6 by newcomer@chromium.org, Oct 15

Labels: m-72
Bulk moving all M-71 <P-1's to M-72.

Comment 7 by newcomer@chromium.org, Oct 15

Labels: -M-71 -m-71

Comment 8 by weidongg@google.com, Nov 28

Cc: weidongg@chromium.org
Owner: mmourgos@chromium.org

Comment 9 by mmourgos@chromium.org, Nov 29

Status: Started (was: Assigned)

Comment 10 by newcomer@chromium.org, Nov 30

Summary: Enforce 28 char limit in folder name entry field. (was: Regression : Folder name Tool tip is seen truncated in App Launcher)
After talking to UX, we will just limit input of the folder name field to 28 chars. I'm going to use this bug for that purpose.

Comment 11 by newcomer@chromium.org, Dec 3

Labels: -M-72 -m-72 M-73
Bulk moving <p-1's to the next milestone because we branched to M-73.

Comment 12 by mmourgos@chromium.org, Dec 5

Mergedinto: 869643
Status: Duplicate (was: Started)
►

Sign in to add a comment