Disabling "Show all Play folders" should ensure the current directory is a visible one |
||||
Issue descriptionChrome Version: 70.0.3524.2 OS: ChromeOS What steps will reproduce the problem? (1) In the files app, enable "Show all Play folders" (2) Switch to a folder under Play files that wasn't visible (e.g. Android) (3) Disable "Show all Play folders" What is the expected result? Files app should switch to a still-visible folder (e.g. Play files), similarly to when the current folder is deleted. What happens instead? The folder is still open despite being hidden from the folder view on the left.
,
Aug 27
,
Sep 27
,
Oct 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ddfc2d6a9ed209eb4413c39fe656bf618ea78b40 commit ddfc2d6a9ed209eb4413c39fe656bf618ea78b40 Author: Naoki Fukino <fukino@chromium.org> Date: Fri Oct 05 04:49:14 2018 Change the current directory to volume root when the current one is hidden. When the current directory is hidden by filter setting (incl. disabling "Show all Play folders" option), the current directory should be changed to visible one. This CL change the current directory to the volume's root directory for such cases to be consistent with the case when the current directory is deleted. . Bug: 877405 Test: manual test on a arc-enabled device, and browser_tests --gtest_filter=*hideCurrentDirectoryByTogglingHiddenAndroidFolders Change-Id: Ie2db1f297df0cf6ee1dcf2719f204763985a1c80 Reviewed-on: https://chromium-review.googlesource.com/c/1258807 Commit-Queue: Naoki Fukino <fukino@chromium.org> Reviewed-by: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#596994} [modify] https://crrev.com/ddfc2d6a9ed209eb4413c39fe656bf618ea78b40/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc [modify] https://crrev.com/ddfc2d6a9ed209eb4413c39fe656bf618ea78b40/ui/file_manager/file_manager/foreground/js/directory_contents.js [modify] https://crrev.com/ddfc2d6a9ed209eb4413c39fe656bf618ea78b40/ui/file_manager/file_manager/foreground/js/directory_model.js [modify] https://crrev.com/ddfc2d6a9ed209eb4413c39fe656bf618ea78b40/ui/file_manager/integration_tests/file_manager/gear_menu.js
,
Oct 5
|
||||
►
Sign in to add a comment |
||||
Comment 1 by slangley@chromium.org
, Aug 27Status: Assigned (was: Untriaged)