New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 877398 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 24
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Feature

Blocking:
issue 864904



Sign in to add a comment

desktop-pwas: Add ability to use the default launch container to PendingAppManager

Project Member Reported by ortuno@chromium.org, Aug 24

Issue description

Policies sometimes want the apps to launch in the default container: windows for PWAs and tabs for non-PWAs. PendingAppManager::AppInfo should support that.
 
Blocking: 864904
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82b618bb2943b93b37fcf81dc056b8818a0edad7

commit 82b618bb2943b93b37fcf81dc056b8818a0edad7
Author: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Date: Fri Aug 24 11:17:29 2018

desktop-pwas: Adds ability to use the default launch container to PendingAppManager

WebAppPolicyManager allows admins to not specify a launch container.
When this is the case the installed app should launch in the default
container: windows for PWAs and tabs for non-PWAs.

Adds a new enum value to PendingAppManager::LaunchContainer to
indicate that the default launch container should be used and changes
WebAppPolicyManager to set that value when appropriate.

Bug:  877398 
Change-Id: I4c99d3b53bc7c29a50c6961da78d046bc7ef7819
Reviewed-on: https://chromium-review.googlesource.com/1188203
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585792}
[modify] https://crrev.com/82b618bb2943b93b37fcf81dc056b8818a0edad7/chrome/browser/web_applications/bookmark_apps/policy/web_app_policy_manager.cc
[modify] https://crrev.com/82b618bb2943b93b37fcf81dc056b8818a0edad7/chrome/browser/web_applications/bookmark_apps/policy/web_app_policy_manager_unittest.cc
[modify] https://crrev.com/82b618bb2943b93b37fcf81dc056b8818a0edad7/chrome/browser/web_applications/components/pending_app_manager.h
[modify] https://crrev.com/82b618bb2943b93b37fcf81dc056b8818a0edad7/chrome/browser/web_applications/extensions/bookmark_app_installation_task.cc
[modify] https://crrev.com/82b618bb2943b93b37fcf81dc056b8818a0edad7/chrome/browser/web_applications/extensions/bookmark_app_installation_task_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment