New issue
Advanced search Search tips

Issue 877377 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Aug 29
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-08-29
OS: ----
Pri: ----
Type: ----

Blocking:
issue 678905



Sign in to add a comment

[WPT] update-top-level.https.html is failing

Project Member Reported by monorail...@ecosystem-infra.iam.gserviceaccount.com, Aug 24

Issue description

WPT import https://crrev.com/c/1187896 introduced new failures in external/wpt/service-workers:

List of new failures:
external/wpt/service-workers/service-worker/update-top-level.https.html [ Timeout ]
virtual/outofblink-cors/external/wpt/service-workers/service-worker/update-top-level.https.html [ Timeout ]
virtual/outofblink-cors-ns/external/wpt/service-workers/service-worker/update-top-level.https.html [ Timeout ]
virtual/service-worker-servicification/external/wpt/service-workers/service-worker/update-top-level.https.html [ Timeout ]

This import contains upstream changes from e570d8f2040c24dd9ba77f1c7887a282a04eb529 to 34f9b93c2749043ba68485dea92d1fb554075e60:
RTCIceTransport: gather() implementation.: https://github.com/web-platform-tests/wpt/commit/34f9b93c2749043ba68485dea92d1fb554075e60
Block self-update from top level scripts.: https://github.com/web-platform-tests/wpt/commit/2a0d4b079868ebd9406565fcaf62277a783a17cd [affecting this directory]
[UserTiming] Correct measure where start is undefined: https://github.com/web-platform-tests/wpt/commit/54525995564877fbf730c679200a5ae8610e5f2f
Modify source path for wpt test of Accept-CH: https://github.com/web-platform-tests/wpt/commit/cd356d332be2a1edb92ae8bb185d0ff3fb40a176
HTML: add test for history.state after document.open() (#12650): https://github.com/web-platform-tests/wpt/commit/e57d136af9eef24a9f3b54dffcf9c7ca74331f09
HTML: document.open() and document's URL (#12636): https://github.com/web-platform-tests/wpt/commit/312d71258a26bfa420f7eef100df4ef92d961483
HTML: document.open() and reload (#12555): https://github.com/web-platform-tests/wpt/commit/8b0c29bfa35d03c3db9027af796abcdb08b7c6dc
HTML: more tests for document.open bailout order (#12645): https://github.com/web-platform-tests/wpt/commit/45d82ab6c8893eab5a8f50aedfc20af81679cb10

 
Blocking: 678905
Owner: falken@chromium.org
Status: Assigned (was: Untriaged)
Summary: [WPT] update-top-level.https.html is failing (was: [WPT] New failures introduced in external/wpt/service-workers by import https://crrev.com/c/1187896)
update-top-level.https.html was added by https://github.com/web-platform-tests/wpt/pull/12633.

I don't see why we'd time out on this test though.
I think it's a problem with the WPT test. I commented on https://bugzilla.mozilla.org/show_bug.cgi?id=1472303#c11:

The update() call is failing with an InvalidStateError. I think this aligns with the spec at https://w3c.github.io/ServiceWorker/#service-worker-registration-update: if the state is installing, reject the promise with InvalidStateError.

Also I don't think this part is valid:

  reg.addEventListener("updatefound",
    () => assert_unreached("shouldn't find an update"));

The spec says UAs can terminate long running workers, but it would still be spec-conformant to find an update. (Chrome allows some updates before blocking the call.)

I'm not sure how to change this test. We could let the service worker reach active, then give it a message to try self-update, but this bug seems about update at top-level.

I think you'd have to install the service worker once, use some implementation specific way to stop the worker, then start it again.

Not sure WPT would be possible here. Chrome has a similar test for self-updating workers at:
https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/http/tests/serviceworker/update-no-controllee.https.html
NextAction: 2018-08-29
The test will be removed in https://github.com/web-platform-tests/wpt/pull/12676

I assume after that WPT importer will either remove the test expectation or we must do it manually, then close this bug. Setting NextAction for that.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e75d0a3a1752b1915e3a5a121e16ad430f125c1d

commit e75d0a3a1752b1915e3a5a121e16ad430f125c1d
Author: Matt Falkenhagen <falken@chromium.org>
Date: Wed Aug 29 04:27:29 2018

Gardening: remove nonexistent update-top-level.https.html from TestExpectations

update-top-level.https.html was removed in r586750.

Bug:  877377 ,  878657 , 626703
Change-Id: I9b64b469a58ad137018893601353097dbdfe21c8
TBR: robertma
NOTRY: true
Reviewed-on: https://chromium-review.googlesource.com/1195227
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587010}
[modify] https://crrev.com/e75d0a3a1752b1915e3a5a121e16ad430f125c1d/third_party/WebKit/LayoutTests/TestExpectations

Status: WontFix (was: Assigned)
The test was removed, see  https://bugzilla.mozilla.org/show_bug.cgi?id=1472303
The NextAction date has arrived: 2018-08-29

Sign in to add a comment