Support mock ARC volumes for testing along the same lines as Crostini. Eg: https://codesearch.chromium.org/chromium/src/chrome/browser/chromeos/file_manager/volume_manager.cc?rcl=d23ef8c44c09c587650beef05184a69ee1b48bb2&l=589 This will allow testing of components that require Android files and/or Media View volumes.
Support mock Android Files volume for testing along the same lines as Crostini. Eg: https://codesearch.chromium.org/chromium/src/chrome/browser/chromeos/file_manager/volume_manager.cc?rcl=d23ef8c44c09c587650beef05184a69ee1b48bb2&l=589 This will allow testing of components that require Android files.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b7f29d7263f980fbfb3a391210ae14fd1baa429 commit 2b7f29d7263f980fbfb3a391210ae14fd1baa429 Author: Alex Lau <alexlau@chromium.org> Date: Mon Sep 10 07:40:59 2018 Add mock ARC volume and initial tests. This adds a fake local ARC volume for testing. Initial integration tests added check that 1) the "Toggle Play Folders" button work in hiding and showing the non-default Android files and folders. 2) the "Toggle Play Folders" button is shown inside Play Files but hidden from the "Recents" pane. Bug: 877371 Test: Tested on Chromium build. Change-Id: Ic35de5ebb06f901ad229c9b35f1917ac9353a459 Reviewed-on: https://chromium-review.googlesource.com/1201637 Commit-Queue: Alex Lau <alexlau@chromium.org> Reviewed-by: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#589847} [modify] https://crrev.com/2b7f29d7263f980fbfb3a391210ae14fd1baa429/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc [modify] https://crrev.com/2b7f29d7263f980fbfb3a391210ae14fd1baa429/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc [modify] https://crrev.com/2b7f29d7263f980fbfb3a391210ae14fd1baa429/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.h [modify] https://crrev.com/2b7f29d7263f980fbfb3a391210ae14fd1baa429/chrome/browser/chromeos/file_manager/path_util.cc [modify] https://crrev.com/2b7f29d7263f980fbfb3a391210ae14fd1baa429/chrome/browser/chromeos/file_manager/path_util.h [modify] https://crrev.com/2b7f29d7263f980fbfb3a391210ae14fd1baa429/chrome/browser/chromeos/file_manager/volume_manager.cc [modify] https://crrev.com/2b7f29d7263f980fbfb3a391210ae14fd1baa429/chrome/browser/chromeos/file_manager/volume_manager.h [modify] https://crrev.com/2b7f29d7263f980fbfb3a391210ae14fd1baa429/ui/file_manager/integration_tests/file_manager/background.js [modify] https://crrev.com/2b7f29d7263f980fbfb3a391210ae14fd1baa429/ui/file_manager/integration_tests/file_manager/gear_menu.js [modify] https://crrev.com/2b7f29d7263f980fbfb3a391210ae14fd1baa429/ui/file_manager/integration_tests/file_manager/my_files.js [modify] https://crrev.com/2b7f29d7263f980fbfb3a391210ae14fd1baa429/ui/file_manager/integration_tests/test_util.js
Modified this bug for only adding the Android Files volume and not the Media Views.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b55e2595f9b64e3cc54a08240ab4d122062fe958 commit b55e2595f9b64e3cc54a08240ab4d122062fe958 Author: Alex Lau <alexlau@chromium.org> Date: Tue Sep 11 08:14:09 2018 Cleanup Files app gear menu integration tests. Add missing assertions after callRemoteTestUtil invocations. LOG(FATAL) instead of assertion when trying to add entries to a non-existant Android Files test volume. Also remove unnecessary AndroidFilesTestVolume.Initialize() call. Bug: 877371 Change-Id: I925ad37a056e411eb3a5bd833cad59a5ce11fae3 Reviewed-on: https://chromium-review.googlesource.com/1218664 Reviewed-by: Noel Gordon <noel@chromium.org> Commit-Queue: Alex Lau <alexlau@chromium.org> Cr-Commit-Position: refs/heads/master@{#590232} [modify] https://crrev.com/b55e2595f9b64e3cc54a08240ab4d122062fe958/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc [modify] https://crrev.com/b55e2595f9b64e3cc54a08240ab4d122062fe958/chrome/browser/chromeos/file_manager/path_util.cc [modify] https://crrev.com/b55e2595f9b64e3cc54a08240ab4d122062fe958/chrome/browser/chromeos/file_manager/path_util.h [modify] https://crrev.com/b55e2595f9b64e3cc54a08240ab4d122062fe958/chrome/browser/chromeos/file_manager/volume_manager.cc [modify] https://crrev.com/b55e2595f9b64e3cc54a08240ab4d122062fe958/ui/file_manager/integration_tests/file_manager/gear_menu.js
New test added above, once can see them here and how they are progressing on our various bots (RELEASE/DEBUG/MSAN/ASAN). https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=AndroidFolders
Comment 1 by lucmult@chromium.org
, Aug 27