PWA windows on Linux: App menu doesn't respond to mouse click |
||||
Issue description
Chrome Version: 70
OS: Linux
What steps will reproduce the problem?
(1) Patch in the diff below to enable custom window frames on Linux.
(2) Install a PWA.
(3) Open the PWA.
(4) Click the app menu (3-dot) button.
What is the expected result?
Menu opens.
What happens instead?
Nothing (although the hover animation still shows).
Seems to only affect Linux (Windows 7, which shares the same code, works).
Code to enable custom window frames due to alancutter@:
--- a/chrome/browser/ui/views/frame/desktop_browser_frame_aurax11.cc
+++ b/chrome/browser/ui/views/frame/desktop_browser_frame_aurax11.cc
@@ -53,8 +53,8 @@ views::Widget::InitParams DesktopBrowserFrameAuraX11::GetWidgetParams() {
}
bool DesktopBrowserFrameAuraX11::UseCustomFrame() const {
- return use_custom_frame_pref_.GetValue() &&
- browser_view()->IsBrowserTypeNormal();
+ return (use_custom_frame_pref_.GetValue() &&
+ browser_view()->IsBrowserTypeNormal()) || browser_view()->browser()->hosted_app_controller();
}
,
Aug 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/69efb9709a1089a5945d23864115a1c2a6d16a5a commit 69efb9709a1089a5945d23864115a1c2a6d16a5a Author: Matt Giuca <mgiuca@chromium.org> Date: Wed Aug 29 01:17:37 2018 Fixed PWA app menu not responding to mouse click on Linux. Was missing hit testing logic. Fixed by copying hit testing logic from GlassBrowserFrameView. Bug: 877363 Test: Open PWA window, click 3-dot menu in top-right of title bar. Change-Id: I63eff9e34ddedc862de53869f18dd58db9fdc39f Reviewed-on: https://chromium-review.googlesource.com/1188010 Reviewed-by: Bret Sepulveda <bsep@chromium.org> Reviewed-by: Alan Cutter <alancutter@chromium.org> Commit-Queue: Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#586980} [modify] https://crrev.com/69efb9709a1089a5945d23864115a1c2a6d16a5a/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
,
Aug 29
,
Aug 30
Tried to test the issue on chrome 70.0.3530.0 using Ubuntu 17.10, build without fix. Steps: ------ 1. Launched chrome 2. Tried to install the PWA app 3. Installed prerequisites of Visual studio and npm but unable to launch the PWA app. mgiuca@: Requesting you to please provide proper steps to install PWA on Linux and help us in verifying the fix. Thanks..!
,
Aug 31
Sorry. You shouldn't need Visual Studio or anything. Just go to https://killer-marmot.appspot.com/web, then Chrome menu -> Install Killer Marmot. This installs the PWA.
,
Sep 3
Able to Verify the fix on Ubuntu 14.04 using Chrome version # 71.0.3541.0. Attaching screen-cast for reference. Observed that " Menu opens by clicking app menu (3-dot) button " The fix is working as expected, adding Verified labels Thanks...! |
||||
►
Sign in to add a comment |
||||
Comment 1 by mgiuca@chromium.org
, Aug 24