cronet_tests failing on multiple builders |
||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of hayato@google.com cronet_tests failing on multiple builders Builders failed on: - Linux Tests (dbg)(1)(32): https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29%2832%29
,
Aug 24
Reverting a culprit at https://chromium-review.googlesource.com/c/chromium/src/+/1187982
,
Aug 24
,
Aug 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3189010800a3d171ada31068ef82fbda172e365b commit 3189010800a3d171ada31068ef82fbda172e365b Author: Wez <wez@chromium.org> Date: Fri Aug 24 23:57:42 2018 Check that TaskScheduler is not leaked between tests, or test-cases. This is a reland of a2a4e75d2752687d91e1272450bdcc6e48b33739 with a work-around for cronet_tests' sharing libbase.so with libcronet.so in component builds. - Move some APIs off of base::TestSuite, that we unnecessarily public. - Rename the various internal TestEventListeners to express purpose. - Add CheckForLeakedGlobals check, and DisableCheckForLeakedGlobals API. The latter is called by the content::ContentTestSuiteBase, since the various browser- and ui-tests running under that suite base run more like the browser itself, and so are expected to let global singletons leak. If tests fail or flake due to this patch, then this indicates that the test is actually leaking global state that may break other tests if they happen to run in the same process, leading to hard-to-diagnose flakes. There are two main failure cases: If the test directly or indirectly uses TaskScheduler, but does not create a ScopedTaskEnvironment, then please add one to the test, or to the test base-class, as appropriate, to fix it. If the test suite cannot be fixed in this way then please add a call to DisableCheckForLeakedGlobals(), with a comment linking to a bug for the issue. TBR: gab, sky, mef Bug: 875486, 877355 , 744567 Change-Id: Iaea38d24ede271c248a3abb0b3f7ee931c2538f5 Reviewed-on: https://chromium-review.googlesource.com/1187783 Reviewed-by: Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#586065} [modify] https://crrev.com/3189010800a3d171ada31068ef82fbda172e365b/base/test/test_suite.cc [modify] https://crrev.com/3189010800a3d171ada31068ef82fbda172e365b/base/test/test_suite.h [modify] https://crrev.com/3189010800a3d171ada31068ef82fbda172e365b/chrome/test/base/chrome_test_launcher.cc [modify] https://crrev.com/3189010800a3d171ada31068ef82fbda172e365b/chrome/test/base/interactive_ui_tests_main.cc [modify] https://crrev.com/3189010800a3d171ada31068ef82fbda172e365b/chromecast/app/cast_test_launcher.cc [modify] https://crrev.com/3189010800a3d171ada31068ef82fbda172e365b/components/cronet/BUILD.gn [modify] https://crrev.com/3189010800a3d171ada31068ef82fbda172e365b/components/cronet/run_all_unittests.cc [modify] https://crrev.com/3189010800a3d171ada31068ef82fbda172e365b/content/test/content_test_launcher.cc [modify] https://crrev.com/3189010800a3d171ada31068ef82fbda172e365b/extensions/shell/test/shell_test_launcher_delegate.cc [modify] https://crrev.com/3189010800a3d171ada31068ef82fbda172e365b/headless/test/headless_test_launcher.cc [modify] https://crrev.com/3189010800a3d171ada31068ef82fbda172e365b/webrunner/browser/webrunner_test_launcher.cc |
||
►
Sign in to add a comment |
||
Comment 1 by hayato@chromium.org
, Aug 24