Mojofy content::ChangedVersionAttributesMask |
|||
Issue descriptionThis issue aims using a mojom type blink::mojom::ChangedVersionAttributesMask to replace the native type content::ChangedVersionAttributesMask, in the meantime addresses the TODO at https://cs.chromium.org/chromium/src/third_party/blink/public/mojom/service_worker/service_worker_registration.mojom?rcl=aa6aaad888ee4619f709de684992cac9b5d69075&l=101.
,
Aug 24
WDYT about the above proposal? Thanks.
,
Aug 28
Seems fine. I'd like to avoid "Version" in the mojom though, it's an internal name from our C++ implementation that doesn't match the spec or make much sense in the renderer process. Maybe ChangedServiceWorker(Object)sMask and SetServiceWorker(Object)s.
,
Aug 28
Thank you Matt!
Updated:
- Define a new mojom type in third_party/blink/public/mojom/service_worker/service_worker_registration.mojom:
struct ChangedServiceWorkerObjectsMask {
bool installing;
bool waiting;
bool active;
}
- Change ServiceWorkerRegistrationObject.SetVersionAttributes():
SetServiceWorkerObjects(ChangedServiceWorkerObjectsMask changed_mask,
ServiceWorkerObjectInfo? installing,
ServiceWorkerObjectInfo? waiting,
ServiceWorkerObjectInfo? active);
- Remove content::ChangedVersionAttributesMask, instead, use blink::mojom::ChangedServiceWorkerObjectsMask everywhere.
,
Aug 30
Hi, would you please help request EditBugs & Trybots access for Richard? Thus he can be assigned as the owner of bugs and trigger dry run for his CLs by himself. Thank you all :)
,
Aug 30
Requested.
,
Sep 1
,
Sep 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a89ff6f6c64e7abdd152f2167dc82fe9b9299461 commit a89ff6f6c64e7abdd152f2167dc82fe9b9299461 Author: Richard Li <richard.li@intel.com> Date: Wed Sep 05 06:53:41 2018 [ServiceWorker] Mojofy content::ChangedVersionAttributesMask This CL aims to solve Issue 877341 , which plans to replace content::ChangedVersionAttributesMask with a new mojom type: blink::mojom::ChangedVersionAttributesMask. Bug: 877341 Change-Id: I2670e5ad52fce4e01281567dd8a7e55165ece51e Reviewed-on: https://chromium-review.googlesource.com/1201350 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Richard Li <richard.li@intel.com> Cr-Commit-Position: refs/heads/master@{#588783} [modify] https://crrev.com/a89ff6f6c64e7abdd152f2167dc82fe9b9299461/content/browser/service_worker/service_worker_job_unittest.cc [modify] https://crrev.com/a89ff6f6c64e7abdd152f2167dc82fe9b9299461/content/browser/service_worker/service_worker_provider_host.cc [modify] https://crrev.com/a89ff6f6c64e7abdd152f2167dc82fe9b9299461/content/browser/service_worker/service_worker_provider_host.h [modify] https://crrev.com/a89ff6f6c64e7abdd152f2167dc82fe9b9299461/content/browser/service_worker/service_worker_registration.cc [modify] https://crrev.com/a89ff6f6c64e7abdd152f2167dc82fe9b9299461/content/browser/service_worker/service_worker_registration.h [modify] https://crrev.com/a89ff6f6c64e7abdd152f2167dc82fe9b9299461/content/browser/service_worker/service_worker_registration_object_host.cc [modify] https://crrev.com/a89ff6f6c64e7abdd152f2167dc82fe9b9299461/content/browser/service_worker/service_worker_registration_object_host.h [modify] https://crrev.com/a89ff6f6c64e7abdd152f2167dc82fe9b9299461/content/browser/service_worker/service_worker_registration_unittest.cc [modify] https://crrev.com/a89ff6f6c64e7abdd152f2167dc82fe9b9299461/content/common/service_worker/service_worker_types.h [modify] https://crrev.com/a89ff6f6c64e7abdd152f2167dc82fe9b9299461/content/renderer/service_worker/web_service_worker_registration_impl.cc [modify] https://crrev.com/a89ff6f6c64e7abdd152f2167dc82fe9b9299461/content/renderer/service_worker/web_service_worker_registration_impl.h [modify] https://crrev.com/a89ff6f6c64e7abdd152f2167dc82fe9b9299461/third_party/blink/public/mojom/service_worker/service_worker_registration.mojom
,
Sep 10
|
|||
►
Sign in to add a comment |
|||
Comment 1 by leon....@intel.com
, Aug 24Proposal: - Define a new mojom type in third_party/blink/public/mojom/service_worker/service_worker_registration.mojom: struct ChangedVersionAttributesMask { bool installing; bool waiting; bool active; } - Change ServiceWorkerRegistrationObject.SetVersionAttributes(): SetVersionAttributes(ChangedVersionAttributesMask changed_mask, ServiceWorkerObjectInfo? installing, ServiceWorkerObjectInfo? waiting, ServiceWorkerObjectInfo? active); - Remove content::ChangedVersionAttributesMask, instead, use blink::mojom::ChangedVersionAttributesMask everywhere.