New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 877304 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Change CIPD deps to use instance ids

Project Member Reported by agrieve@chromium.org, Aug 24

Issue description

As shown by   bug 866912  , using tags for CIPD deps is a bit risky. It's just as easy to use instance IDs (similar to git hashes), so we should make the switch.

This change shows how to do that:
https://chromium-review.googlesource.com/c/chromium/src/+/1187003

Tasks involved here:
1) update //docs/cipd.md instructions to show how to get the instance id (it's printed in the logs when you run cipd create)
2) Update all DEPS to use instance id rather than tag (will likely involve having to write a script to do the transformation)
3) Update the //third_party/android_deps script print out different cipd commands
 
Description: Show this description
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1427629406af9c8d9a93dff31af694e283e9ef87

commit 1427629406af9c8d9a93dff31af694e283e9ef87
Author: John Budorick <jbudorick@chromium.org>
Date: Thu Nov 29 19:07:09 2018

Use instance IDs for non-android_deps cipd deps.

Updating android_deps is a bit more involved & will be in a
separate CL.

Bug: 877304
Change-Id: Ic297766125ffd638b8190033736d301ce650a86e
Reviewed-on: https://chromium-review.googlesource.com/c/1350879
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612297}
[modify] https://crrev.com/1427629406af9c8d9a93dff31af694e283e9ef87/DEPS
[modify] https://crrev.com/1427629406af9c8d9a93dff31af694e283e9ef87/docs/cipd.md

Sign in to add a comment