New issue
Advanced search Search tips

Issue 877291 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 12
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

No gesture support on Apple Magic Trackpad 2

Project Member Reported by seobrien@chromium.org, Aug 24

Issue description

What steps will reproduce the problem?
(1) Connect Apple Magic Trackpad 2 by USB or Bluetooth
(2) Try to perform a multi-finger gesture (scroll, pinch)

What is the expected result?
Gesture is performed

What happens instead?
Cursor moves



 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 9

Labels: merge-merged-chromeos-4.14
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/8b37828483acbbea6f0eda7ed7efeb0b1bce4f03

commit 8b37828483acbbea6f0eda7ed7efeb0b1bce4f03
Author: Sean O'Brien <seobrien@chromium.org>
Date: Tue Oct 09 23:26:42 2018

BACKPORT: FROMGIT: HID: magicmouse: add support for Apple Magic Trackpad 2

USB device
        Vendor 05ac (Apple)
        Device 0265 (Magic Trackpad 2)
Bluetooth device
        Vendor 004c (Apple)
        Device 0265 (Magic Trackpad 2)

Add support for Apple Magic Trackpad 2 over USB and bluetooth, putting
the device in multi-touch mode.

Signed-off-by: Claudio Mettler <claudio@ponyfleisch.ch>
Signed-off-by: Marek Wyborski <marek.wyborski@emwesoft.com>
Signed-off-by: Sean O'Brien <seobrien@chromium.org>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
(cherry picked from commit 9d7b18668956c411a422d04c712994c5fdb23a4b
git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git
for-4.20/apple)

Register device in hid-core as having a special driver.  Use older
format for hid_register_report.

BUG= chromium:877291 
TEST=manually test trackpad 2 on BT and USB, and check for regressions
on trackpad 1 and magic mouse.

Change-Id: I334ccab1e190ee25f3e52e0aded2626157eee6ec
Reviewed-on: https://chromium-review.googlesource.com/1265183
Commit-Ready: Sean O'Brien <seobrien@chromium.org>
Tested-by: Sean O'Brien <seobrien@chromium.org>
Reviewed-by: Sean O'Brien <seobrien@chromium.org>

[modify] https://crrev.com/8b37828483acbbea6f0eda7ed7efeb0b1bce4f03/drivers/hid/hid-core.c
[modify] https://crrev.com/8b37828483acbbea6f0eda7ed7efeb0b1bce4f03/drivers/hid/hid-magicmouse.c
[modify] https://crrev.com/8b37828483acbbea6f0eda7ed7efeb0b1bce4f03/drivers/hid/hid-ids.h

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/xorg-conf/+/d97fa2ad945ac213447e068efa36ae63f5118d53

commit d97fa2ad945ac213447e068efa36ae63f5118d53
Author: Sean O'Brien <seobrien@google.com>
Date: Tue Oct 09 23:26:43 2018

Add touchpad configuration for Magic Trackpad 2

BUG= chromium:877291 
TEST=manually tested on eve device over BT and USB

Change-Id: Ic941f38148866f7b655fc4b62806148e1cdae24a
Reviewed-on: https://chromium-review.googlesource.com/1265340
Commit-Ready: Sean O'Brien <seobrien@chromium.org>
Tested-by: Sean O'Brien <seobrien@chromium.org>
Reviewed-by: Sean O'Brien <seobrien@chromium.org>

[modify] https://crrev.com/d97fa2ad945ac213447e068efa36ae63f5118d53/40-touchpad-cmt.conf

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 9

Labels: merge-merged-chromeos-4.4
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/7e40e6c2daea36dafff710ffab00b6f2dddd996c

commit 7e40e6c2daea36dafff710ffab00b6f2dddd996c
Author: Sean O'Brien <seobrien@chromium.org>
Date: Tue Oct 09 23:26:46 2018

BACKPORT: FROMGIT: HID: magicmouse: add support for Apple Magic Trackpad 2

USB device
        Vendor 05ac (Apple)
        Device 0265 (Magic Trackpad 2)
Bluetooth device
        Vendor 004c (Apple)
        Device 0265 (Magic Trackpad 2)

Add support for Apple Magic Trackpad 2 over USB and bluetooth, putting
the device in multi-touch mode.

Signed-off-by: Claudio Mettler <claudio@ponyfleisch.ch>
Signed-off-by: Marek Wyborski <marek.wyborski@emwesoft.com>
Signed-off-by: Sean O'Brien <seobrien@chromium.org>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
(cherry picked from commit 9d7b18668956c411a422d04c712994c5fdb23a4b
git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git
for-4.20/apple)

Register device in hid-core as having a special driver.  Use older
format for hid_register_report.

BUG= chromium:877291 
TEST=manually test trackpad 2 on BT and USB, and check for regressions
on trackpad 1 and magic mouse.

Change-Id: I9ac45bc8697827413b81d1f4628d4e85c30f1e7c
Reviewed-on: https://chromium-review.googlesource.com/1265181
Commit-Ready: Sean O'Brien <seobrien@chromium.org>
Tested-by: Sean O'Brien <seobrien@chromium.org>
Reviewed-by: Sean O'Brien <seobrien@chromium.org>

[modify] https://crrev.com/7e40e6c2daea36dafff710ffab00b6f2dddd996c/drivers/hid/hid-core.c
[modify] https://crrev.com/7e40e6c2daea36dafff710ffab00b6f2dddd996c/drivers/hid/hid-magicmouse.c
[modify] https://crrev.com/7e40e6c2daea36dafff710ffab00b6f2dddd996c/drivers/hid/hid-ids.h

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 10

Labels: merge-merged-chromeos-3.18
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/3aa987d1b4417ccfa55791a53112ebf91ab26b0a

commit 3aa987d1b4417ccfa55791a53112ebf91ab26b0a
Author: Sean O'Brien <seobrien@chromium.org>
Date: Wed Oct 10 12:19:38 2018

BACKPORT: FROMGIT: HID: magicmouse: add support for Apple Magic Trackpad 2

USB device
        Vendor 05ac (Apple)
        Device 0265 (Magic Trackpad 2)
Bluetooth device
        Vendor 004c (Apple)
        Device 0265 (Magic Trackpad 2)

Add support for Apple Magic Trackpad 2 over USB and bluetooth, putting
the device in multi-touch mode.

Signed-off-by: Claudio Mettler <claudio@ponyfleisch.ch>
Signed-off-by: Marek Wyborski <marek.wyborski@emwesoft.com>
Signed-off-by: Sean O'Brien <seobrien@chromium.org>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
(cherry picked from commit 9d7b18668956c411a422d04c712994c5fdb23a4b
git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git
for-4.20/apple)

Register device in hid-core as having a special driver.  Use older
format for hid_register_report.

BUG= chromium:877291 
TEST=manually test trackpad 2 on BT and USB, and check for regressions
on trackpad 1 and magic mouse.

Change-Id: I81d59f1969e1b61c4ca7c993191953ac2aba5ac9
Reviewed-on: https://chromium-review.googlesource.com/1265179
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Sean O'Brien <seobrien@chromium.org>
Reviewed-by: Dmitry Torokhov <dtor@chromium.org>

[modify] https://crrev.com/3aa987d1b4417ccfa55791a53112ebf91ab26b0a/drivers/hid/hid-core.c
[modify] https://crrev.com/3aa987d1b4417ccfa55791a53112ebf91ab26b0a/drivers/hid/hid-magicmouse.c
[modify] https://crrev.com/3aa987d1b4417ccfa55791a53112ebf91ab26b0a/drivers/hid/hid-ids.h

Status: Fixed (was: Untriaged)
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/xorg-conf/+/fd8fdfa73c965519e412925107d8dc309c8a0def

commit fd8fdfa73c965519e412925107d8dc309c8a0def
Author: Sean O'Brien <seobrien@google.com>
Date: Wed Dec 05 01:40:18 2018

Tune touchpad configuration for Magic Trackpad 2

Click and drag was difficult because the clicking finger was being
classified as a palm.  Tune palm detection thresholds.

BUG= chromium:877291 
TEST=manually tested on eve device over BT and USB

Change-Id: I7444b6c6f3c14dc24229089757560e6816044c8e
Reviewed-on: https://chromium-review.googlesource.com/1361880
Commit-Ready: Sean O'Brien <seobrien@chromium.org>
Tested-by: Sean O'Brien <seobrien@chromium.org>
Reviewed-by: Sean O'Brien <seobrien@chromium.org>

[modify] https://crrev.com/fd8fdfa73c965519e412925107d8dc309c8a0def/40-touchpad-cmt.conf

Sign in to add a comment