New issue
Advanced search Search tips

Issue 877286 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[wasm] Module serialization WPT tests fail

Project Member Reported by binji@chromium.org, Aug 24

Issue description

These two WPT fail:

virtual/enable_wasm/external/wpt/wasm/serialization/no-transferring.html
virtual/enable_wasm/external/wpt/wasm/serialization/serialization-via-history.html

It looks like no-transferring fails because it throws TypeError instead of DataCloneError.

It looks like serialization-via-history fails because no error is thrown at all.
 
Seems like the same happens for serialization-via-notifications-api.any.js
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dfb5d789a0e7c31e01ef494fa193e600e0cd84eb

commit dfb5d789a0e7c31e01ef494fa193e600e0cd84eb
Author: Ben Smith <binji@chromium.org>
Date: Tue Aug 28 18:26:57 2018

[wasm] Disallow serialization of WebAssembly.Modules for storage

This is no longer allowed in the WebAssembly spec, see
https://webassembly.github.io/spec/web-api/index.html#serialization

Bug: chromium:877286
Change-Id: I11f64cf8537eb893fc037e411f4eba80af8d946b
Reviewed-on: https://chromium-review.googlesource.com/1192337
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Ben Smith <binji@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586794}
[modify] https://crrev.com/dfb5d789a0e7c31e01ef494fa193e600e0cd84eb/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/dfb5d789a0e7c31e01ef494fa193e600e0cd84eb/third_party/blink/renderer/bindings/core/v8/serialization/v8_script_value_serializer.cc

Sign in to add a comment