New issue
Advanced search Search tips

Issue 877264 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 2
Type: Bug



Sign in to add a comment

switch cast fuchsia bots to non-headless build

Project Member Reported by sergeyu@chromium.org, Aug 23

Issue description

Currently cast-fuchsia build audio-only build. We have Scenic support now, so it should be possible to build non-headless cast shell.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a57e9063d10bc3d1ad0b0c39a2b93f48b0c3500

commit 3a57e9063d10bc3d1ad0b0c39a2b93f48b0c3500
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Fri Aug 24 20:53:17 2018

Enable DesktopWindowtreeHostPlatform on Fuchsia

With this change it will be possible to build //ui/views on Fuchsia.

Bug:  829980 ,  877264 
Change-Id: I9fb7be4a76f942ffc9945f87c4430a6457cd6f87
Reviewed-on: https://chromium-review.googlesource.com/1187649
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585985}
[modify] https://crrev.com/3a57e9063d10bc3d1ad0b0c39a2b93f48b0c3500/ui/views/BUILD.gn

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6bd345017a9cf81abd12c271e6a635a084ed9252

commit 6bd345017a9cf81abd12c271e6a635a084ed9252
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Fri Aug 24 23:42:35 2018

Disable cast ozone platform on Fuchsia.

Scenic is the only ozone platform usable on fuchsia. Previously,
when compiling with is_chromecast=true the cast platform was enabled,
so cast_shell wasn't compiling properly.

Bug:  877264 
Change-Id: If40c4ad28678015a2e357f86336cf56e1c484ac7
Reviewed-on: https://chromium-review.googlesource.com/1187654
Reviewed-by: Michael Spang <spang@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586059}
[modify] https://crrev.com/6bd345017a9cf81abd12c271e6a635a084ed9252/ui/ozone/ozone.gni

Cc: sergeyu@chromium.org w...@chromium.org
Labels: -Pri-3 M-72 Pri-2
Owner: jbudorick@chromium.org
cast_shell now compiles on Fuchsia with is_cast_audio_only=false. 
John, can you please help us setup buildbots and trybot for non-audio-only cast_shell builds? I think we still need to keep bots for audio-only builds. I suggest replacing arm64 fuchsia cast bots with non-audio and keep the x64 bots as is.
Wez, WDYT?
Re #3: IMO just switching the existing bots from audio-only to video builds should be fine; one is more-or-less a subset of the other.
#3,#4: to clarify: you'd like to remove is_cast_audio_only=true from the fuchsia cast audio bots and presumably rename them to something like "fuchsia-$arch-cast"? Any other compile argument or test changes? Just arm64 or both arm64 and x64?
Re #5: Removing the flag & renaming, for both ARM64 & x64 seems sensible to me, but I'll check with sergeyu@ why he'd like to keep audio-only!
As discussed in chat it's not worth to keep the audio-only bots, lets remove is_cast_audio_only on both bots. Renaming to fuchsia-$arch-cast SGTM. 
Status: Assigned (was: Started)
Alrighty. Will take care of this this week.
Project Member

Comment 10 by bugdroid1@chromium.org, Nov 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/4577e320e5479f0309cc2677492a96b8ce46f9c9

commit 4577e320e5479f0309cc2677492a96b8ce46f9c9
Author: John Budorick <jbudorick@chromium.org>
Date: Thu Nov 08 16:47:22 2018

Add recipe configurations for revised fuchsia cast builders.

Bug:  877264 
Change-Id: Ifa713c1b0cfa066fdfabebb946665fa78dbca051
Reviewed-on: https://chromium-review.googlesource.com/c/1325090
Auto-Submit: John Budorick <jbudorick@chromium.org>
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Garrett Beaty <gbeaty@chromium.org>

[modify] https://crrev.com/4577e320e5479f0309cc2677492a96b8ce46f9c9/scripts/slave/recipe_modules/chromium_tests/chromium_linux.py
[modify] https://crrev.com/4577e320e5479f0309cc2677492a96b8ce46f9c9/scripts/slave/recipe_modules/chromium_tests/trybots.py

Project Member

Comment 11 by bugdroid1@chromium.org, Nov 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c58db1772c85aae93604b11906d6576671814d5

commit 6c58db1772c85aae93604b11906d6576671814d5
Author: John Budorick <jbudorick@chromium.org>
Date: Sat Nov 10 01:01:48 2018

Switch the fuchsia cast audio builders to simply cast.

This CL:
  - renames "Fuchsia {ARM64,x64} Cast Audio" -> fuchsia-{arm64,x64}-cast
  - renames fuchsia_{arm64,x64}_cast_audio -> fuchsia-{arm64,x64}-cast
  - drops is_cast_audio_only=true from all of the above

Requires crrev.com/c/1325090

Bug:  877264 
Change-Id: I4cf02d4719caf3ec7fff43b51f77ce64b644d7f8
Reviewed-on: https://chromium-review.googlesource.com/c/1324457
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607058}
[modify] https://crrev.com/6c58db1772c85aae93604b11906d6576671814d5/infra/config/global/cr-buildbucket.cfg
[modify] https://crrev.com/6c58db1772c85aae93604b11906d6576671814d5/infra/config/global/luci-milo.cfg
[modify] https://crrev.com/6c58db1772c85aae93604b11906d6576671814d5/infra/config/global/luci-scheduler.cfg
[modify] https://crrev.com/6c58db1772c85aae93604b11906d6576671814d5/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/6c58db1772c85aae93604b11906d6576671814d5/testing/buildbot/waterfalls.pyl
[modify] https://crrev.com/6c58db1772c85aae93604b11906d6576671814d5/tools/mb/mb_config.pyl

Project Member

Comment 12 by bugdroid1@chromium.org, Nov 10

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/43eed580a711b6fa3c17ee91a8c14ff22cb7390f

commit 43eed580a711b6fa3c17ee91a8c14ff22cb7390f
Author: John Budorick <jbudorick@google.com>
Date: Sat Nov 10 01:25:28 2018

Project Member

Comment 13 by bugdroid1@chromium.org, Nov 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c9f746f66ddc55f40450f3e6aa4e45a81ffeaab

commit 5c9f746f66ddc55f40450f3e6aa4e45a81ffeaab
Author: John Budorick <jbudorick@chromium.org>
Date: Mon Nov 12 17:05:50 2018

luci: update two more references to fuchsia-{arm64,x64}-cast.

Tbr: martiniss@chromium.org
Bug:  877264 
Change-Id: Icd73a35287a406a2fbe87669cbb5f472a0b4d413
Reviewed-on: https://chromium-review.googlesource.com/c/1331417
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607274}
[modify] https://crrev.com/5c9f746f66ddc55f40450f3e6aa4e45a81ffeaab/infra/config/global/cr-buildbucket.cfg
[modify] https://crrev.com/5c9f746f66ddc55f40450f3e6aa4e45a81ffeaab/infra/config/global/luci-milo.cfg

Project Member

Comment 15 by bugdroid1@chromium.org, Nov 12

The following revision refers to this bug:
  https://skia.googlesource.com/buildbot/+/b445d0ffcb5538736720d9d90cdf2fe90494830b

commit b445d0ffcb5538736720d9d90cdf2fe90494830b
Author: John Budorick <jbudorick@chromium.org>
Date: Mon Nov 12 19:18:11 2018

Update the fuchsia cast trybot names.

Bug:  chromium:877264 
Change-Id: I072b722fce4bae92906c850afe8655be4a0aedde
Reviewed-on: https://skia-review.googlesource.com/c/170447
Auto-Submit: John Budorick <jbudorick@chromium.org>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>

[modify] https://crrev.com/b445d0ffcb5538736720d9d90cdf2fe90494830b/autoroll/config/fuchsia-sdk-chromium.json

Project Member

Comment 16 by bugdroid1@chromium.org, Nov 12

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/94a335d3e4f9666df99531585ddf97d31aa6a83c

commit 94a335d3e4f9666df99531585ddf97d31aa6a83c
Author: John Budorick <jbudorick@google.com>
Date: Mon Nov 12 19:36:28 2018

Project Member

Comment 18 by bugdroid1@chromium.org, Nov 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/dcf5d685db3153c9e930a0eb0a944b3a657f0cc1

commit dcf5d685db3153c9e930a0eb0a944b3a657f0cc1
Author: John Budorick <jbudorick@chromium.org>
Date: Mon Nov 26 20:36:44 2018

gatekeeper: update fuchsia-*-cast bot names.

Tbr: wez@chromium.org
Bug:  877264 
Change-Id: Ibf33434bd4d583f6a05eaddeb89e64e0e20ff1d1
Reviewed-on: https://chromium-review.googlesource.com/c/1351254
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>

[modify] https://crrev.com/dcf5d685db3153c9e930a0eb0a944b3a657f0cc1/scripts/slave/gatekeeper.json

Sign in to add a comment