New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 877250 link

Starred by 1 user
Status: Fixed
Owner:
█ zhelfins@chromium.org
Last visit > 30 days ago
Closed: Aug 29
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug
Team-Accessibility



Sign in to add a comment

Focus rects draw offscreen

Project Member Reported by zhelfins@chromium.org, Aug 23 
Focus rects will sometimes draw with up to three sides entirely offscreen. (This is especially common with SwitchAccess.) We want to snap those offscreen dimensions to the edge of the screen so they are visible, but visually distinct so users have an indication that the selected area may go offscreen.

Comment 1 by zhelfins@chromium.org, Aug 23 

Here are some images of the focus ring when it's been forced onscreen:
Screenshot from 2018-08-23 15-02-43.png
62.3 KB View Download
Screenshot from 2018-08-23 15-03-52.png
62.1 KB View Download
Screenshot from 2018-08-23 15-04-22.png
61.9 KB View Download
Screenshot from 2018-08-23 15-04-33.png
61.9 KB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c98a1b356e99265126272d2363711a2eb815e96

commit 9c98a1b356e99265126272d2363711a2eb815e96
Author: Zach Helfinstein <zhelfins@chromium.org>
Date: Wed Aug 29 00:00:32 2018

Force Accesssibility focus rings to show onscreen

The appearance of the focus ring when forced onscreen can be seen in
the screenshots posted in the bug:  http://crbug.com/877250 

Bug:  877250 
Change-Id: I6b5e508c290ad3fcaf429d7a6fa57ba392ddd9fe
Reviewed-on: https://chromium-review.googlesource.com/1187560
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Zach Helfinstein <zhelfins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586943}
[modify] https://crrev.com/9c98a1b356e99265126272d2363711a2eb815e96/ash/accessibility/accessibility_focus_ring.cc
[modify] https://crrev.com/9c98a1b356e99265126272d2363711a2eb815e96/ash/accessibility/accessibility_focus_ring.h
[modify] https://crrev.com/9c98a1b356e99265126272d2363711a2eb815e96/ash/accessibility/accessibility_focus_ring_group_unittest.cc

Comment 3 by zhelfins@chromium.org, Aug 29

Status: Fixed (was: Started)
►

Sign in to add a comment