Issue metadata
Sign in to add a comment
|
1.2%-1.7% regression in media.mobile at 585103:585228 |
||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Aug 23
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/1403705e640000
,
Aug 27
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/1403705e640000 Remove Modern flag and hardcode #isChromeModernDesignEnabled to true by twellington@chromium.org https://chromium.googlesource.com/chromium/src/+/5955e6d67f3799a0cdd9dba7df8fa5460499f99f 5.381e+06 → 5.471e+06 (+8.926e+04) Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Aug 27
+other folks working on Modern - It looks like there was a regression in GPU memory usage after enabling Modern for the test bots. +media-mobile owners -- Chrome Modern was a visual redesign of some of Clank's core UI. Does it make sense that changing the toolbar style would cause a regression in GPU memory for this perf test?
,
Aug 27
Issue 877244 has been merged into this issue.
,
Aug 28
Yeah, it makes sense that a new design might cause a regression. I would hope that this regression is noted in the launch documentation for Modern. We don't want to gradually bloat Chrome over time with a bunch of small regressions. But it is true that this regression is pretty small.
,
Aug 28
It's not noted anywhere yet (besides this bug). We didn't anticipate any performance regressions and we didn't see any regressions in UMA data during experimentation. Is there a standard way to document this e.g. in the launch bug or in the design doc?
,
Aug 28
I don't know of one. +Tim maybe does.
,
Aug 29
Issue 877184 has been merged into this issue.
,
Sep 2
I captured this perf bot regression in the metrics analysis doc for Modern (draft/work-in-progress): https://uma.googleplex.com/p/chrome/variations/?sid=4d1804556c32d47e8fd55935c8f3eb8a It's worth noting that we did not see a similar GPU memory regression in the experiment group for the modern variant that we are launching ("ImageLast"). The median GPU memory usage for our experiment group (ramped up in M68) is roughly the same as the control group (Control: 27.5598MB, ImageLast: 27.5582MB) as is the mean memory (screenshot attached). This alert is for the "image first" Zine card variant* which has the same mean as the other two groups. The median (27.5874MB) is very slightly higher (~0.1% increase from control) but an order of magnitude lower than the 1.2-1.7% found on the perf bot. UMA link https://uma.googleplex.com/p/chrome/variations/?sid=4d1804556c32d47e8fd55935c8f3eb8a *The image last variant was enabled on ToT in this CL on Aug 30: https://chromium-review.googlesource.com/c/chromium/src/+/1195435
,
Sep 5
,
Oct 10
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Aug 23