"Learn more" link in Clear Browsing Data does not do anything |
|||
Issue descriptionApp Version (from "Chrome Settings > About Chrome"): 70.0.3530.0 canary iOS Version: 11.2.6 Device: iPad, but happens on iPhone too. Steps to reproduce: 1. Go to tab grid 2. Swipe to Other Tabs 3. Tap on Show Full History 4. Tap on Clear Browsing Data... 5. Look for "Learn more" at the instructional text at the bottom. 6. Tap on "Learn more" Observed behavior: Clear Browsing Data screen disappeared, but nothing else comes up. Expected behavior: Support page for "Clear browsing data" should be shown in a new tab. Frequency: Every time Additional comments: None
,
Aug 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/40b6cd645a0293ce714d91ddf533427b81b6506c commit 40b6cd645a0293ce714d91ddf533427b81b6506c Author: Chris Lu <thegreenfrog@chromium.org> Date: Fri Aug 24 15:55:38 2018 [ios] Set ClearBrowsingDataTableViewController and its NavigationController to nil immediately after completing dismiss When a URL is opened, CBD dismisses itself. Then History checks with the CBD coordinator to make sure that CBD is dismissed (nav controller is nil) before dismissing itself. Since we don't set the navController to nil before calling the completion block in dismissClearBrowsingDataWithCompletion:, the CBD coordinator thinks that it still exists so it attempts `[self dismissClearBrowsingDataWithCompletion:completionHandler];`, which then doesn't execute the completion block since there was nothing to dismiss. Video: https://drive.google.com/open?id=1A7-W5LXhjzvh4DcUQguQEv0qWC88Ncp1 Bug: 877243 Change-Id: Id2f67c934e0ef2033abc28f97bb9bf211dbb5ddb Reviewed-on: https://chromium-review.googlesource.com/1187631 Reviewed-by: Sergio Collazos <sczs@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#585857} [modify] https://crrev.com/40b6cd645a0293ce714d91ddf533427b81b6506c/ios/chrome/browser/ui/history/history_clear_browsing_data_coordinator.mm
,
Aug 24
,
Aug 28
Support page for "Clear browsing data"is shown in a new tab.Verified on 70.0.3535.0 Canary on iPhone X iOS 12 Beta #11 , iPad Pro12'9 iOS 11.4 . |
|||
►
Sign in to add a comment |
|||
Comment 1 by thegreenfrog@chromium.org
, Aug 23