We should move all apps-only APIs out of the extensions directories and into apps-related ones. This can include at least chrome/browser/apps/platform_apps for those at the chrome-layer, and likely moving those from //extensions to //apps.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/40cae0658c01a6bb3707b5ce54ed37c5eb7ef54f commit 40cae0658c01a6bb3707b5ce54ed37c5eb7ef54f Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Fri Sep 07 18:34:18 2018 [Extensions + Apps] Create Apps API Set Create a place for Chrome App APIs to go, and move the chrome.browser API there. This is the first API moved from Chrome Apps into the apps- specific directory. This involves a number of steps: - Create a chrome/common/apps/platform_apps/ directory, and create ChromeAppsAPIProvider and ChromeAppsAPIPermissions. The APIProvider is then registered with the singleton ExtensionsClient to provide information about the Chrome Apps APIs to the extension system. - Create chrome/common/apps/platform_apps/api. This includes the API schema definitions (right now, just browser.idl), the features files (_api_features.json and _permission_features.json), and the BUILD.gn to generate the C++ types and JSON API strings. Types are generated in the apps:: namespace, instead of the extensions:: namespace. They are similarly generated into chrome/common/apps/platform_apps/api instead of chrome/common/extensions/api. - Add a ChromeAppsBrowserAPIProvider to register the app-related ExtensionFunctions with the Extensions system. - Move the browser API implementation (browser_api.*) to chrome/browser/apps/platform_apps/api/browser/, and consume the generated types. - Register the new API location with the docserver so that it can look up the API schemas, and bump the docserver version. With this, we have all the pieces necessary to continue moving App- specific APIs en masse to the App-specific directories, and begin to carve out the dependency from the extensions system. Bug: 877240 Change-Id: If3eba512c24ef3d1c27ed5ff3f215f56eb13a818 Reviewed-on: https://chromium-review.googlesource.com/1187129 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#589598} [modify] https://crrev.com/40cae0658c01a6bb3707b5ce54ed37c5eb7ef54f/chrome/browser/apps/platform_apps/BUILD.gn [add] https://crrev.com/40cae0658c01a6bb3707b5ce54ed37c5eb7ef54f/chrome/browser/apps/platform_apps/api/BUILD.gn [rename] https://crrev.com/40cae0658c01a6bb3707b5ce54ed37c5eb7ef54f/chrome/browser/apps/platform_apps/api/browser/browser_api.cc [rename] https://crrev.com/40cae0658c01a6bb3707b5ce54ed37c5eb7ef54f/chrome/browser/apps/platform_apps/api/browser/browser_api.h [add] https://crrev.com/40cae0658c01a6bb3707b5ce54ed37c5eb7ef54f/chrome/browser/apps/platform_apps/api/browser/browser_apitest.cc [add] https://crrev.com/40cae0658c01a6bb3707b5ce54ed37c5eb7ef54f/chrome/browser/apps/platform_apps/chrome_apps_browser_api_provider.cc [add] https://crrev.com/40cae0658c01a6bb3707b5ce54ed37c5eb7ef54f/chrome/browser/apps/platform_apps/chrome_apps_browser_api_provider.h [modify] https://crrev.com/40cae0658c01a6bb3707b5ce54ed37c5eb7ef54f/chrome/browser/browser_process_impl.cc [modify] https://crrev.com/40cae0658c01a6bb3707b5ce54ed37c5eb7ef54f/chrome/browser/extensions/BUILD.gn [delete] https://crrev.com/28254a4cfe0fd868c58a47c47e39a907774ebd7a/chrome/browser/extensions/api/browser/browser_apitest.cc [modify] https://crrev.com/40cae0658c01a6bb3707b5ce54ed37c5eb7ef54f/chrome/common/BUILD.gn [add] https://crrev.com/40cae0658c01a6bb3707b5ce54ed37c5eb7ef54f/chrome/common/apps/OWNERS [add] https://crrev.com/40cae0658c01a6bb3707b5ce54ed37c5eb7ef54f/chrome/common/apps/platform_apps/BUILD.gn [add] https://crrev.com/40cae0658c01a6bb3707b5ce54ed37c5eb7ef54f/chrome/common/apps/platform_apps/api/BUILD.gn [add] https://crrev.com/40cae0658c01a6bb3707b5ce54ed37c5eb7ef54f/chrome/common/apps/platform_apps/api/_api_features.json [add] https://crrev.com/40cae0658c01a6bb3707b5ce54ed37c5eb7ef54f/chrome/common/apps/platform_apps/api/_permission_features.json [add] https://crrev.com/40cae0658c01a6bb3707b5ce54ed37c5eb7ef54f/chrome/common/apps/platform_apps/api/api_sources.gni [rename] https://crrev.com/40cae0658c01a6bb3707b5ce54ed37c5eb7ef54f/chrome/common/apps/platform_apps/api/browser.idl [add] https://crrev.com/40cae0658c01a6bb3707b5ce54ed37c5eb7ef54f/chrome/common/apps/platform_apps/chrome_apps_api_permissions.cc [add] https://crrev.com/40cae0658c01a6bb3707b5ce54ed37c5eb7ef54f/chrome/common/apps/platform_apps/chrome_apps_api_permissions.h [add] https://crrev.com/40cae0658c01a6bb3707b5ce54ed37c5eb7ef54f/chrome/common/apps/platform_apps/chrome_apps_api_provider.cc [add] https://crrev.com/40cae0658c01a6bb3707b5ce54ed37c5eb7ef54f/chrome/common/apps/platform_apps/chrome_apps_api_provider.h [modify] https://crrev.com/40cae0658c01a6bb3707b5ce54ed37c5eb7ef54f/chrome/common/common_resources.grd [modify] https://crrev.com/40cae0658c01a6bb3707b5ce54ed37c5eb7ef54f/chrome/common/extensions/api/_api_features.json [modify] https://crrev.com/40cae0658c01a6bb3707b5ce54ed37c5eb7ef54f/chrome/common/extensions/api/_permission_features.json [modify] https://crrev.com/40cae0658c01a6bb3707b5ce54ed37c5eb7ef54f/chrome/common/extensions/api/api_sources.gni [modify] https://crrev.com/40cae0658c01a6bb3707b5ce54ed37c5eb7ef54f/chrome/common/extensions/docs/server2/app.yaml [modify] https://crrev.com/40cae0658c01a6bb3707b5ce54ed37c5eb7ef54f/chrome/common/extensions/docs/server2/extensions_paths.py [modify] https://crrev.com/40cae0658c01a6bb3707b5ce54ed37c5eb7ef54f/chrome/common/extensions/docs/server2/owners_data_source_test.py [modify] https://crrev.com/40cae0658c01a6bb3707b5ce54ed37c5eb7ef54f/chrome/common/extensions/permissions/chrome_api_permissions.cc [modify] https://crrev.com/40cae0658c01a6bb3707b5ce54ed37c5eb7ef54f/chrome/common/initialize_extensions_client.cc [modify] https://crrev.com/40cae0658c01a6bb3707b5ce54ed37c5eb7ef54f/chrome/test/BUILD.gn [modify] https://crrev.com/40cae0658c01a6bb3707b5ce54ed37c5eb7ef54f/chrome/test/base/testing_browser_process.cc [modify] https://crrev.com/40cae0658c01a6bb3707b5ce54ed37c5eb7ef54f/extensions/common/permissions/api_permission.h [modify] https://crrev.com/40cae0658c01a6bb3707b5ce54ed37c5eb7ef54f/extensions/common/permissions/permissions_provider.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7ec3a07316ebe91706eb2ae520e72679105717a8 commit 7ec3a07316ebe91706eb2ae520e72679105717a8 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Mon Sep 17 15:51:44 2018 [Extensions + Apps] Move the easyUnlockPrivate API Move the easyUnlockPrivate API out of extensions code and into apps code. This includes the API implementation, schema definition, features entries, and API permission info. Bug: 877240 Change-Id: I3ebae9112f6cf609d206008ee7e950a68ffbf22f Reviewed-on: https://chromium-review.googlesource.com/1222917 Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Reviewed-by: James Hawkins <jhawkins@chromium.org> Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#591691} [modify] https://crrev.com/7ec3a07316ebe91706eb2ae520e72679105717a8/chrome/browser/BUILD.gn [modify] https://crrev.com/7ec3a07316ebe91706eb2ae520e72679105717a8/chrome/browser/apps/platform_apps/BUILD.gn [modify] https://crrev.com/7ec3a07316ebe91706eb2ae520e72679105717a8/chrome/browser/apps/platform_apps/api/BUILD.gn [add] https://crrev.com/7ec3a07316ebe91706eb2ae520e72679105717a8/chrome/browser/apps/platform_apps/api/browser_context_keyed_service_factories.cc [add] https://crrev.com/7ec3a07316ebe91706eb2ae520e72679105717a8/chrome/browser/apps/platform_apps/api/browser_context_keyed_service_factories.h [rename] https://crrev.com/7ec3a07316ebe91706eb2ae520e72679105717a8/chrome/browser/apps/platform_apps/api/easy_unlock_private/OWNERS [rename] https://crrev.com/7ec3a07316ebe91706eb2ae520e72679105717a8/chrome/browser/apps/platform_apps/api/easy_unlock_private/easy_unlock_private_api.cc [rename] https://crrev.com/7ec3a07316ebe91706eb2ae520e72679105717a8/chrome/browser/apps/platform_apps/api/easy_unlock_private/easy_unlock_private_api.h [rename] https://crrev.com/7ec3a07316ebe91706eb2ae520e72679105717a8/chrome/browser/apps/platform_apps/api/easy_unlock_private/easy_unlock_private_api_chromeos_unittest.cc [add] https://crrev.com/7ec3a07316ebe91706eb2ae520e72679105717a8/chrome/browser/apps/platform_apps/api/easy_unlock_private/easy_unlock_private_connection.cc [rename] https://crrev.com/7ec3a07316ebe91706eb2ae520e72679105717a8/chrome/browser/apps/platform_apps/api/easy_unlock_private/easy_unlock_private_connection.h [rename] https://crrev.com/7ec3a07316ebe91706eb2ae520e72679105717a8/chrome/browser/apps/platform_apps/api/easy_unlock_private/easy_unlock_private_connection_manager.cc [rename] https://crrev.com/7ec3a07316ebe91706eb2ae520e72679105717a8/chrome/browser/apps/platform_apps/api/easy_unlock_private/easy_unlock_private_connection_manager.h [modify] https://crrev.com/7ec3a07316ebe91706eb2ae520e72679105717a8/chrome/browser/chromeos/login/easy_unlock/easy_unlock_app_manager.cc [modify] https://crrev.com/7ec3a07316ebe91706eb2ae520e72679105717a8/chrome/browser/chromeos/login/easy_unlock/easy_unlock_app_manager_unittest.cc [modify] https://crrev.com/7ec3a07316ebe91706eb2ae520e72679105717a8/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.cc [modify] https://crrev.com/7ec3a07316ebe91706eb2ae520e72679105717a8/chrome/browser/extensions/BUILD.gn [delete] https://crrev.com/43c09a2e74b06599360b3136387906d9aeb8e791/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_connection.cc [modify] https://crrev.com/7ec3a07316ebe91706eb2ae520e72679105717a8/chrome/browser/extensions/browser_context_keyed_service_factories.cc [modify] https://crrev.com/7ec3a07316ebe91706eb2ae520e72679105717a8/chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc [modify] https://crrev.com/7ec3a07316ebe91706eb2ae520e72679105717a8/chrome/common/apps/platform_apps/api/_api_features.json [modify] https://crrev.com/7ec3a07316ebe91706eb2ae520e72679105717a8/chrome/common/apps/platform_apps/api/_permission_features.json [modify] https://crrev.com/7ec3a07316ebe91706eb2ae520e72679105717a8/chrome/common/apps/platform_apps/api/api_sources.gni [rename] https://crrev.com/7ec3a07316ebe91706eb2ae520e72679105717a8/chrome/common/apps/platform_apps/api/easy_unlock_private.idl [modify] https://crrev.com/7ec3a07316ebe91706eb2ae520e72679105717a8/chrome/common/apps/platform_apps/chrome_apps_api_permissions.cc [modify] https://crrev.com/7ec3a07316ebe91706eb2ae520e72679105717a8/chrome/common/extensions/api/_api_features.json [modify] https://crrev.com/7ec3a07316ebe91706eb2ae520e72679105717a8/chrome/common/extensions/api/_permission_features.json [modify] https://crrev.com/7ec3a07316ebe91706eb2ae520e72679105717a8/chrome/common/extensions/api/api_sources.gni [modify] https://crrev.com/7ec3a07316ebe91706eb2ae520e72679105717a8/chrome/common/extensions/permissions/chrome_api_permissions.cc [modify] https://crrev.com/7ec3a07316ebe91706eb2ae520e72679105717a8/chrome/test/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5caf3124fbb3024a441d97d206c5caac5a305302 commit 5caf3124fbb3024a441d97d206c5caac5a305302 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Fri Sep 28 17:55:46 2018 [Extensions + Apps] Move the musicManagerPrivate API Move the musicManagerPrivate API out of extensions code and into apps code. This includes the API implementation, schema definition, features entries, and API permission info. TBR=gab@chromium.org (comment update in chrome_pref_service_factory.cc) Bug: 877240 Change-Id: Id4bec073d3f9698682f40720852843fa03347900 Reviewed-on: https://chromium-review.googlesource.com/1220326 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#595149} [modify] https://crrev.com/5caf3124fbb3024a441d97d206c5caac5a305302/chrome/browser/apps/platform_apps/api/BUILD.gn [add] https://crrev.com/5caf3124fbb3024a441d97d206c5caac5a305302/chrome/browser/apps/platform_apps/api/music_manager_private/BUILD.gn [add] https://crrev.com/5caf3124fbb3024a441d97d206c5caac5a305302/chrome/browser/apps/platform_apps/api/music_manager_private/device_id.cc [rename] https://crrev.com/5caf3124fbb3024a441d97d206c5caac5a305302/chrome/browser/apps/platform_apps/api/music_manager_private/device_id.h [rename] https://crrev.com/5caf3124fbb3024a441d97d206c5caac5a305302/chrome/browser/apps/platform_apps/api/music_manager_private/device_id_chromeos.cc [rename] https://crrev.com/5caf3124fbb3024a441d97d206c5caac5a305302/chrome/browser/apps/platform_apps/api/music_manager_private/device_id_linux.cc [rename] https://crrev.com/5caf3124fbb3024a441d97d206c5caac5a305302/chrome/browser/apps/platform_apps/api/music_manager_private/device_id_mac.cc [rename] https://crrev.com/5caf3124fbb3024a441d97d206c5caac5a305302/chrome/browser/apps/platform_apps/api/music_manager_private/device_id_win.cc [rename] https://crrev.com/5caf3124fbb3024a441d97d206c5caac5a305302/chrome/browser/apps/platform_apps/api/music_manager_private/music_manager_private_api.cc [rename] https://crrev.com/5caf3124fbb3024a441d97d206c5caac5a305302/chrome/browser/apps/platform_apps/api/music_manager_private/music_manager_private_api.h [rename] https://crrev.com/5caf3124fbb3024a441d97d206c5caac5a305302/chrome/browser/apps/platform_apps/api/music_manager_private/music_manager_private_browsertest.cc [modify] https://crrev.com/5caf3124fbb3024a441d97d206c5caac5a305302/chrome/browser/extensions/BUILD.gn [delete] https://crrev.com/42f4734035b913b1689a72f2cbe698d66fb387b0/chrome/browser/extensions/api/music_manager_private/device_id.cc [modify] https://crrev.com/5caf3124fbb3024a441d97d206c5caac5a305302/chrome/browser/prefs/chrome_pref_service_factory.cc [modify] https://crrev.com/5caf3124fbb3024a441d97d206c5caac5a305302/chrome/common/apps/platform_apps/api/BUILD.gn [modify] https://crrev.com/5caf3124fbb3024a441d97d206c5caac5a305302/chrome/common/apps/platform_apps/api/_api_features.json [modify] https://crrev.com/5caf3124fbb3024a441d97d206c5caac5a305302/chrome/common/apps/platform_apps/api/_permission_features.json [modify] https://crrev.com/5caf3124fbb3024a441d97d206c5caac5a305302/chrome/common/apps/platform_apps/api/api_sources.gni [rename] https://crrev.com/5caf3124fbb3024a441d97d206c5caac5a305302/chrome/common/apps/platform_apps/api/music_manager_private.idl [modify] https://crrev.com/5caf3124fbb3024a441d97d206c5caac5a305302/chrome/common/apps/platform_apps/chrome_apps_api_permissions.cc [modify] https://crrev.com/5caf3124fbb3024a441d97d206c5caac5a305302/chrome/common/extensions/api/_api_features.json [modify] https://crrev.com/5caf3124fbb3024a441d97d206c5caac5a305302/chrome/common/extensions/api/_permission_features.json [modify] https://crrev.com/5caf3124fbb3024a441d97d206c5caac5a305302/chrome/common/extensions/api/api_sources.gni [modify] https://crrev.com/5caf3124fbb3024a441d97d206c5caac5a305302/chrome/common/extensions/permissions/chrome_api_permissions.cc [modify] https://crrev.com/5caf3124fbb3024a441d97d206c5caac5a305302/chrome/test/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d128279441127294478d2e41856735aed0d45430 commit d128279441127294478d2e41856735aed0d45430 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Tue Oct 02 16:19:04 2018 [Extensions + Apps] Move the mediaGalleries API Move the mediaGalleries API out of extensions code and into apps code. This includes the API implementation, schema definition, features entries, and API permission info. Bug: 877240 Change-Id: I8b750143cdcd36700f36d9da088ebaec4abd4cfe Reviewed-on: https://chromium-review.googlesource.com/1255584 Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#595866} [modify] https://crrev.com/d128279441127294478d2e41856735aed0d45430/chrome/browser/apps/platform_apps/api/BUILD.gn [rename] https://crrev.com/d128279441127294478d2e41856735aed0d45430/chrome/browser/apps/platform_apps/api/media_galleries/OWNERS [rename] https://crrev.com/d128279441127294478d2e41856735aed0d45430/chrome/browser/apps/platform_apps/api/media_galleries/blob_data_source_factory.cc [rename] https://crrev.com/d128279441127294478d2e41856735aed0d45430/chrome/browser/apps/platform_apps/api/media_galleries/blob_data_source_factory.h [rename] https://crrev.com/d128279441127294478d2e41856735aed0d45430/chrome/browser/apps/platform_apps/api/media_galleries/media_galleries_api.cc [rename] https://crrev.com/d128279441127294478d2e41856735aed0d45430/chrome/browser/apps/platform_apps/api/media_galleries/media_galleries_api.h [rename] https://crrev.com/d128279441127294478d2e41856735aed0d45430/chrome/browser/apps/platform_apps/api/media_galleries/media_galleries_api_util.cc [rename] https://crrev.com/d128279441127294478d2e41856735aed0d45430/chrome/browser/apps/platform_apps/api/media_galleries/media_galleries_api_util.h [rename] https://crrev.com/d128279441127294478d2e41856735aed0d45430/chrome/browser/apps/platform_apps/api/media_galleries/media_galleries_apitest.cc [rename] https://crrev.com/d128279441127294478d2e41856735aed0d45430/chrome/browser/apps/platform_apps/api/media_galleries/media_galleries_watch_apitest.cc [modify] https://crrev.com/d128279441127294478d2e41856735aed0d45430/chrome/browser/extensions/BUILD.gn [modify] https://crrev.com/d128279441127294478d2e41856735aed0d45430/chrome/common/apps/platform_apps/api/_api_features.json [modify] https://crrev.com/d128279441127294478d2e41856735aed0d45430/chrome/common/apps/platform_apps/api/_permission_features.json [modify] https://crrev.com/d128279441127294478d2e41856735aed0d45430/chrome/common/apps/platform_apps/api/api_sources.gni [rename] https://crrev.com/d128279441127294478d2e41856735aed0d45430/chrome/common/apps/platform_apps/api/media_galleries.idl [modify] https://crrev.com/d128279441127294478d2e41856735aed0d45430/chrome/common/apps/platform_apps/chrome_apps_api_permissions.cc [modify] https://crrev.com/d128279441127294478d2e41856735aed0d45430/chrome/common/extensions/api/_api_features.json [modify] https://crrev.com/d128279441127294478d2e41856735aed0d45430/chrome/common/extensions/api/_permission_features.json [modify] https://crrev.com/d128279441127294478d2e41856735aed0d45430/chrome/common/extensions/api/api_sources.gni [modify] https://crrev.com/d128279441127294478d2e41856735aed0d45430/chrome/common/extensions/permissions/chrome_api_permissions.cc [modify] https://crrev.com/d128279441127294478d2e41856735aed0d45430/chrome/test/BUILD.gn [modify] https://crrev.com/d128279441127294478d2e41856735aed0d45430/extensions/common/permissions/media_galleries_permission.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9330393e8efc94d275e8c1ffccd5019147fd6658 commit 9330393e8efc94d275e8c1ffccd5019147fd6658 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Tue Oct 09 00:31:59 2018 [Extensions + Apps] Move the MediaGalleriesPermission to platform_apps Move MediaGalleriesPermission and MediaGalleriesPermissionData out of extensions code and into apps code. This also moves the IPC traits from //extensions/common/extension_messages.h to a new //chrome/common/apps/platform_apps/chrome_apps_messages.h. Bug: 877240 Change-Id: Ieaab74353e8eb8a22015ba108fb5fb5abfd92c71 Reviewed-on: https://chromium-review.googlesource.com/c/1259467 Reviewed-by: Luke Halliwell <halliwell@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#597752} [modify] https://crrev.com/9330393e8efc94d275e8c1ffccd5019147fd6658/chrome/browser/apps/platform_apps/api/BUILD.gn [modify] https://crrev.com/9330393e8efc94d275e8c1ffccd5019147fd6658/chrome/browser/apps/platform_apps/api/media_galleries/media_galleries_api.cc [modify] https://crrev.com/9330393e8efc94d275e8c1ffccd5019147fd6658/chrome/browser/media_galleries/gallery_watch_manager_unittest.cc [modify] https://crrev.com/9330393e8efc94d275e8c1ffccd5019147fd6658/chrome/browser/media_galleries/media_galleries_permission_controller.cc [modify] https://crrev.com/9330393e8efc94d275e8c1ffccd5019147fd6658/chrome/browser/media_galleries/media_galleries_permission_controller_unittest.cc [modify] https://crrev.com/9330393e8efc94d275e8c1ffccd5019147fd6658/chrome/browser/media_galleries/media_galleries_preferences.cc [modify] https://crrev.com/9330393e8efc94d275e8c1ffccd5019147fd6658/chrome/browser/media_galleries/media_galleries_preferences_unittest.cc [modify] https://crrev.com/9330393e8efc94d275e8c1ffccd5019147fd6658/chrome/common/apps/platform_apps/BUILD.gn [add] https://crrev.com/9330393e8efc94d275e8c1ffccd5019147fd6658/chrome/common/apps/platform_apps/OWNERS [modify] https://crrev.com/9330393e8efc94d275e8c1ffccd5019147fd6658/chrome/common/apps/platform_apps/chrome_apps_api_permissions.cc [add] https://crrev.com/9330393e8efc94d275e8c1ffccd5019147fd6658/chrome/common/apps/platform_apps/chrome_apps_message_generator.cc [add] https://crrev.com/9330393e8efc94d275e8c1ffccd5019147fd6658/chrome/common/apps/platform_apps/chrome_apps_message_generator.h [add] https://crrev.com/9330393e8efc94d275e8c1ffccd5019147fd6658/chrome/common/apps/platform_apps/chrome_apps_messages.h [rename] https://crrev.com/9330393e8efc94d275e8c1ffccd5019147fd6658/chrome/common/apps/platform_apps/media_galleries_permission.cc [rename] https://crrev.com/9330393e8efc94d275e8c1ffccd5019147fd6658/chrome/common/apps/platform_apps/media_galleries_permission.h [rename] https://crrev.com/9330393e8efc94d275e8c1ffccd5019147fd6658/chrome/common/apps/platform_apps/media_galleries_permission_data.cc [rename] https://crrev.com/9330393e8efc94d275e8c1ffccd5019147fd6658/chrome/common/apps/platform_apps/media_galleries_permission_data.h [rename] https://crrev.com/9330393e8efc94d275e8c1ffccd5019147fd6658/chrome/common/apps/platform_apps/media_galleries_permission_unittest.cc [modify] https://crrev.com/9330393e8efc94d275e8c1ffccd5019147fd6658/chrome/test/BUILD.gn [modify] https://crrev.com/9330393e8efc94d275e8c1ffccd5019147fd6658/chromecast/common/extensions_api/cast_api_permissions.cc [modify] https://crrev.com/9330393e8efc94d275e8c1ffccd5019147fd6658/extensions/common/BUILD.gn [modify] https://crrev.com/9330393e8efc94d275e8c1ffccd5019147fd6658/extensions/common/extension_messages.h [modify] https://crrev.com/9330393e8efc94d275e8c1ffccd5019147fd6658/ipc/ipc_message_start.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4feb76e71594ff8ae28e6e8615051697f484c031 commit 4feb76e71594ff8ae28e6e8615051697f484c031 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Wed Oct 10 20:43:20 2018 [Extensions + Apps] Move the syncFileSystem API to platform_apps Move the syncFileSystem API out of extensions code and into apps code. This includes: - The API schema (sync_file_system.idl) - The API features (from _*_features.json files) - The API permission (from c/b/e/permissions/chrome_api_permissions.cc) - The API implementation and tests (from c/b/e/api/sync_file_system) Additionally, this updates the namespace for the API implementation to be ::chrome_apps::api, for uniformity with the other apps API namespaces. Bug: 877240 Change-Id: I47e1f68405ce8843d50d17a0f6b469e7105c1a55 Reviewed-on: https://chromium-review.googlesource.com/c/1258510 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#598487} [modify] https://crrev.com/4feb76e71594ff8ae28e6e8615051697f484c031/chrome/browser/apps/platform_apps/api/BUILD.gn [rename] https://crrev.com/4feb76e71594ff8ae28e6e8615051697f484c031/chrome/browser/apps/platform_apps/api/sync_file_system/OWNERS [add] https://crrev.com/4feb76e71594ff8ae28e6e8615051697f484c031/chrome/browser/apps/platform_apps/api/sync_file_system/extension_sync_event_observer.cc [rename] https://crrev.com/4feb76e71594ff8ae28e6e8615051697f484c031/chrome/browser/apps/platform_apps/api/sync_file_system/extension_sync_event_observer.h [rename] https://crrev.com/4feb76e71594ff8ae28e6e8615051697f484c031/chrome/browser/apps/platform_apps/api/sync_file_system/sync_file_system_api.cc [rename] https://crrev.com/4feb76e71594ff8ae28e6e8615051697f484c031/chrome/browser/apps/platform_apps/api/sync_file_system/sync_file_system_api.h [add] https://crrev.com/4feb76e71594ff8ae28e6e8615051697f484c031/chrome/browser/apps/platform_apps/api/sync_file_system/sync_file_system_api_helpers.cc [add] https://crrev.com/4feb76e71594ff8ae28e6e8615051697f484c031/chrome/browser/apps/platform_apps/api/sync_file_system/sync_file_system_api_helpers.h [rename] https://crrev.com/4feb76e71594ff8ae28e6e8615051697f484c031/chrome/browser/apps/platform_apps/api/sync_file_system/sync_file_system_apitest.cc [rename] https://crrev.com/4feb76e71594ff8ae28e6e8615051697f484c031/chrome/browser/apps/platform_apps/api/sync_file_system/sync_file_system_browsertest.cc [modify] https://crrev.com/4feb76e71594ff8ae28e6e8615051697f484c031/chrome/browser/extensions/BUILD.gn [delete] https://crrev.com/7fea1f194e9d0d422ec617cda4dc0b3c80a08f36/chrome/browser/extensions/api/sync_file_system/extension_sync_event_observer.cc [delete] https://crrev.com/7fea1f194e9d0d422ec617cda4dc0b3c80a08f36/chrome/browser/extensions/api/sync_file_system/sync_file_system_api_helpers.cc [delete] https://crrev.com/7fea1f194e9d0d422ec617cda4dc0b3c80a08f36/chrome/browser/extensions/api/sync_file_system/sync_file_system_api_helpers.h [modify] https://crrev.com/4feb76e71594ff8ae28e6e8615051697f484c031/chrome/browser/sync_file_system/sync_file_system_service.cc [modify] https://crrev.com/4feb76e71594ff8ae28e6e8615051697f484c031/chrome/browser/ui/webui/sync_file_system_internals/file_metadata_handler.cc [modify] https://crrev.com/4feb76e71594ff8ae28e6e8615051697f484c031/chrome/browser/ui/webui/sync_file_system_internals/sync_file_system_internals_handler.cc [modify] https://crrev.com/4feb76e71594ff8ae28e6e8615051697f484c031/chrome/common/apps/platform_apps/api/_api_features.json [modify] https://crrev.com/4feb76e71594ff8ae28e6e8615051697f484c031/chrome/common/apps/platform_apps/api/_permission_features.json [modify] https://crrev.com/4feb76e71594ff8ae28e6e8615051697f484c031/chrome/common/apps/platform_apps/api/api_sources.gni [rename] https://crrev.com/4feb76e71594ff8ae28e6e8615051697f484c031/chrome/common/apps/platform_apps/api/sync_file_system.idl [modify] https://crrev.com/4feb76e71594ff8ae28e6e8615051697f484c031/chrome/common/apps/platform_apps/chrome_apps_api_permissions.cc [modify] https://crrev.com/4feb76e71594ff8ae28e6e8615051697f484c031/chrome/common/extensions/api/_api_features.json [modify] https://crrev.com/4feb76e71594ff8ae28e6e8615051697f484c031/chrome/common/extensions/api/_permission_features.json [modify] https://crrev.com/4feb76e71594ff8ae28e6e8615051697f484c031/chrome/common/extensions/api/api_sources.gni [modify] https://crrev.com/4feb76e71594ff8ae28e6e8615051697f484c031/chrome/common/extensions/permissions/chrome_api_permissions.cc [modify] https://crrev.com/4feb76e71594ff8ae28e6e8615051697f484c031/chrome/test/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5f6bf6cff521bf0500a264a79976cdc7ce56e5d2 commit 5f6bf6cff521bf0500a264a79976cdc7ce56e5d2 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Thu Oct 25 14:55:50 2018 [Extensions + Apps] Move the webstoreWidgetPrivate API to platform_apps Move the webstoreWidgetPrivate API out of extensions code and into apps code. This includes: - The API schema (webstore_widget_private.idl) - The API features (from _*_features.json files) - The API permission (from c/b/e/permissions/chrome_api_permissions.cc) - The API implementation and tests (from c/b/e/api/webstore_widget_private) Additionally, this updates the namespace for the API implementation to be ::chrome_apps::api, for uniformity with the other apps API namespaces. Bug: 877240 Change-Id: I238d14223e5d809484581676ce3cd6d9a66c05c1 Reviewed-on: https://chromium-review.googlesource.com/c/1265084 Reviewed-by: Toni Baržić <tbarzic@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#602707} [modify] https://crrev.com/5f6bf6cff521bf0500a264a79976cdc7ce56e5d2/chrome/browser/apps/platform_apps/api/BUILD.gn [rename] https://crrev.com/5f6bf6cff521bf0500a264a79976cdc7ce56e5d2/chrome/browser/apps/platform_apps/api/webstore_widget_private/OWNERS [rename] https://crrev.com/5f6bf6cff521bf0500a264a79976cdc7ce56e5d2/chrome/browser/apps/platform_apps/api/webstore_widget_private/app_installer.cc [rename] https://crrev.com/5f6bf6cff521bf0500a264a79976cdc7ce56e5d2/chrome/browser/apps/platform_apps/api/webstore_widget_private/app_installer.h [rename] https://crrev.com/5f6bf6cff521bf0500a264a79976cdc7ce56e5d2/chrome/browser/apps/platform_apps/api/webstore_widget_private/webstore_widget_private_api.cc [rename] https://crrev.com/5f6bf6cff521bf0500a264a79976cdc7ce56e5d2/chrome/browser/apps/platform_apps/api/webstore_widget_private/webstore_widget_private_api.h [modify] https://crrev.com/5f6bf6cff521bf0500a264a79976cdc7ce56e5d2/chrome/browser/extensions/BUILD.gn [modify] https://crrev.com/5f6bf6cff521bf0500a264a79976cdc7ce56e5d2/chrome/common/apps/platform_apps/api/_api_features.json [modify] https://crrev.com/5f6bf6cff521bf0500a264a79976cdc7ce56e5d2/chrome/common/apps/platform_apps/api/_permission_features.json [modify] https://crrev.com/5f6bf6cff521bf0500a264a79976cdc7ce56e5d2/chrome/common/apps/platform_apps/api/api_sources.gni [rename] https://crrev.com/5f6bf6cff521bf0500a264a79976cdc7ce56e5d2/chrome/common/apps/platform_apps/api/webstore_widget_private.idl [modify] https://crrev.com/5f6bf6cff521bf0500a264a79976cdc7ce56e5d2/chrome/common/apps/platform_apps/chrome_apps_api_permissions.cc [modify] https://crrev.com/5f6bf6cff521bf0500a264a79976cdc7ce56e5d2/chrome/common/extensions/api/_api_features.json [modify] https://crrev.com/5f6bf6cff521bf0500a264a79976cdc7ce56e5d2/chrome/common/extensions/api/_permission_features.json [modify] https://crrev.com/5f6bf6cff521bf0500a264a79976cdc7ce56e5d2/chrome/common/extensions/api/api_sources.gni [modify] https://crrev.com/5f6bf6cff521bf0500a264a79976cdc7ce56e5d2/chrome/common/extensions/permissions/chrome_api_permissions.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a0ecab8bf1e46d272d61cadd9aa3def0f4fa7705 commit a0ecab8bf1e46d272d61cadd9aa3def0f4fa7705 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Thu Dec 13 00:59:53 2018 [Extensions + Apps] Move the pointerLock permission to platform_apps Move the pointerLock permission out of extensions code and into apps code. This is only a permission, and not a full API, and thus only includes: - The API features (from _*_features.json files) - The API permission (from c/b/e/permissions/chrome_api_permissions.cc) Bug: 877240 Change-Id: Ifb861abcd07eab07edd994acff04e75a26e40b20 Reviewed-on: https://chromium-review.googlesource.com/c/1374579 Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#616131} [modify] https://crrev.com/a0ecab8bf1e46d272d61cadd9aa3def0f4fa7705/chrome/common/apps/platform_apps/api/_permission_features.json [modify] https://crrev.com/a0ecab8bf1e46d272d61cadd9aa3def0f4fa7705/chrome/common/apps/platform_apps/chrome_apps_api_permissions.cc [modify] https://crrev.com/a0ecab8bf1e46d272d61cadd9aa3def0f4fa7705/chrome/common/extensions/api/_permission_features.json [modify] https://crrev.com/a0ecab8bf1e46d272d61cadd9aa3def0f4fa7705/chrome/common/extensions/permissions/chrome_api_permissions.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a8408f18a8014efc7ac96abc2c864f9edeb55bef commit a8408f18a8014efc7ac96abc2c864f9edeb55bef Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Fri Dec 14 14:34:22 2018 [Extensions + Apps] Move the arcAppsPrivate API to platform_apps Move the arcAppsPrivate API out of extensions code and into apps code. This includes: - The API schema (arc_apps_private.idl) - The API features (from _*_features.json files) - The API permission (from c/b/e/permissions/chrome_api_permissions.cc) - The API implementation and tests (from c/b/chromeos/extensions/) Additionally, this updates the namespace for the API implementation to be ::chrome_apps::api, for uniformity with the other apps API namespaces. Bug: 877240 Change-Id: Ie0ec379984eea3e02222d5877f34e916a225d4bd Reviewed-on: https://chromium-review.googlesource.com/c/1298227 Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#616667} [modify] https://crrev.com/a8408f18a8014efc7ac96abc2c864f9edeb55bef/chrome/browser/apps/platform_apps/api/BUILD.gn [rename] https://crrev.com/a8408f18a8014efc7ac96abc2c864f9edeb55bef/chrome/browser/apps/platform_apps/api/arc_apps_private/arc_apps_private_api.cc [rename] https://crrev.com/a8408f18a8014efc7ac96abc2c864f9edeb55bef/chrome/browser/apps/platform_apps/api/arc_apps_private/arc_apps_private_api.h [rename] https://crrev.com/a8408f18a8014efc7ac96abc2c864f9edeb55bef/chrome/browser/apps/platform_apps/api/arc_apps_private/arc_apps_private_apitest.cc [add] https://crrev.com/a8408f18a8014efc7ac96abc2c864f9edeb55bef/chrome/browser/apps/platform_apps/api/browser_context_keyed_service_factories.cc [add] https://crrev.com/a8408f18a8014efc7ac96abc2c864f9edeb55bef/chrome/browser/apps/platform_apps/api/browser_context_keyed_service_factories.h [modify] https://crrev.com/a8408f18a8014efc7ac96abc2c864f9edeb55bef/chrome/browser/chromeos/BUILD.gn [modify] https://crrev.com/a8408f18a8014efc7ac96abc2c864f9edeb55bef/chrome/browser/extensions/browser_context_keyed_service_factories.cc [modify] https://crrev.com/a8408f18a8014efc7ac96abc2c864f9edeb55bef/chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc [modify] https://crrev.com/a8408f18a8014efc7ac96abc2c864f9edeb55bef/chrome/common/apps/platform_apps/api/_api_features.json [modify] https://crrev.com/a8408f18a8014efc7ac96abc2c864f9edeb55bef/chrome/common/apps/platform_apps/api/_permission_features.json [modify] https://crrev.com/a8408f18a8014efc7ac96abc2c864f9edeb55bef/chrome/common/apps/platform_apps/api/api_sources.gni [rename] https://crrev.com/a8408f18a8014efc7ac96abc2c864f9edeb55bef/chrome/common/apps/platform_apps/api/arc_apps_private.idl [modify] https://crrev.com/a8408f18a8014efc7ac96abc2c864f9edeb55bef/chrome/common/apps/platform_apps/chrome_apps_api_permissions.cc [modify] https://crrev.com/a8408f18a8014efc7ac96abc2c864f9edeb55bef/chrome/common/extensions/api/_api_features.json [modify] https://crrev.com/a8408f18a8014efc7ac96abc2c864f9edeb55bef/chrome/common/extensions/api/_permission_features.json [modify] https://crrev.com/a8408f18a8014efc7ac96abc2c864f9edeb55bef/chrome/common/extensions/api/api_sources.gni [modify] https://crrev.com/a8408f18a8014efc7ac96abc2c864f9edeb55bef/chrome/common/extensions/permissions/chrome_api_permissions.cc [modify] https://crrev.com/a8408f18a8014efc7ac96abc2c864f9edeb55bef/chrome/test/BUILD.gn
Comment 1 by rdevlin....@chromium.org
, Aug 23