New issue
Advanced search Search tips

Issue 877235 link

Starred by 1 user
Status: Untriaged
Owner: ----
Cc:
p...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug

Blocking:
issue 871418



Sign in to add a comment

Red compile on ToTWin(dll)

Project Member Reported by thakis@chromium.org, Aug 23 
Started here:

https://ci.chromium.org/buildbot/chromium.clang/ToTWin%28dll%29/1156

[5615/63128] LINK(DLL) video_effects.dll video_effects.dll.lib video_effects.dll.pdb
FAILED: video_effects.dll video_effects.dll.lib video_effects.dll.pdb 
ninja -t msvc -e environment.x86 -- ../../third_party/llvm-build/Release+Asserts/bin/lld-link.exe /nologo /IMPLIB:./video_effects.dll.lib /DLL /OUT:./video_effects.dll /PDB:./video_effects.dll.pdb @./video_effects.dll.rsp
lld-link: error: undefined symbol: ?id@?$ctype@D@std@@2V0locale@2@A

clang regression range: 340526:340556. `svn log -r 340527:340556  https://nico@llvm.org/svn/llvm-project`:


The only thing that looks like a possible culprit is

------------------------------------------------------------------------
r340555 | pcc | 2018-08-23 10:44:42 -0700 (Thu, 23 Aug 2018) | 3 lines

COFF: Implement safe ICF on rodata using address-significance tables.



Or it could be a chrome-side change, we don't have release component builders elsewhere.

Comment 1 by thakis@chromium.org, Aug 23 

$ demumble '?id@?$ctype@D@std@@2V0locale@2@A'
public: static class std::locale::id std::ctype<char>::id

Might be rodata at least...

Comment 2 by p...@chromium.org, Aug 23 

If it's one of my changes it's more likely r340552, I received another report of breakage due to undefined symbols caused by that change in https://reviews.llvm.org/D51049

I'll revert and investigate.

Comment 3 by p...@chromium.org, Aug 23 

r340579

Comment 4 by p...@chromium.org, Aug 24 

Next cycle is still running, but video_effects.dll linked successfully after the revert.

https://reviews.llvm.org/D51199 should fix the underlying problem.
►

Sign in to add a comment