New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 877221 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 30
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Turn on show build results by default for diagnose_bloat.py

Project Member Reported by wnwen@chromium.org, Aug 23

Issue description

Release builds are relatively quiet now, this is the only log left:

ninja: Entering directory `out/Release'                             
[1/1] Regenerating ninja files                                                                             
[2767/35942] CC obj/third_party/zlib/zlib_arm_crc32/crc32_simd.o                             
'+soft-float-abi' is not a recognized feature for this target (ignoring feature)            
'+soft-float-abi' is not a recognized feature for this target (ignoring feature)       
[35934/35942] ACTION //clank/java:monochrome_apk__proguard(//build/toolchain/android:android_clang_arm)
Configuration file '../../base/android/proguard/chromium_apk.flags': (line: 33)
Configuration:                                                                                             
        -keep class * implements org.chromium.base.test.params.ParameterProvider             
                                                                                            
        # Allows Proguard freedom in removing these log related calls. We ask for debug
        # and verbose logs to be stripped out in base.Log, so we are just ensuring we
        # get rid of all other debug/verbose logs.
Configuration file '../../clank/third_party/android/javalibs/google-play-services-first-party/base_1p/proguard.txt': (line: 2)
Configuration:
        -keepclassmembers class com.google.android.gms.common.api.internal.BasePendingResult {             
>         com.google.android.gms.common.api.internal.BasePendingResult$ReleasableResultGuardian mResultGuardian;
        }                                                                                   
Configuration file '../../clank/third_party/android/javalibs/google-play-services-first-party/basement_1p/proguard.txt': (line: 5)
Configuration:                                                                               
        -keepclassmembers public class com.google.android.gms.common.internal.safeparcel.SafeParcelable {
            public static final *** NULL;                                                                      
        }                                                                                        
                                                                                                           
        # Needed for Parcelable/SafeParcelable classes & their creators to not get renamed, as they are
        # found via reflection.                                                                                
Configuration file '../../third_party/gvr-android-sdk/src/proguard-gvr.txt': (line: 16)          
Configuration:                                                                                  
        -keep class com.google.vr.cardboard.UsedByNative                                        
      Maybe you meant the fully qualified name 'com.google.android.libraries.hats20.proguard.UsedByNative'?    
      Maybe you meant the fully qualified name 'com.google.ar.core.annotations.UsedByNative'?    
      Maybe you meant the fully qualified name 'com.google.vr.dynamite.client.UsedByNative'?    
Configuration file '../../third_party/gvr-android-sdk/src/proguard-gvr.txt': (line: 17)         
Configuration:                                                                                                 
        -keep @com.google.vr.cardboard.UsedByNative class *                                      
      Maybe you meant the fully qualified name 'com.google.android.libraries.hats20.proguard.UsedByNative'?
      Maybe you meant the fully qualified name 'com.google.ar.core.annotations.UsedByNative'?   
      Maybe you meant the fully qualified name 'com.google.vr.dynamite.client.UsedByNative'?
Configuration file '../../third_party/gvr-android-sdk/src/proguard-gvr.txt': (line: 18)
Configuration:
        -keepclassmembers class * {
>           @com.google.vr.cardboard.UsedByNative *;
        }
      Maybe you meant the fully qualified name 'com.google.android.libraries.hats20.proguard.UsedByNative'?
      Maybe you meant the fully qualified name 'com.google.ar.core.annotations.UsedByNative'?
      Maybe you meant the fully qualified name 'com.google.vr.dynamite.client.UsedByNative'?
Configuration file '../../third_party/gvr-android-sdk/src/proguard-gvr.txt': (line: 18)
Configuration:
        -keepclassmembers class * {
>           @com.google.vr.cardboard.UsedByNative *;
        }
      Maybe you meant the fully qualified name 'com.google.android.libraries.hats20.proguard.UsedByNative'?
      Maybe you meant the fully qualified name 'com.google.ar.core.annotations.UsedByNative'?
      Maybe you meant the fully qualified name 'com.google.vr.dynamite.client.UsedByNative'?
Configuration file '../../third_party/gvr-android-sdk/src/proguard-gvr.txt': (line: 22)
Configuration:
        -keep class com.google.vr.cardboard.annotations.UsedByNative
      Maybe you meant the fully qualified name 'com.google.android.libraries.hats20.proguard.UsedByNative'?
      Maybe you meant the fully qualified name 'com.google.ar.core.annotations.UsedByNative'?
      Maybe you meant the fully qualified name 'com.google.vr.dynamite.client.UsedByNative'?
Configuration file '../../third_party/gvr-android-sdk/src/proguard-gvr.txt': (line: 23)
Configuration:
        -keep @com.google.vr.cardboard.annotations.UsedByNative class *
      Maybe you meant the fully qualified name 'com.google.android.libraries.hats20.proguard.UsedByNative'?
      Maybe you meant the fully qualified name 'com.google.ar.core.annotations.UsedByNative'?
      Maybe you meant the fully qualified name 'com.google.vr.dynamite.client.UsedByNative'?
Configuration file '../../third_party/gvr-android-sdk/src/proguard-gvr.txt': (line: 24)
Configuration:
        -keepclassmembers class * {
>           @com.google.vr.cardboard.annotations.UsedByNative *;
        }
      Maybe you meant the fully qualified name 'com.google.android.libraries.hats20.proguard.UsedByNative'?
      Maybe you meant the fully qualified name 'com.google.ar.core.annotations.UsedByNative'?
      Maybe you meant the fully qualified name 'com.google.vr.dynamite.client.UsedByNative'?
      Maybe you meant the fully qualified name 'com.google.android.libraries.hats20.proguard.UsedByNative'?
      Maybe you meant the fully qualified name 'com.google.ar.core.annotations.UsedByNative'?
      Maybe you meant the fully qualified name 'com.google.vr.dynamite.client.UsedByNative'?
      Maybe you meant the fully qualified name 'com.google.android.libraries.hats20.proguard.UsedByReflection'?
      Maybe you meant the fully qualified name 'com.google.ar.core.annotations.UsedByReflection'?
      Maybe you meant the fully qualified name 'com.google.vr.dynamite.client.UsedByReflection'?
      Maybe you meant the fully qualified name 'org.chromium.base.annotations.UsedByReflection'?
      Maybe you meant the fully qualified name 'com.google.android.libraries.hats20.proguard.UsedByReflection'?
      Maybe you meant the fully qualified name 'com.google.ar.core.annotations.UsedByReflection'?
      Maybe you meant the fully qualified name 'com.google.vr.dynamite.client.UsedByReflection'?
      Maybe you meant the fully qualified name 'org.chromium.base.annotations.UsedByReflection'?
      Maybe you meant the fully qualified name 'com.google.android.libraries.hats20.proguard.UsedByReflection'?
      Maybe you meant the fully qualified name 'com.google.ar.core.annotations.UsedByReflection'?
      Maybe you meant the fully qualified name 'com.google.vr.dynamite.client.UsedByReflection'?
      Maybe you meant the fully qualified name 'org.chromium.base.annotations.UsedByReflection'?
      Maybe you meant the fully qualified name 'com.google.android.libraries.hats20.proguard.UsedByReflection'?
      Maybe you meant the fully qualified name 'com.google.ar.core.annotations.UsedByReflection'?
      Maybe you meant the fully qualified name 'com.google.vr.dynamite.client.UsedByReflection'?
      Maybe you meant the fully qualified name 'org.chromium.base.annotations.UsedByReflection'?
[35942/35942] STAMP obj/clank/java/monochrome_apk.stamp

I would like to also filter out this output eventually so that release builds, like debug builds, have no extraneous output.
 
Owner: estevenson@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b21a529800bab00bdd5f97c037da33a51a0e24b8

commit b21a529800bab00bdd5f97c037da33a51a0e24b8
Author: Eric Stevenson <estevenson@chromium.org>
Date: Wed Aug 29 18:23:09 2018

diagnose_bloat.py: Print build output by default.

Now that our release builds are clean we can always print the output
so that it's easier to identify the cause of build failures.

Bug:  877221 
Change-Id: I842314b924b05e79fea55352c8517d8c944c7c28
Reviewed-on: https://chromium-review.googlesource.com/1194796
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587200}
[modify] https://crrev.com/b21a529800bab00bdd5f97c037da33a51a0e24b8/tools/binary_size/diagnose_bloat.py

Status: Fixed (was: Assigned)

Sign in to add a comment