[📍] Perf builders no longer run "isolate tests" or "pinpoint isolate upload" |
|||
Issue descriptionThis build has the two steps: https://ci.chromium.org/buildbot/chromium.perf/Linux%20Builder%20Perf/37889 And the following build does not: https://ci.chromium.org/buildbot/chromium.perf/Linux%20Builder%20Perf/37890 Pinpoint needs the isolate information in order to look up the isolates from the builder and git hash. Without this step, Pinpoint jobs will fail with the error "Buildbucket says the build completed successfully, but Pinpoint can't find the isolate hash."
,
Aug 23
John: wonder whehther this is related to LUCI work recently
,
Aug 23
I see that it's missing the "trigger" step recently. Is the linux-perf being triggered by the LUCI builder? Then it would make sense that there's no "isolate tests", since there's no tester and therefore no tests to isolate.
,
Aug 23
#3: I haven't changed linux-perf trigger. But now I notice that linux-perf doesn't specify its parent (been this way for a long time) https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium_tests/chromium_perf.py?rcl=88ed8fae6094324a1ca08997d53422b561dc7495&l=253
,
Aug 23
Ah, looking more closely at the code, there's some hidden "magic" logic. The first builder to be added to the file adds itself to the "builders" dict. If the parent is not specified, it's implied from the "builders" dict. So adding a linux builder above the existing linux builder caused the tester to be reparented.
,
Aug 23
So if we remove that magic code and make the parent explicit, that will fix the issue here.
,
Aug 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/b5036094e527f5a8c6a9fa80b5778b8281218e32 commit b5036094e527f5a8c6a9fa80b5778b8281218e32 Author: Dave Tu <dtu@chromium.org> Date: Thu Aug 23 22:50:35 2018 [perf] Make parent_buildername explicit for all perf bots. Previously, the parent builders were implied by what builders were defined. That assumption made sense when there was only one builder for each config, but with the LUCI migration, we may now have multiple builders with the same config. Bug: 877219 Change-Id: I549a011a3a474e5640186f5e6b6013dfde8788d2 Reviewed-on: https://chromium-review.googlesource.com/1187572 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> [modify] https://crrev.com/b5036094e527f5a8c6a9fa80b5778b8281218e32/scripts/slave/recipe_modules/chromium_tests/chromium_perf.py
,
Aug 28
|
|||
►
Sign in to add a comment |
|||
Comment 1 by dtu@chromium.org
, Aug 23