New issue
Advanced search Search tips

Issue 877210 link

Starred by 1 user
Status: Fixed
Owner:
chaopeng@chromium.org
Closed: Sep 4
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"fast/frames/crash-frameset-CSS-content-property.html" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Aug 23 
"fast/frames/crash-frameset-CSS-content-property.html" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 4 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyPwsSBUZsYWtlIjRmYXN0L2ZyYW1lcy9jcmFzaC1mcmFtZXNldC1DU1MtY29udGVudC1wcm9wZXJ0eS5odG1sDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7f775d338e8eb3690412d443208b43025cd18f2

commit f7f775d338e8eb3690412d443208b43025cd18f2
Author: Sahel Sharify <sahel@chromium.org>
Date: Thu Aug 23 20:58:45 2018

Revert "Fix fast/frames/crash-frameset-CSS-content-property.html"

This reverts commit 2e954351680196ce8508ce8bb7b47af62c7e77e3.

Reason for revert: "fast/frames/crash-frameset-CSS-content-property.html" is flaky

example failure:
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/171496

Original change's description:
> Fix fast/frames/crash-frameset-CSS-content-property.html
> 
> This test switches a <frameset> to a <body>. For framesets, LayoutView::CalculateScrollbarModes
> forces the user scrollable bit to be false. So, we need to make sure to call
> LayoutView::SetNeedsPaintPropertyUpdate when the LayoutView's child changes to/from a frameset.
> 
> 
> Bug:  875287 
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
> 
> Change-Id: I5ae0a7673ae8e325242465633749ffcd76ca705f
> Reviewed-on: https://chromium-review.googlesource.com/1186181
> Reviewed-by: Philip Rogers <pdr@chromium.org>
> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#585493}

TBR=pdr@chromium.org,chaopeng@chromium.org

Change-Id: Ibbfd46388eedd04af20242e4c87413880b9d9718
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  875287 ,  877210 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1187283
Reviewed-by: Sahel Sharify <sahel@chromium.org>
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585612}
[modify] https://crrev.com/f7f775d338e8eb3690412d443208b43025cd18f2/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/f7f775d338e8eb3690412d443208b43025cd18f2/third_party/blink/renderer/core/layout/layout_frame_set.cc
[modify] https://crrev.com/f7f775d338e8eb3690412d443208b43025cd18f2/third_party/blink/renderer/core/layout/layout_frame_set.h

Comment 2 by sahel@chromium.org, Aug 23

Owner: chaopeng@chromium.org
Status: Assigned (was: Untriaged)

Comment 3 by sahel@chromium.org, Aug 23

Labels: -Sheriff-Chromium

Comment 4 by chaopeng@chromium.org, Sep 4

Status: Fixed (was: Assigned)
►

Sign in to add a comment