Reassigning to Justin.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e9edd108371d008b35f61ee7cac0851b53ef769

commit 8e9edd108371d008b35f61ee7cac0851b53ef769
Author: Justin Cohen <justincohen@google.com>
Date: Fri Aug 24 18:57:08 2018

[ios] Correct autoresizingMasks in launch screen incognito blocker.

Bug:  877195 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I6b94acbe327886c90b640b149099db62c17c7719
Reviewed-on: https://chromium-review.googlesource.com/1188609
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585929}
[modify] https://crrev.com/8e9edd108371d008b35f61ee7cac0851b53ef769/ios/chrome/app/application_delegate/app_state.mm

This bug requires manual review: Less than 7 days to go before AppStore submit on M69
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Please explain why this needs to make M69 and how confident you are in the fix.

iPad incognito ui-refresh users who rotate their devices after backgrounding will see a portion of the masked web page in the OS app switcher.

It's an expectation that Incognito content is private to the user. Chrome makes an effort to mask the content from task switcher. I've tried with a few web pages (cnn.com, wikipedia), it mostly shows part of a blank page in the task switcher preview. It would be good to fix since getting privacy-related bugs fixed instills trust in the users.

Looking at the 2-liner fix (comment 6), it is assigning scalar values (mask bits) to a field in ObjC objects (UIView). This cannot do much damage (can't crash) even if the views turned out to be nil. Worst it can do is nothing.

Verified on chrome canary version 70.0.3534.0 on iPad 2018 with iOS 11.4.1, following steps mentioned in comment #0.  Incognito content is completely masked.  Looks good.

Thank you, vbarigela. Justin please merge today.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/003e88df8d078d219a763ca5fa1e4afcb18f0fd4

commit 003e88df8d078d219a763ca5fa1e4afcb18f0fd4
Author: Justin Cohen <justincohen@google.com>
Date: Mon Aug 27 14:09:56 2018

[ios] Correct autoresizingMasks in launch screen incognito blocker.

Bug:  877195 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I6b94acbe327886c90b640b149099db62c17c7719
Reviewed-on: https://chromium-review.googlesource.com/1188609
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#585929}(cherry picked from commit 8e9edd108371d008b35f61ee7cac0851b53ef769)
Reviewed-on: https://chromium-review.googlesource.com/1190402
Cr-Commit-Position: refs/branch-heads/3497@{#811}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/003e88df8d078d219a763ca5fa1e4afcb18f0fd4/ios/chrome/app/application_delegate/app_state.mm

Verified on chrome beta version 69.0.3497.70 on iPad 2018 with iOS 11.4.1 and iPad Air with iOS 12 beta 10, following steps mentioned in comment #0.  Incognito content is completely masked.  Looks good

Verified on iPad Pro 12'9 iOS 11.4.1 on 70.0.3535.0 Canary.
Incognito content is completely masked. Chrome Splash screen is seen.