New issue
Advanced search Search tips

Issue 877173 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 28
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 874868

Blocking:
issue 874222



Sign in to add a comment

add cache_storage histograms measuring times when ignoreSearch is enabled vs disabled

Project Member Reported by wanderview@chromium.org, Aug 23

Issue description

Currently `ignoreSearch:true` triggers linear disk scanning in cache_storage.  This creates a heavy skew on various timing histograms where some operations will have ignoreSearch and some won't.  Let create a separate set of histograms so we can measure ignoreSearch-enabled ops vs those where ignoreSearch is disabled.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf9b6adcbd61f6d2b1484bd31267b3d3a4a10bb0

commit cf9b6adcbd61f6d2b1484bd31267b3d3a4a10bb0
Author: Ben Kelly <wanderview@chromium.org>
Date: Mon Aug 27 22:47:34 2018

Record cache_storage histograms based on ignoreSearch option.

Currently cache_storage has very different performance characteristics
depending on if the ignoreSearch option is set or not.  Until that
problem is fixed (https://crbug.com/682677) we need to track timing
metrics separately in order to have a better understanding of
cache_storage's behavior.

Bug:  877173 
Change-Id: Ifb559571358efe216084de0c7c22557032a32459
Reviewed-on: https://chromium-review.googlesource.com/1188614
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586462}
[modify] https://crrev.com/cf9b6adcbd61f6d2b1484bd31267b3d3a4a10bb0/third_party/blink/renderer/modules/cache_storage/cache.cc
[modify] https://crrev.com/cf9b6adcbd61f6d2b1484bd31267b3d3a4a10bb0/third_party/blink/renderer/modules/cache_storage/cache_storage.cc
[modify] https://crrev.com/cf9b6adcbd61f6d2b1484bd31267b3d3a4a10bb0/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)

Sign in to add a comment