Add Connected Devices to settings contents (a.k.a. settings-menu) |
|||||||
Issue descriptionThe element is settings-menu (seen here in the non-ChromeOS version: https://screenshot.googleplex.com/Hm3OmjCsjcG) and sections are just hard-coded into the element.
,
Aug 23
,
Sep 7
An update on this: I've realized that there is a 'Connected Devices' item in the settings-menu that links to our page. Unfortunately it's left over from an earlier design so it has a few problems (listed in decreasing importance): 1) It is in the wrong place (it's in the advanced section of the settings-menu) 2) It does not hide when we hide the Connected Devices section 3) It has an old SVG The only one of these issues that is not trivial to fix is (2) because the logic that determines whether to show the section is a little complex and is not located near settings-menu in the DOM tree.
,
Sep 7
,
Sep 7
,
Sep 19
We no longer need to handle the case of the Connected Devices section being hidden because we will only hide it if the flag is off in which case it will automatically be removed from the settings-menu.
,
Sep 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fd55572ab1ad3c7932a9db39dbc4fb86416c3186 commit fd55572ab1ad3c7932a9db39dbc4fb86416c3186 Author: Jordy Greenblatt <jordynass@chromium.org> Date: Thu Sep 20 01:05:47 2018 [CrOS MultiDevice] Move settings menu item to match page's location. The existing menu item was a relic of an old design and was in the wrong place and had a different SVG from the 'Connected Devices' Settings UI page. Bug: 877166 Change-Id: Id71107ca97965965e213d12a94d1184424259fe6 Reviewed-on: https://chromium-review.googlesource.com/1235275 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#592643} [modify] https://crrev.com/fd55572ab1ad3c7932a9db39dbc4fb86416c3186/chrome/browser/resources/settings/settings_menu/settings_menu.html
,
Sep 20
,
Sep 21
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by jordynass@chromium.org
, Aug 23