New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 877166 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: ----


Participants' hotlists:
Better-Together-Launch-Blockers


Sign in to add a comment

Add Connected Devices to settings contents (a.k.a. settings-menu)

Project Member Reported by jordynass@chromium.org, Aug 23

Issue description

The element is settings-menu (seen here in the non-ChromeOS version: https://screenshot.googleplex.com/Hm3OmjCsjcG) and sections are just hard-coded into the element.
 
Description: Show this description
Status: Available (was: Unconfirmed)
Labels: -Restrict-View-Google
Summary: Add Connected Devices to settings contents (a.k.a. settings-menu) (was: Add Connected Devices to settings contents (a.k.a. menu))
An update on this: I've realized that there is a 'Connected Devices' item in the settings-menu that links to our page. Unfortunately it's left over from an earlier design so it has a few problems (listed in decreasing importance):

1) It is in the wrong place (it's in the advanced section of the settings-menu)
2) It does not hide when we hide the Connected Devices section
3) It has an old SVG

The only one of these issues that is not trivial to fix is (2) because the logic that determines whether to show the section is a little complex and is not located near settings-menu in the DOM tree.
Owner: jordynass@chromium.org
Status: Assigned (was: Available)
Labels: -M-70 M-71
We no longer need to handle the case of the Connected Devices section being hidden because we will only hide it if the flag is off in which case it will automatically be removed from the settings-menu.
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd55572ab1ad3c7932a9db39dbc4fb86416c3186

commit fd55572ab1ad3c7932a9db39dbc4fb86416c3186
Author: Jordy Greenblatt <jordynass@chromium.org>
Date: Thu Sep 20 01:05:47 2018

[CrOS MultiDevice] Move settings menu item to match page's location.

The existing menu item was a relic of an old design and was in the
wrong place and had a different SVG from the 'Connected Devices'
Settings UI page.

Bug:  877166 
Change-Id: Id71107ca97965965e213d12a94d1184424259fe6
Reviewed-on: https://chromium-review.googlesource.com/1235275
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592643}
[modify] https://crrev.com/fd55572ab1ad3c7932a9db39dbc4fb86416c3186/chrome/browser/resources/settings/settings_menu/settings_menu.html

Components: -UI>ProximityAuth UI>Multidevice
Status: Fixed (was: Assigned)

Sign in to add a comment