No backdrop in tablet mode when home launcher is enabled |
|||||||||
Issue description
Open a fixed size app in tablet mode ('cut the rope' from web store, check 'Runs Offline').
There is no backdrop for the window.
Should because we disable the backdrop when launcher is visible before. And home launcher is always enabled now in tablet mode.
,
Aug 23
,
Aug 23
The code in question is here: https://cs.chromium.org/chromium/src/ash/wm/workspace/backdrop_controller.cc?rcl=17934eb6a21e73b130064220f8984a4755361ea3&l=130 I was wondering if we could skip this if home launcher is enabled
,
Aug 23
,
Aug 27
,
Aug 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/653e4e189502af4b2e250f6377b8ec137711aeea commit 653e4e189502af4b2e250f6377b8ec137711aeea Author: Weidong Guo <weidongg@chromium.org> Date: Thu Aug 30 17:17:12 2018 Avoid hide backdrop for homecher Bug: 877163 Change-Id: I9f1b221bbbfbfb34d4a796c109ef7595e17bbc40 Reviewed-on: https://chromium-review.googlesource.com/1195928 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#587636} [modify] https://crrev.com/653e4e189502af4b2e250f6377b8ec137711aeea/ash/app_list/app_list_presenter_delegate_unittest.cc [modify] https://crrev.com/653e4e189502af4b2e250f6377b8ec137711aeea/ash/wm/workspace/backdrop_controller.cc
,
Aug 30
,
Aug 30
,
Sep 7
,
Sep 8
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 12
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 17
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by minch@chromium.org
, Aug 23