New issue
Advanced search Search tips

Issue 877161 link

Starred by 2 users
Status: Started
Owner:
no...@chromium.org
Cc:
machenb...@chromium.org
tandrii@chromium.org
jbudorick@chromium.org
no...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Task



Sign in to add a comment

Remove usages of deprecated build properties

Project Member Reported by no...@chromium.org, Aug 23 
The following properties are deprecated in favor of API provided by buildbucket recipe module:
- branch
- issue
- patch_gerrit_url
- patch_git_url
- patch_issue
- patch_project
- patch_project
- patch_ref
- patch_set
- patch_storage
- patchset
- repository
- revision

Update their usage to use buildbucket recipe module.
The motivation to do it now is to avoid dragging this into the implementation of the new ScheduleBuild API, bug 875056.

Comment 1 by no...@chromium.org, Aug 23

Cc: tandrii@chromium.org

Comment 2 by machenb...@chromium.org, Aug 23 

Do you plan to change all recipes to make use of the new api before this deprecation? Or will such changes be delegated to the respective owners?

Comment 3 by no...@chromium.org, Aug 23 

I plan to update all recipes (it blocks my OKRs)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/5d58f4aebf92273a3ee73a54688b171ece780dc9

commit 5d58f4aebf92273a3ee73a54688b171ece780dc9
Author: Nodir Turakulov <nodir@google.com>
Date: Fri Aug 24 00:02:46 2018

[buildbucket] Add ScheduleBuildRequest validation

Also prohibit properties that are superseded by new typed fields,
e.g. gitiles_commit supersedes repository, branch and revision properties.
See crbug.com/877161

Bug: 875056, 877161
Change-Id: I1da3730dd1073eca91d5f585ac667d6d3a2b944f
Reviewed-on: https://chromium-review.googlesource.com/1186063
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Erik Staab <estaab@chromium.org>

[modify] https://crrev.com/5d58f4aebf92273a3ee73a54688b171ece780dc9/appengine/cr-buildbucket/v2/test/validation_test.py
[modify] https://crrev.com/5d58f4aebf92273a3ee73a54688b171ece780dc9/appengine/cr-buildbucket/v2/validation.py
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/recipes-py/+/27ee9b58f15dadaa02370b4f6f1fa61496af554b

commit 27ee9b58f15dadaa02370b4f6f1fa61496af554b
Author: Nodir Turakulov <nodir@google.com>
Date: Thu Aug 30 16:48:14 2018

[buildbucket] Rewrite buildbucket recipe module

Deprecate all existing properties in api.py in favor of a new property
"build" of type buildbucket.v2.Build protobuf message.

Add support for v2 buildbucket property format, which is just Build protobuf
message serialized as JSONPB.

Merge build_input, builder_id and properties tests into new build.py test.

Update test API to v2 format.

Downstream rolls:
build: https://chromium-review.googlesource.com/c/chromium/tools/build/+/1195903
build_limited: https://chrome-internal-review.googlesource.com/c/chrome/tools/build_limited/scripts/slave/+/669003
infra: https://chromium-review.googlesource.com/c/infra/infra/+/1194800

Recipe-Manual-Change: build
Recipe-Manual-Change: build_limited_scripts_slave
Recipe-Nontrivial-Roll: infra
TBR=iannucci@chromium.org
Bug: 877161, 859231
Change-Id: Ib7d0f6ce34aec9ef5a5065419b6f559ef8b9fb1c
Reviewed-on: https://chromium-review.googlesource.com/1188390
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Erik Staab <estaab@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[add] https://crrev.com/27ee9b58f15dadaa02370b4f6f1fa61496af554b/recipe_modules/buildbucket/tests/put.expected/custom buildset.json
[copy] https://crrev.com/27ee9b58f15dadaa02370b4f6f1fa61496af554b/recipe_modules/buildbucket/tests/build.expected/serialized buildbucket property.json
[modify] https://crrev.com/27ee9b58f15dadaa02370b4f6f1fa61496af554b/recipe_modules/buildbucket/test_api.py
[delete] https://crrev.com/ae1b7cd869b3821d84df1333a7abce956073f597/recipe_modules/buildbucket/tests/build_id.py
[modify] https://crrev.com/27ee9b58f15dadaa02370b4f6f1fa61496af554b/recipe_modules/buildbucket/examples/full.expected/basic-try.json
[add] https://crrev.com/27ee9b58f15dadaa02370b4f6f1fa61496af554b/recipe_modules/buildbucket/tests/build.expected/v1 empty buildset.json
[modify] https://crrev.com/27ee9b58f15dadaa02370b4f6f1fa61496af554b/recipe_modules/buildbucket/api.py
[delete] https://crrev.com/ae1b7cd869b3821d84df1333a7abce956073f597/recipe_modules/buildbucket/tests/properties.expected/structured.json
[add] https://crrev.com/27ee9b58f15dadaa02370b4f6f1fa61496af554b/recipe_modules/buildbucket/util.py
[add] https://crrev.com/27ee9b58f15dadaa02370b4f6f1fa61496af554b/recipe_modules/buildbucket/tests/build.expected/v1 luci builder id.json
[delete] https://crrev.com/ae1b7cd869b3821d84df1333a7abce956073f597/recipe_modules/buildbucket/tests/build_input.expected/gitiles commit.json
[delete] https://crrev.com/ae1b7cd869b3821d84df1333a7abce956073f597/recipe_modules/buildbucket/tests/properties.expected/serialized.json
[delete] https://crrev.com/ae1b7cd869b3821d84df1333a7abce956073f597/recipe_modules/buildbucket/tests/build_input.expected/no buildsets.json
[add] https://crrev.com/27ee9b58f15dadaa02370b4f6f1fa61496af554b/recipe_modules/buildbucket/proto/common_pb2.py
[delete] https://crrev.com/ae1b7cd869b3821d84df1333a7abce956073f597/recipe_modules/buildbucket/tests/properties.expected/empty.json
[delete] https://crrev.com/ae1b7cd869b3821d84df1333a7abce956073f597/recipe_modules/buildbucket/tests/build_input.py
[add] https://crrev.com/27ee9b58f15dadaa02370b4f6f1fa61496af554b/recipe_modules/buildbucket/tests/build.expected/v1 unknown buildset format.json
[modify] https://crrev.com/27ee9b58f15dadaa02370b4f6f1fa61496af554b/README.recipes.md
[delete] https://crrev.com/ae1b7cd869b3821d84df1333a7abce956073f597/recipe_modules/buildbucket/tests/build_input.expected/unknown format.json
[modify] https://crrev.com/27ee9b58f15dadaa02370b4f6f1fa61496af554b/recipe_modules/buildbucket/__init__.py
[add] https://crrev.com/27ee9b58f15dadaa02370b4f6f1fa61496af554b/recipe_modules/buildbucket/tests/put.expected/gitiles commit.json
[copy] https://crrev.com/27ee9b58f15dadaa02370b4f6f1fa61496af554b/recipe_modules/buildbucket/tests/build.expected/v1 gitiles commit, invalid.json
[add] https://crrev.com/27ee9b58f15dadaa02370b4f6f1fa61496af554b/recipe_modules/buildbucket/proto/build_pb2.py
[delete] https://crrev.com/ae1b7cd869b3821d84df1333a7abce956073f597/recipe_modules/buildbucket/tests/build_input.expected/gitiles commit, invalid.json
[modify] https://crrev.com/27ee9b58f15dadaa02370b4f6f1fa61496af554b/recipe_modules/buildbucket/tests/put.py
[add] https://crrev.com/27ee9b58f15dadaa02370b4f6f1fa61496af554b/recipe_modules/buildbucket/tests/build.expected/v1 hidden tags.json
[add] https://crrev.com/27ee9b58f15dadaa02370b4f6f1fa61496af554b/recipe_modules/buildbucket/tests/build.py
[modify] https://crrev.com/27ee9b58f15dadaa02370b4f6f1fa61496af554b/recipe_modules/buildbucket/examples/full.py
[delete] https://crrev.com/ae1b7cd869b3821d84df1333a7abce956073f597/recipe_modules/buildbucket/tests/properties.py
[delete] https://crrev.com/ae1b7cd869b3821d84df1333a7abce956073f597/recipe_modules/buildbucket/tests/build_input.expected/gerrit change.json
[add] https://crrev.com/27ee9b58f15dadaa02370b4f6f1fa61496af554b/recipe_modules/buildbucket/tests/build.expected/v1 gerrit change.json
[copy] https://crrev.com/27ee9b58f15dadaa02370b4f6f1fa61496af554b/recipe_modules/buildbucket/tests/build.expected/v1 build with id.json
[delete] https://crrev.com/ae1b7cd869b3821d84df1333a7abce956073f597/recipe_modules/buildbucket/tests/build_id.expected/with_build.json
[add] https://crrev.com/27ee9b58f15dadaa02370b4f6f1fa61496af554b/recipe_modules/buildbucket/proto/step_pb2.py
[modify] https://crrev.com/27ee9b58f15dadaa02370b4f6f1fa61496af554b/recipe_engine/lint.py
[add] https://crrev.com/27ee9b58f15dadaa02370b4f6f1fa61496af554b/recipe_modules/buildbucket/proto/README.md
[modify] https://crrev.com/27ee9b58f15dadaa02370b4f6f1fa61496af554b/recipe_modules/buildbucket/examples/full.expected/basic-ci-win.json
[rename] https://crrev.com/27ee9b58f15dadaa02370b4f6f1fa61496af554b/recipe_modules/buildbucket/tests/build.expected/empty.json
[modify] https://crrev.com/27ee9b58f15dadaa02370b4f6f1fa61496af554b/PRESUBMIT.py
[add] https://crrev.com/27ee9b58f15dadaa02370b4f6f1fa61496af554b/recipe_modules/buildbucket/proto/__init__.py
[delete] https://crrev.com/ae1b7cd869b3821d84df1333a7abce956073f597/recipe_modules/buildbucket/tests/build_input.expected/empty buildset.json
[add] https://crrev.com/27ee9b58f15dadaa02370b4f6f1fa61496af554b/recipe_modules/buildbucket/tests/build.expected/v1 gitiles commit.json
[add] https://crrev.com/27ee9b58f15dadaa02370b4f6f1fa61496af554b/recipe_modules/buildbucket/tests/build.expected/v1 tags.json
[add] https://crrev.com/27ee9b58f15dadaa02370b4f6f1fa61496af554b/recipe_modules/buildbucket/tests/build.expected/v1 buildbot builder id.json
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba

commit 51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba
Author: Nodir Turakulov <nodir@google.com>
Date: Thu Aug 30 17:24:43 2018

Roll buildbucket recipe module changes

https://chromium-review.googlesource.com/c/infra/luci/recipes-py/+/1188390
requires a manual roll.
Retrain all recipes.

Downstream rolls:
build_limited: https://chrome-internal-review.googlesource.com/c/chrome/tools/build_limited/scripts/slave/+/669003
infra: https://chromium-review.googlesource.com/c/infra/infra/+/1194800

Recipe-Nontrivial-Roll: infra
Recipe-Manual-Change: build_limited_scripts_slave
Bug: 877161, 859231
Change-Id: Id54b391dad8d7f0358b146cf8c4e83fd1deacf45
Reviewed-on: https://chromium-review.googlesource.com/1195903
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>

[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_win10.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/findit/chromium/test.expected/flaky_tests.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/findit/chromium/test.expected/remove_culprits_for_flaky_failures.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_win32_release__clang_.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac64_debug.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/wasm_llvm.expected/linux.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_linux64_debug.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipe_modules/chromium_tests/tests/api/compile_specific_targets.expected/failure_tryserver.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipe_modules/goma/examples/full.expected/win_goma_canary.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_compile_x64_dbg.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/pdfium.expected/win_no_v8.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_linux_compile_fail.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipe_modules/dart/examples/example.expected/basic-missing-name.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipe_modules/dart/examples/example.expected/basic-timeout.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/cronet.expected/android_cronet_builder__dbg_.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_experimental.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/chromium.chromedriver.recipe_autogen.expected/Linux.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_mac_10_11.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipe_modules/goma/examples/full.expected/win.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/pdfium.expected/win_xfa_asan.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipe_modules/chromium_tests/tests/api/compile_specific_targets.expected/linux_tests.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/chromium_trybot.expected/swarmed_webkit_tests_interrupted.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/dart/sdk_swarming.expected/dart-sdk-linux-be.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/chromium.chromedriver.recipe_autogen.expected/Linux32.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/chromium.expected/build_dynamic_swarmed_isolated_script_test_compile_target_overidden.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/webrtc/more_configs.expected/full_client_webrtc_Linux__more_configs_.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/android/builder.expected/full_client_v8_fyi_Android_Builder.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_branches_win__beta_.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/findit/chromium/compile.expected/find_culprit_in_middle_of_a_sub_range.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Deterministic_Android.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipe_modules/goma/examples/full.expected/linux_debug.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_compile_rel.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32__m_nexus5x_.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_linux.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/findit/chromium/flake.expected/flakiness_isolate_only.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/swarming/staging.expected/one_fails.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/cronet.expected/cronet_try.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/findit/chromium/flake.expected/flakiness_swarming_tests.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/chromium_libfuzzer.expected/kitchen_paths.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux_ubsan.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/chromium_trybot.expected/dynamic_isolated_script_test_with_args_on_trybot.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipe_modules/cronet/examples/full.expected/gn_test.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_linux_trusty.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/findit/chromium/compile.expected/compile_specified_targets_from_parameter.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipe_modules/dart/examples/example.expected/basic-failure.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_android_x64.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_win64_release.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_release__gcc_.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/chromium_trybot.expected/invalid_results.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/cronet.expected/android_cronet_marshmallow_64bit_perf.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/findit/chromium/compile.expected/failed_compile_upon_infra_failure_goma_build_error.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Mac_deterministic.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/pdfium.expected/mac_xfa_rel.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32__m_nexus5x__failing_archive.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/chromium_libfuzzer.expected/full_chromium_fyi_Libfuzzer_Upload_Linux_MSan.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/chromium_libfuzzer.expected/full_chromium_fyi_Libfuzzer_Upload_Mac_ASan.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64___future_pass.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/chromium_libfuzzer.expected/full_chromium_fyi_Libfuzzer_Upload_Linux_UBSan.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_win_clang.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux32_debug.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux32_arm_dbg.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_linux_ubsan.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_asan.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/findit/chromium/test.expected/findit_culprit_in_last_sub_range.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/chromium_trybot.expected/dont_deapply_patch.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/cronet.expected/android_cronet_kitkat_builder.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/ios/try.expected/gn.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_linux64_debug_forced.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_ios_release.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_msan.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/pdfium.expected/linux.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_win_x64_clang_rel.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/findit/chromium/test.expected/record_infra_failure.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/findit/chromium/flake.expected/record_infra_failure.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/pdfium.expected/linux_xfa_jumbo.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_chromiumos_with_revision.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/android/builder.expected/full_chromium_perf_Android_Builder_Perf.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/pdfium.expected/linux_asan_lsan.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipe_modules/goma/examples/full.expected/mac.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_release.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/pdfium.expected/mac_xfa_jumbo.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux_tsan2.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_linux_tsan_v2.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_test.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/findit/chromium/test.expected/findit_tests_multiple_culprits.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/webrtc/ios_api_framework.expected/trybot_build.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/findit/chromium/flake.expected/use_build_parameter_for_tests.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_compile_targets.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/pdfium.expected/try-linux-gerrit_xfa_asan_lsan.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_linux_with_revision.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipe_modules/dart/examples/example.expected/basic-win-stable.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/flutter/engine.expected/mac.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/v8/node_integration.expected/experimental.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/chromium.chromedriver.recipe_autogen.expected/Mac_10_6.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_compile_x64_dbg.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/findit/chromium/compile.expected/compile_specified_targets.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_clang_dbg.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipe_modules/chromium/tests/compile.expected/codesearch.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/findit/chromium/test.expected/findit_steps_multiple_culprits.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/pdfium.expected/android.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipe_modules/chromium_tests/tests/api/trybot_steps.expected/basic.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/chromium.expected/dynamic_gtest_memory_builder.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/findit/chromium/compile.expected/find_culprit_at_first_revision_of_a_sub_range.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_arm64_rel.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_win32_debug__clang_.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_win64_debug__clang_.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/chromium_trybot.expected/compile_failure_infra.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_compile_rel.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_android64_x64_debug.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipe_modules/goma/examples/full.expected/linux_compile_failed.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/pdfium.expected/fail-pixel-tests.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipe_modules/goma/tests/start.expected/luci_and_experimental.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/cronet.expected/android_cronet_lollipop_builder.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/pdfium.expected/linux_xfa_rel.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Deterministic_Android_fail.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_linux_asan.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_ios.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_win_with_revision.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_compile_arm64_dbg.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_chromiumos_translation_unit_fail.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/infra/config/recipes.cfg
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_android_release.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_test_custom_name.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/android/builder.expected/full_chromium_perf_Android_arm64_Builder_Perf.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Deterministic_Linux.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64__dbg__pass.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/linux_sdk_asan_multi.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_linux_chromium_clobber_deterministic_fail.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipe_modules/chromium/tests/compile.expected/official_win_luci.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_mac64_release.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/chromium_trybot.expected/compile_failure_without_patch_ng.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_linux32_debug.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_android.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipe_modules/chromium_android/examples/full.expected/restart_usb_builder_basic.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux32_rel.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64_pass.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/pdfium.expected/win.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/ios/try.expected/goma_compilation_failure.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipe_modules/dart/examples/example.expected/basic-win.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_asan.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/chromium_trybot.expected/dynamic_swarmed_isolated_script_test_failure_no_result_json.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/findit/chromium/compile.expected/find_culprit_as_first_revision_of_entire_range.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64__dbg__fail.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_nodefault_test.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_branches_mac__beta_.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/webrtc/more_configs.expected/full_tryserver_webrtc_android_more_configs.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/webrtc/chromium_ios.expected/basic_goma_build.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/chromium_trybot.expected/clobber_analyze.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Deterministic_Linux__dbg__fail.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/angle.expected/linux.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_ubsan_vptr.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_android_with_revision.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/webrtc/ios_api_framework.expected/build_ok.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/chromium_trybot.expected/swarming_test_failure.json
[modify] https://crrev.com/51edb9f152a2f0c0d5caf1d1ff4c337fdc92bcba/scripts/slave/recipes/pdfium.expected/linux_xfa_asan_lsan.json
[modify] https://crrev.com/51edb9f152a2f0c0
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 30 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/635bf462b084c5d63b3645d43ab3a888c7d9c5f8

commit 635bf462b084c5d63b3645d43ab3a888c7d9c5f8
Author: Nodir Turakulov <nodir@google.com>
Date: Thu Aug 30 17:45:49 2018
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/recipes-py/+/8babfab3d9b041d23734ccfdd403beb070473f60

commit 8babfab3d9b041d23734ccfdd403beb070473f60
Author: Nodir Turakulov <nodir@google.com>
Date: Thu Aug 30 21:04:16 2018

[buildbucket] fill gitiles commit from legacy properties

If input gitiles commit is not available as a buildset tag, load it from
legacy repository, branch and revision properties.
Code that uses those will be able to switch
m.bulidbucket.build.input.gitiles_commit.

Also fix gitiles repo regexp. It parsed "https://invalid/" incorrectly.

Bug: 877161
Change-Id: I551173a75645524e0ad40e96ab1bc0b7ef6ed10e
Reviewed-on: https://chromium-review.googlesource.com/1196929
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[add] https://crrev.com/8babfab3d9b041d23734ccfdd403beb070473f60/recipe_modules/buildbucket/tests/build.expected/buildbot gitiles commit, a project prefix.json
[add] https://crrev.com/8babfab3d9b041d23734ccfdd403beb070473f60/recipe_modules/buildbucket/tests/build.expected/buildbot gitiles commit, invalid repo URL.json
[add] https://crrev.com/8babfab3d9b041d23734ccfdd403beb070473f60/recipe_modules/buildbucket/tests/build.expected/buildbot gitiles commit, branch.json
[modify] https://crrev.com/8babfab3d9b041d23734ccfdd403beb070473f60/recipe_modules/buildbucket/tests/build.py
[add] https://crrev.com/8babfab3d9b041d23734ccfdd403beb070473f60/recipe_modules/buildbucket/tests/build.expected/buildbot gitiles commit, invalid repo.json
[modify] https://crrev.com/8babfab3d9b041d23734ccfdd403beb070473f60/recipe_modules/buildbucket/test_api.py
[modify] https://crrev.com/8babfab3d9b041d23734ccfdd403beb070473f60/recipe_modules/buildbucket/util.py
[add] https://crrev.com/8babfab3d9b041d23734ccfdd403beb070473f60/recipe_modules/buildbucket/tests/build.expected/buildbot gitiles commit, no branch.json
[modify] https://crrev.com/8babfab3d9b041d23734ccfdd403beb070473f60/README.recipes.md
[add] https://crrev.com/8babfab3d9b041d23734ccfdd403beb070473f60/recipe_modules/buildbucket/tests/build.expected/buildbot gitiles commit, HEAD revision.json
[modify] https://crrev.com/8babfab3d9b041d23734ccfdd403beb070473f60/recipe_modules/buildbucket/__init__.py
[add] https://crrev.com/8babfab3d9b041d23734ccfdd403beb070473f60/recipe_modules/buildbucket/tests/build.expected/buildbot gitiles commit, no revision.json
[add] https://crrev.com/8babfab3d9b041d23734ccfdd403beb070473f60/recipe_modules/buildbucket/tests/build.expected/buildbot gitiles commit.json
[modify] https://crrev.com/8babfab3d9b041d23734ccfdd403beb070473f60/recipe_modules/buildbucket/api.py
[add] https://crrev.com/8babfab3d9b041d23734ccfdd403beb070473f60/recipe_modules/buildbucket/tests/build.expected/buildbot gitiles commit, neither ref nor revision.json
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/f20c5a4a3c70dd116fb8b0177f2e20b1a7038446

commit f20c5a4a3c70dd116fb8b0177f2e20b1a7038446
Author: Nodir Turakulov <nodir@google.com>
Date: Thu Aug 30 22:16:55 2018

[bot_update] Fix initialization from buildbucket

When checking if buildbucket.build_input.gitiles_commit exists, use
HasField protobuf method, as opposed to truth check. A protobuf message
field is always true.

Bug: 877161
Change-Id: Ie4a7e22b985776441a74283b09646e8837c326f1
Reviewed-on: https://chromium-review.googlesource.com/1196930
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/f20c5a4a3c70dd116fb8b0177f2e20b1a7038446/recipes/recipe_modules/bot_update/api.py
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e86f24273267955330d39be80c8ecbf74297938

commit 9e86f24273267955330d39be80c8ecbf74297938
Author: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri Aug 31 00:20:08 2018

Roll src/third_party/depot_tools eabc276ceacd..01bd09d56fbd (3 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/eabc276ceacd..01bd09d56fbd


git log eabc276ceacd..01bd09d56fbd --date=short --no-merges --format='%ad %ae %s'
2018-08-30 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-08-30 nodir@google.com [bot_update] Fix initialization from buildbucket
2018-08-30 recipe-roller@chromium.org Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/depot_tools@01bd09d56fbd

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:877161
TBR=agable@chromium.org

Change-Id: I6abb911ab1aa454dcd6d86d4fd60990c9333caad
Reviewed-on: https://chromium-review.googlesource.com/1198123
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#587873}
[modify] https://crrev.com/9e86f24273267955330d39be80c8ecbf74297938/DEPS

Comment 11 by machenb...@chromium.org, Aug 31 

Guess I reverted the wrong CL. I assume this is caused by https://crrev.com/c/1196929 - also if that one as no expectation changes and the other one had...

Comment 12 by machenb...@chromium.org, Aug 31 

Opps commented on wrong bug. Ignore last comment.
Project Member

Comment 13 by bugdroid1@chromium.org, Aug 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/recipes-py/+/826c7b72a3a49aec40320edd994b899e94502715

commit 826c7b72a3a49aec40320edd994b899e94502715
Author: Michael Achenbach <machenbach@chromium.org>
Date: Fri Aug 31 09:54:20 2018

Revert "[buildbucket] fill gitiles commit from legacy properties"

This reverts commit 8babfab3d9b041d23734ccfdd403beb070473f60.

Reason for revert: Speculative revert for https://crbug.com/879495

Original change's description:
> [buildbucket] fill gitiles commit from legacy properties
> 
> If input gitiles commit is not available as a buildset tag, load it from
> legacy repository, branch and revision properties.
> Code that uses those will be able to switch
> m.bulidbucket.build.input.gitiles_commit.
> 
> Also fix gitiles repo regexp. It parsed "https://invalid/" incorrectly.
> 
> Bug: 877161
> Change-Id: I551173a75645524e0ad40e96ab1bc0b7ef6ed10e
> Reviewed-on: https://chromium-review.googlesource.com/1196929
> Commit-Queue: Nodir Turakulov <nodir@chromium.org>
> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

TBR=nodir@chromium.org,tandrii@chromium.org

Change-Id: I1d32fb5bd69e586647aacba33ad2b91c32e3d882
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 877161,879495
Reviewed-on: https://chromium-review.googlesource.com/1199067
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>

[delete] https://crrev.com/b159b6a105fb08ac1bf1ab55d0d3537676d6226b/recipe_modules/buildbucket/tests/build.expected/buildbot gitiles commit, a project prefix.json
[delete] https://crrev.com/b159b6a105fb08ac1bf1ab55d0d3537676d6226b/recipe_modules/buildbucket/tests/build.expected/buildbot gitiles commit, invalid repo URL.json
[delete] https://crrev.com/b159b6a105fb08ac1bf1ab55d0d3537676d6226b/recipe_modules/buildbucket/tests/build.expected/buildbot gitiles commit, branch.json
[modify] https://crrev.com/826c7b72a3a49aec40320edd994b899e94502715/recipe_modules/buildbucket/tests/build.py
[delete] https://crrev.com/b159b6a105fb08ac1bf1ab55d0d3537676d6226b/recipe_modules/buildbucket/tests/build.expected/buildbot gitiles commit, invalid repo.json
[modify] https://crrev.com/826c7b72a3a49aec40320edd994b899e94502715/recipe_modules/buildbucket/test_api.py
[modify] https://crrev.com/826c7b72a3a49aec40320edd994b899e94502715/recipe_modules/buildbucket/util.py
[delete] https://crrev.com/b159b6a105fb08ac1bf1ab55d0d3537676d6226b/recipe_modules/buildbucket/tests/build.expected/buildbot gitiles commit, no branch.json
[modify] https://crrev.com/826c7b72a3a49aec40320edd994b899e94502715/README.recipes.md
[delete] https://crrev.com/b159b6a105fb08ac1bf1ab55d0d3537676d6226b/recipe_modules/buildbucket/tests/build.expected/buildbot gitiles commit, HEAD revision.json
[modify] https://crrev.com/826c7b72a3a49aec40320edd994b899e94502715/recipe_modules/buildbucket/__init__.py
[delete] https://crrev.com/b159b6a105fb08ac1bf1ab55d0d3537676d6226b/recipe_modules/buildbucket/tests/build.expected/buildbot gitiles commit, no revision.json
[delete] https://crrev.com/b159b6a105fb08ac1bf1ab55d0d3537676d6226b/recipe_modules/buildbucket/tests/build.expected/buildbot gitiles commit.json
[modify] https://crrev.com/826c7b72a3a49aec40320edd994b899e94502715/recipe_modules/buildbucket/api.py
[delete] https://crrev.com/b159b6a105fb08ac1bf1ab55d0d3537676d6226b/recipe_modules/buildbucket/tests/build.expected/buildbot gitiles commit, neither ref nor revision.json
Project Member

Comment 14 by bugdroid1@chromium.org, Aug 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/recipes-py/+/293be111ecf808c8fd2ba843100d204e5c33ba78

commit 293be111ecf808c8fd2ba843100d204e5c33ba78
Author: Nodir Turakulov <nodir@google.com>
Date: Fri Aug 31 13:25:57 2018

[buildbucket] Include child build tags in legacy tests

Include tags for child builds in recipe_modules/buildbucket/tests/build.py

Bug: 879495, 877161
Change-Id: I8e0e5950cb8b52f1a4ecba54c4bc3524a5f191bc
Reviewed-on: https://chromium-review.googlesource.com/1198583
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>

[modify] https://crrev.com/293be111ecf808c8fd2ba843100d204e5c33ba78/recipe_modules/buildbucket/tests/build.expected/serialized buildbucket property.json
[modify] https://crrev.com/293be111ecf808c8fd2ba843100d204e5c33ba78/recipe_modules/buildbucket/tests/build.py
[modify] https://crrev.com/293be111ecf808c8fd2ba843100d204e5c33ba78/recipe_modules/buildbucket/tests/build.expected/v1 gitiles commit, invalid.json
[modify] https://crrev.com/293be111ecf808c8fd2ba843100d204e5c33ba78/recipe_modules/buildbucket/tests/build.expected/v1 gerrit change.json
[modify] https://crrev.com/293be111ecf808c8fd2ba843100d204e5c33ba78/recipe_modules/buildbucket/tests/build.expected/v1 build with id.json
[modify] https://crrev.com/293be111ecf808c8fd2ba843100d204e5c33ba78/recipe_modules/buildbucket/tests/build.expected/v1 gitiles commit.json
[modify] https://crrev.com/293be111ecf808c8fd2ba843100d204e5c33ba78/README.recipes.md
[modify] https://crrev.com/293be111ecf808c8fd2ba843100d204e5c33ba78/recipe_modules/buildbucket/tests/build.expected/empty.json
[modify] https://crrev.com/293be111ecf808c8fd2ba843100d204e5c33ba78/recipe_modules/buildbucket/tests/build.expected/v1 luci builder id.json
[modify] https://crrev.com/293be111ecf808c8fd2ba843100d204e5c33ba78/recipe_modules/buildbucket/tests/build.expected/v1 tags.json
[modify] https://crrev.com/293be111ecf808c8fd2ba843100d204e5c33ba78/recipe_modules/buildbucket/tests/build.expected/v1 hidden tags.json
[modify] https://crrev.com/293be111ecf808c8fd2ba843100d204e5c33ba78/recipe_modules/buildbucket/tests/build.expected/v1 unknown buildset format.json
[modify] https://crrev.com/293be111ecf808c8fd2ba843100d204e5c33ba78/recipe_modules/buildbucket/tests/build.expected/v1 empty buildset.json
[modify] https://crrev.com/293be111ecf808c8fd2ba843100d204e5c33ba78/recipe_modules/buildbucket/tests/build.expected/v1 buildbot builder id.json
Project Member

Comment 15 by bugdroid1@chromium.org, Aug 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/recipes-py/+/9d1991d736085e87f7fbb35f1fb4a7f023060c82

commit 9d1991d736085e87f7fbb35f1fb4a7f023060c82
Author: Nodir Turakulov <nodir@google.com>
Date: Fri Aug 31 13:42:17 2018

Reland "[buildbucket] fill gitiles commit from legacy properties"

This is a reland of 8babfab3d9b041d23734ccfdd403beb070473f60
The original CL was incorrect. It learned to populate input gitiles
commit without id, but continued to generate commit buildset for
such commits. This CL is different:
1) prioritize patchset buildsets relative to commit buildsets
2) check that commit.id field is populated

also, based on https://chromium-review.googlesource.com/c/infra/luci/recipes-py/+/1198583
it has better test coverage.

Original change's description:
> [buildbucket] fill gitiles commit from legacy properties
>
> If input gitiles commit is not available as a buildset tag, load it from
> legacy repository, branch and revision properties.
> Code that uses those will be able to switch
> m.bulidbucket.build.input.gitiles_commit.
>
> Also fix gitiles repo regexp. It parsed "https://invalid/" incorrectly.
>
> Bug: 877161
> Change-Id: I551173a75645524e0ad40e96ab1bc0b7ef6ed10e
> Reviewed-on: https://chromium-review.googlesource.com/1196929
> Commit-Queue: Nodir Turakulov <nodir@chromium.org>
> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

Bug: 877161, 879495
Change-Id: Ib1453cc8289b94648374f275fb34bad0277f4ddb
Reviewed-on: https://chromium-review.googlesource.com/1198584
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>

[add] https://crrev.com/9d1991d736085e87f7fbb35f1fb4a7f023060c82/recipe_modules/buildbucket/tests/build.expected/buildbot gitiles commit, a project prefix.json
[add] https://crrev.com/9d1991d736085e87f7fbb35f1fb4a7f023060c82/recipe_modules/buildbucket/tests/build.expected/buildbot gitiles commit, no revision, with CL.json
[add] https://crrev.com/9d1991d736085e87f7fbb35f1fb4a7f023060c82/recipe_modules/buildbucket/tests/build.expected/buildbot gitiles commit, invalid repo URL.json
[add] https://crrev.com/9d1991d736085e87f7fbb35f1fb4a7f023060c82/recipe_modules/buildbucket/tests/build.expected/buildbot gitiles commit, branch.json
[modify] https://crrev.com/9d1991d736085e87f7fbb35f1fb4a7f023060c82/recipe_modules/buildbucket/tests/build.py
[add] https://crrev.com/9d1991d736085e87f7fbb35f1fb4a7f023060c82/recipe_modules/buildbucket/tests/build.expected/buildbot gitiles commit, invalid repo.json
[modify] https://crrev.com/9d1991d736085e87f7fbb35f1fb4a7f023060c82/recipe_modules/buildbucket/test_api.py
[modify] https://crrev.com/9d1991d736085e87f7fbb35f1fb4a7f023060c82/recipe_modules/buildbucket/util.py
[add] https://crrev.com/9d1991d736085e87f7fbb35f1fb4a7f023060c82/recipe_modules/buildbucket/tests/build.expected/buildbot gitiles commit, no branch.json
[modify] https://crrev.com/9d1991d736085e87f7fbb35f1fb4a7f023060c82/recipe_modules/buildbucket/tests/build.expected/v1 hidden tags.json
[modify] https://crrev.com/9d1991d736085e87f7fbb35f1fb4a7f023060c82/README.recipes.md
[add] https://crrev.com/9d1991d736085e87f7fbb35f1fb4a7f023060c82/recipe_modules/buildbucket/tests/build.expected/buildbot gitiles commit, HEAD revision.json
[modify] https://crrev.com/9d1991d736085e87f7fbb35f1fb4a7f023060c82/recipe_modules/buildbucket/__init__.py
[add] https://crrev.com/9d1991d736085e87f7fbb35f1fb4a7f023060c82/recipe_modules/buildbucket/tests/build.expected/buildbot gitiles commit, no revision.json
[add] https://crrev.com/9d1991d736085e87f7fbb35f1fb4a7f023060c82/recipe_modules/buildbucket/tests/build.expected/buildbot gitiles commit.json
[modify] https://crrev.com/9d1991d736085e87f7fbb35f1fb4a7f023060c82/recipe_modules/buildbucket/api.py
[add] https://crrev.com/9d1991d736085e87f7fbb35f1fb4a7f023060c82/recipe_modules/buildbucket/tests/build.expected/buildbot gitiles commit, neither ref nor revision.json
Project Member

Comment 16 by bugdroid1@chromium.org, Aug 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/recipes-py/+/f25fbdce1dc0976980f2b1f5120af828e9a68a34

commit f25fbdce1dc0976980f2b1f5120af828e9a68a34
Author: Nodir Turakulov <nodir@google.com>
Date: Fri Aug 31 16:30:46 2018

Reland [buildbucket] Parse CL from legacy properties

This is a reland of
https://chromium-review.googlesource.com/c/infra/luci/recipes-py/+/1196934

Only generated files are different.

Original change's description:
> [buildbucket] Parse CL from legacy properties
>
> If no GerritChange was parsed from tags and patch_storage='gerrit', then
> parse GerritChange from properties patch_gerrit_url, patch_project, patch_issue,
> patch_set, issue and/or patchset.
>
> R=tandrii@chromium.org
> Recipe-Nontrivial-Roll: build
> Recipe-Nontrivial-Roll: build_limited_scripts_slave
> Bug:  694348 
> Change-Id: I373e902ee05c351561d9037d17072e0bf7202fff
> Reviewed-on: https://chromium-review.googlesource.com/1196934
> Commit-Queue: Nodir Turakulov <nodir@chromium.org>
> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Bug: 877161, 879495
Change-Id: Iec301d9218262b48cc1c18dbd2861e3bdb98564b
Reviewed-on: https://chromium-review.googlesource.com/1199846
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>

[add] https://crrev.com/f25fbdce1dc0976980f2b1f5120af828e9a68a34/recipe_modules/buildbucket/tests/build.expected/buildbot gerrit change.json
[add] https://crrev.com/f25fbdce1dc0976980f2b1f5120af828e9a68a34/recipe_modules/buildbucket/tests/build.expected/buildbot gerrit change, issue and patchset properties.json
[modify] https://crrev.com/f25fbdce1dc0976980f2b1f5120af828e9a68a34/recipe_modules/buildbucket/tests/build.py
[add] https://crrev.com/f25fbdce1dc0976980f2b1f5120af828e9a68a34/recipe_modules/buildbucket/tests/build.expected/buildbot gerrit change, string issue, not a number.json
[add] https://crrev.com/f25fbdce1dc0976980f2b1f5120af828e9a68a34/recipe_modules/buildbucket/tests/build.expected/buildbot gerrit change, no project.json
[modify] https://crrev.com/f25fbdce1dc0976980f2b1f5120af828e9a68a34/README.recipes.md
[modify] https://crrev.com/f25fbdce1dc0976980f2b1f5120af828e9a68a34/recipe_modules/buildbucket/api.py
[modify] https://crrev.com/f25fbdce1dc0976980f2b1f5120af828e9a68a34/recipe_modules/buildbucket/__init__.py
[modify] https://crrev.com/f25fbdce1dc0976980f2b1f5120af828e9a68a34/recipe_modules/buildbucket/util.py
[add] https://crrev.com/f25fbdce1dc0976980f2b1f5120af828e9a68a34/recipe_modules/buildbucket/tests/build.expected/buildbot gerrit change, string issue.json
Project Member

Comment 17 by bugdroid1@chromium.org, Aug 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/efc95d6b9a8b53b8aa1d03ced4f2943894582b66

commit efc95d6b9a8b53b8aa1d03ced4f2943894582b66
Author: Nodir Turakulov <nodir@google.com>
Date: Fri Aug 31 21:30:57 2018

[bot_update] Untie revision and repository properties

repository and revision have less to do with each other than it seems:
revision is for checkout and the part of code that reads revision does not
read repository.
repository property is used to determine what to apply the patchset to.

When initializing their values from buildbucket.build.input, do it separately.
Also, initialize repository from Gerrit changes, not Gitiles commit.

See also
https://chromium-review.googlesource.com/c/infra/luci/recipes-py/+/1199854
https://chromium-review.googlesource.com/c/infra/luci/recipes-py/+/1199856
Bug: 877161,  694348 
Change-Id: I4907a31ce055a3526b15f1a3c8e8f15c2c831437
Reviewed-on: https://chromium-review.googlesource.com/1200065
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/efc95d6b9a8b53b8aa1d03ced4f2943894582b66/recipes/README.recipes.md
[modify] https://crrev.com/efc95d6b9a8b53b8aa1d03ced4f2943894582b66/recipes/recipe_modules/bot_update/examples/buildbucket.py
[modify] https://crrev.com/efc95d6b9a8b53b8aa1d03ced4f2943894582b66/recipes/recipe_modules/bot_update/api.py
[add] https://crrev.com/efc95d6b9a8b53b8aa1d03ced4f2943894582b66/recipes/recipe_modules/bot_update/examples/buildbucket.expected/try.json
Project Member

Comment 18 by bugdroid1@chromium.org, Aug 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/recipes-py/+/05d5dfbcffe7924ac6344f14904224db54a93574

commit 05d5dfbcffe7924ac6344f14904224db54a93574
Author: Nodir Turakulov <nodir@google.com>
Date: Fri Aug 31 21:35:41 2018

[buildbucket] Ignore "repository" and "branch" properties

https://chromium-review.googlesource.com/c/infra/luci/recipes-py/+/1198584
populates build.input.gitiles_commit from repository and branch properties.
This is incorrect because those properties, apparently, has nothing to do with
the commit to checkout, rather than with patchset to apply.
Therefore, they must not contribute to build.input.gitiles_commit.

This changes build.input.gitiles_commit populated from legacy property to never
specify host and project (i.e. they are not guaranteed to be populated),
so tags_for_child_build() was updated accordingly.

bot_update is being updated to (temporarily) read "repository" property from
build.input.gerrit_changes[0] in case it is missing, as opposed to
build.input.gitiles_commit:
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1200065

Bug: 877161,  694348 
Change-Id: I0fd8dec0b15fab6a4363a3b7b2220fdd18160639
Reviewed-on: https://chromium-review.googlesource.com/1199854
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[delete] https://crrev.com/f25fbdce1dc0976980f2b1f5120af828e9a68a34/recipe_modules/buildbucket/tests/build.expected/buildbot gitiles commit, a project prefix.json
[delete] https://crrev.com/f25fbdce1dc0976980f2b1f5120af828e9a68a34/recipe_modules/buildbucket/tests/build.expected/buildbot gitiles commit, no revision, with CL.json
[delete] https://crrev.com/f25fbdce1dc0976980f2b1f5120af828e9a68a34/recipe_modules/buildbucket/tests/build.expected/buildbot gitiles commit, branch.json
[modify] https://crrev.com/05d5dfbcffe7924ac6344f14904224db54a93574/recipe_modules/buildbucket/tests/build.py
[delete] https://crrev.com/f25fbdce1dc0976980f2b1f5120af828e9a68a34/recipe_modules/buildbucket/tests/build.expected/buildbot gitiles commit, invalid repo.json
[rename] https://crrev.com/05d5dfbcffe7924ac6344f14904224db54a93574/recipe_modules/buildbucket/tests/build.expected/buildbot gitiles commit, invalid revision.json
[modify] https://crrev.com/05d5dfbcffe7924ac6344f14904224db54a93574/recipe_modules/buildbucket/util.py
[modify] https://crrev.com/05d5dfbcffe7924ac6344f14904224db54a93574/recipe_modules/buildbucket/tests/build.expected/buildbot gitiles commit, HEAD revision.json
[rename] https://crrev.com/05d5dfbcffe7924ac6344f14904224db54a93574/recipe_modules/buildbucket/tests/build.expected/buildbot gerrit change with revision.json
[modify] https://crrev.com/05d5dfbcffe7924ac6344f14904224db54a93574/README.recipes.md
[add] https://crrev.com/05d5dfbcffe7924ac6344f14904224db54a93574/recipe_modules/buildbucket/tests/build.expected/buildbot gerrit change, patch_gerrit_url without scheme.json
[modify] https://crrev.com/05d5dfbcffe7924ac6344f14904224db54a93574/recipe_modules/buildbucket/__init__.py
[copy] https://crrev.com/05d5dfbcffe7924ac6344f14904224db54a93574/recipe_modules/buildbucket/tests/build.expected/buildbot gerrit change, patch_gerrit_url with unexpected scheme.json
[modify] https://crrev.com/05d5dfbcffe7924ac6344f14904224db54a93574/recipe_modules/buildbucket/tests/build.expected/buildbot gitiles commit.json
[modify] https://crrev.com/05d5dfbcffe7924ac6344f14904224db54a93574/recipe_modules/buildbucket/api.py
[delete] https://crrev.com/f25fbdce1dc0976980f2b1f5120af828e9a68a34/recipe_modules/buildbucket/tests/build.expected/buildbot gitiles commit, no revision.json
[delete] https://crrev.com/f25fbdce1dc0976980f2b1f5120af828e9a68a34/recipe_modules/buildbucket/tests/build.expected/buildbot gitiles commit, neither ref nor revision.json
Project Member

Comment 19 by bugdroid1@chromium.org, Aug 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/recipes-py/+/809e57935211b3fcb802f74a7844d4f36eff6b87

commit 809e57935211b3fcb802f74a7844d4f36eff6b87
Author: Nodir Turakulov <nodir@google.com>
Date: Fri Aug 31 21:46:44 2018

[buildbucket] add support for parent_got_revision

got_revision is normally propagated from a parent build to a child build
as a parent_got_revision property.
It is possible that there are builders that rely on parent_got_revision
and don't use buildbucket for triggering, don't specify
commit buildset tag or whose parent did not have "revision" but
did have "got_revision".

Fallback to parent_got_revision if revision is not available.

Bug: 877161,  694348 
Change-Id: I981e940bc777c809925f4dc267876d8a5910cda4
Reviewed-on: https://chromium-review.googlesource.com/1199856
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/809e57935211b3fcb802f74a7844d4f36eff6b87/recipe_modules/buildbucket/tests/build.py
[add] https://crrev.com/809e57935211b3fcb802f74a7844d4f36eff6b87/recipe_modules/buildbucket/tests/build.expected/buildbot gitiles commit, both revision and parent_got_revision.json
[modify] https://crrev.com/809e57935211b3fcb802f74a7844d4f36eff6b87/README.recipes.md
[modify] https://crrev.com/809e57935211b3fcb802f74a7844d4f36eff6b87/recipe_modules/buildbucket/api.py
[modify] https://crrev.com/809e57935211b3fcb802f74a7844d4f36eff6b87/recipe_modules/buildbucket/__init__.py
[add] https://crrev.com/809e57935211b3fcb802f74a7844d4f36eff6b87/recipe_modules/buildbucket/tests/build.expected/buildbot gitiles commit, parent_got_revision.json
Project Member

Comment 20 by bugdroid1@chromium.org, Sep 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27028c1e27b992351011dcb9bfeb7cd437ffc5ca

commit 27028c1e27b992351011dcb9bfeb7cd437ffc5ca
Author: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Sat Sep 01 01:25:15 2018

Roll src/third_party/depot_tools 4259762b3597..e323bd9d2263 (3 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4259762b3597..e323bd9d2263


git log 4259762b3597..e323bd9d2263 --date=short --no-merges --format='%ad %ae %s'
2018-08-31 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-08-31 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-08-31 nodir@google.com [bot_update] Untie revision and repository properties


Created with:
  gclient setdep -r src/third_party/depot_tools@e323bd9d2263

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:877161, chromium:694348 
TBR=agable@chromium.org

Change-Id: I2435f620a6af4d970ed09912de690acbafa7523a
Reviewed-on: https://chromium-review.googlesource.com/1199875
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#588240}
[modify] https://crrev.com/27028c1e27b992351011dcb9bfeb7cd437ffc5ca/DEPS
Project Member

Comment 21 by bugdroid1@chromium.org, Sep 1 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/852d850bba1c86817b4a17ae85beba52cd4bfb13

commit 852d850bba1c86817b4a17ae85beba52cd4bfb13
Author: Nodir Turakulov <nodir@google.com>
Date: Sat Sep 01 07:59:26 2018
Project Member

Comment 22 by bugdroid1@chromium.org, Sep 5 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/4ecfd4a7d8c70ebcbe5e0d99483c566de6b14f70

commit 4ecfd4a7d8c70ebcbe5e0d99483c566de6b14f70
Author: Nodir Turakulov <nodir@google.com>
Date: Tue Sep 04 19:40:38 2018
Project Member

Comment 23 by bugdroid1@chromium.org, Sep 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/cffb2f125b04cef157048fa73724dae7f260e60b

commit cffb2f125b04cef157048fa73724dae7f260e60b
Author: Nodir Turakulov <nodir@google.com>
Date: Tue Sep 04 22:17:00 2018

Use same repo url in buildset and gclient config

Update tests to use same repo url in buildset tag and gclient solution
config.

This is a prerequisite for
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1200066

Bug: 877161
Change-Id: I1dd7b20a4265ae33081ff72427434e0f436e852e
Reviewed-on: https://chromium-review.googlesource.com/1204697
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#17389}
[modify] https://crrev.com/cffb2f125b04cef157048fa73724dae7f260e60b/recipes/recipe_modules/infra_checkout/examples/full.py
[modify] https://crrev.com/cffb2f125b04cef157048fa73724dae7f260e60b/recipes/recipes/luci_go.py
Project Member

Comment 24 by bugdroid1@chromium.org, Sep 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/94f04013b91fc5d00cd96575eab48b955f856ee4

commit 94f04013b91fc5d00cd96575eab48b955f856ee4
Author: Nodir Turakulov <nodir@google.com>
Date: Tue Sep 04 22:07:08 2018

Use same repo url in buildset and gclient config

Update tests to use same repo url in buildset tag and gclient solution
config.

This is a prerequisite for
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1200066

Bug: 877161
TBR=tandrii@chromium.org
Change-Id: I90065d40f3e026a6a7615c935b9916cd456104d7
Reviewed-on: https://chromium-review.googlesource.com/1204793
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/94f04013b91fc5d00cd96575eab48b955f856ee4/scripts/slave/recipes/boringssl_docs.py
Project Member

Comment 25 by bugdroid1@chromium.org, Sep 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/0a94fb47ebea4abadc7bf28ac9f5591b794f82b0

commit 0a94fb47ebea4abadc7bf28ac9f5591b794f82b0
Author: Nodir Turakulov <nodir@google.com>
Date: Tue Sep 04 22:38:28 2018

Use same repo url in buildset and gclient config

Update tests to use same repo url in buildset tag and gclient solution
config.

This is a prerequisite for
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1200066

TBR=tandrii@chromium.org

Bug: 877161
Change-Id: Id7a15cf9e217a52d2008130b976be352a72acc6b
Reviewed-on: https://chromium-review.googlesource.com/1205550
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#17391}
[modify] https://crrev.com/0a94fb47ebea4abadc7bf28ac9f5591b794f82b0/recipes/recipes/luci_gae.py
Project Member

Comment 26 by bugdroid1@chromium.org, Sep 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3751fb7e3c7d177764ef17bb922aff275f27ad9d

commit 3751fb7e3c7d177764ef17bb922aff275f27ad9d
Author: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Tue Sep 04 22:59:49 2018

Roll src/third_party/depot_tools e323bd9d2263..f215ae6ed0ce (1 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e323bd9d2263..f215ae6ed0ce


git log e323bd9d2263..f215ae6ed0ce --date=short --no-merges --format='%ad %ae %s'
2018-09-04 nodir@google.com [gitiles] Add parse_repo_url function


Created with:
  gclient setdep -r src/third_party/depot_tools@f215ae6ed0ce

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:877161
TBR=agable@chromium.org

Change-Id: I17e92be0b23dedfe7d1297913352a0323ba1c627
Reviewed-on: https://chromium-review.googlesource.com/1204817
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#588683}
[modify] https://crrev.com/3751fb7e3c7d177764ef17bb922aff275f27ad9d/DEPS
Project Member

Comment 27 by bugdroid1@chromium.org, Sep 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/1f1d4002842d8acb55ffbedcdf577869ebefec90

commit 1f1d4002842d8acb55ffbedcdf577869ebefec90
Author: Nodir Turakulov <nodir@google.com>
Date: Thu Sep 06 20:54:46 2018

Set repository property in chromium_trybot tests

Set repository property when patch_project is set.
Fix invalid expectation files.

Bug: 877161
TBR=jbudorick@chromium.org
Change-Id: Ia7cc75094fc3dc7374a8b0fa547875970229949d
Reviewed-on: https://chromium-review.googlesource.com/1211426
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/1f1d4002842d8acb55ffbedcdf577869ebefec90/scripts/slave/recipes/chromium_trybot.expected/use_v8_patch_on_chromium_trybot.json
[modify] https://crrev.com/1f1d4002842d8acb55ffbedcdf577869ebefec90/scripts/slave/recipes/chromium_trybot.expected/use_webrtc_patch_on_chromium_trybot_compile_failure.json
[modify] https://crrev.com/1f1d4002842d8acb55ffbedcdf577869ebefec90/scripts/slave/recipes/chromium_trybot.expected/use_skia_patch_on_blink_trybot.json
[modify] https://crrev.com/1f1d4002842d8acb55ffbedcdf577869ebefec90/scripts/slave/recipes/chromium_trybot.expected/use_webrtc_patch_on_chromium_trybot.json
[modify] https://crrev.com/1f1d4002842d8acb55ffbedcdf577869ebefec90/scripts/slave/recipes/chromium_trybot.py
[modify] https://crrev.com/1f1d4002842d8acb55ffbedcdf577869ebefec90/scripts/slave/recipes/chromium_trybot.expected/use_skia_patch_on_chromium_trybot.json
Project Member

Comment 28 by bugdroid1@chromium.org, Sep 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/4e3920bef0ae146b26827f2c249847905d4e2e26

commit 4e3920bef0ae146b26827f2c249847905d4e2e26
Author: Nodir Turakulov <nodir@google.com>
Date: Thu Sep 06 21:13:58 2018

[gclient] Start actively using repo_path_map

Use repo_path_map in all places where patch_projects is currently used.
Add gclient.get_repo_path function to resolve path to a repo given its URL.

infra.git requires a non-trivial roll because of incorrect expectations.

Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: infra
Bug: 877161
Change-Id: Iaea0a3f14609bf0c18d4ecdf8564153b8052584d
Reviewed-on: https://chromium-review.googlesource.com/1208363
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[delete] https://crrev.com/9af7d107ded91d27ef44b67bb94adc9c3b1010c2/recipes/recipe_modules/gitiles/tests/parse_repo_url.expected/no scheme.json
[modify] https://crrev.com/4e3920bef0ae146b26827f2c249847905d4e2e26/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_v8_head_by_default.json
[modify] https://crrev.com/4e3920bef0ae146b26827f2c249847905d4e2e26/recipes/recipe_modules/gclient/api.py
[modify] https://crrev.com/4e3920bef0ae146b26827f2c249847905d4e2e26/recipes/recipe_modules/gitiles/api.py
[modify] https://crrev.com/4e3920bef0ae146b26827f2c249847905d4e2e26/recipes/recipe_modules/gitiles/tests/parse_repo_url.expected/basic.json
[delete] https://crrev.com/9af7d107ded91d27ef44b67bb94adc9c3b1010c2/recipes/recipe_modules/gitiles/tests/parse_repo_url.expected/plus.json
[delete] https://crrev.com/9af7d107ded91d27ef44b67bb94adc9c3b1010c2/recipes/recipe_modules/gitiles/tests/parse_repo_url.expected/a prefix.json
[delete] https://crrev.com/9af7d107ded91d27ef44b67bb94adc9c3b1010c2/recipes/recipe_modules/gitiles/tests/parse_repo_url.expected/query string param.json
[delete] https://crrev.com/9af7d107ded91d27ef44b67bb94adc9c3b1010c2/recipes/recipe_modules/gitiles/tests/parse_repo_url.expected/git suffix.json
[modify] https://crrev.com/4e3920bef0ae146b26827f2c249847905d4e2e26/recipes/recipe_modules/bot_update/examples/full.py
[modify] https://crrev.com/4e3920bef0ae146b26827f2c249847905d4e2e26/recipes/recipe_modules/gitiles/tests/parse_repo_url.py
[modify] https://crrev.com/4e3920bef0ae146b26827f2c249847905d4e2e26/recipes/README.recipes.md
[modify] https://crrev.com/4e3920bef0ae146b26827f2c249847905d4e2e26/recipes/recipe_modules/gclient/config.py
[delete] https://crrev.com/9af7d107ded91d27ef44b67bb94adc9c3b1010c2/recipes/recipe_modules/gitiles/tests/parse_repo_url.expected/http and a prefix.json
[modify] https://crrev.com/4e3920bef0ae146b26827f2c249847905d4e2e26/recipes/recipe_modules/gclient/tests/patch_project.py
[modify] https://crrev.com/4e3920bef0ae146b26827f2c249847905d4e2e26/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_gerrit_webrtc.json
[delete] https://crrev.com/9af7d107ded91d27ef44b67bb94adc9c3b1010c2/recipes/recipe_modules/gitiles/tests/parse_repo_url.expected/http.json
[modify] https://crrev.com/4e3920bef0ae146b26827f2c249847905d4e2e26/recipes/recipe_modules/gclient/__init__.py
Project Member

Comment 29 by bugdroid1@chromium.org, Sep 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/070351532e39650a3b0921faab76cbba2f87930b

commit 070351532e39650a3b0921faab76cbba2f87930b
Author: Nodir Turakulov <nodir@google.com>
Date: Thu Sep 06 22:06:23 2018

Roll recipe dependencies

Manual roll of:
  https://crrev.com/4e3920bef0ae146b26827f2c249847905d4e2e26 [gclient] Start actively using repo_path_map (nodir@google.com)

Also, in chromium_trybot tests, specify patch_repository_url property where
repository property is specified.

infra.git roll will be non-trivial because luci-py contains wrong expectations:
https://logs.chromium.org/logs/infra/buildbucket/cr-buildbucket.appspot.com/8936097930376792416/+/steps/test__with_patch_/0/stdout

R=tandrii@chromium.org

Recipe-Nontrivial-Roll: infra
Bug: 877161
Change-Id: Idf59e217876d26c84c399900736da5583db6af46
Reviewed-on: https://chromium-review.googlesource.com/1211431
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>

[modify] https://crrev.com/070351532e39650a3b0921faab76cbba2f87930b/scripts/slave/README.recipes.md
[modify] https://crrev.com/070351532e39650a3b0921faab76cbba2f87930b/scripts/slave/recipes/chromium_trybot.expected/use_v8_patch_on_blink_trybot.json
[modify] https://crrev.com/070351532e39650a3b0921faab76cbba2f87930b/scripts/slave/recipes/chromium_trybot.py
[modify] https://crrev.com/070351532e39650a3b0921faab76cbba2f87930b/infra/config/recipes.cfg
Project Member

Comment 30 by bugdroid1@chromium.org, Sep 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/60e7f52377fddd08495685315e3291aa776a1b94

commit 60e7f52377fddd08495685315e3291aa776a1b94
Author: Nodir Turakulov <nodir@google.com>
Date: Thu Sep 06 22:20:29 2018

[bot_update] Stop using revision and parent_got_revision properties

Use self.m.buildbucket.build.input.gitiles_commit.id instead.
It encapsulates revision and parent_got_revision properties.

Also, honor host and project of the specified commit.
This enables overriding non-first gclient solution at the build-level
for arbitrary buildbucket builds.


Bug: 877161
Change-Id: I3f92f04ca84a1d30cbbb2670f62bea2bd9ee5932
Reviewed-on: https://chromium-review.googlesource.com/1200066
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/60e7f52377fddd08495685315e3291aa776a1b94/recipes/recipe_modules/bot_update/api.py
[modify] https://crrev.com/60e7f52377fddd08495685315e3291aa776a1b94/recipes/recipe_modules/bot_update/examples/buildbucket.py
[add] https://crrev.com/60e7f52377fddd08495685315e3291aa776a1b94/recipes/recipe_modules/bot_update/examples/buildbucket.expected/ci without repo.json
[modify] https://crrev.com/60e7f52377fddd08495685315e3291aa776a1b94/recipes/README.recipes.md
[add] https://crrev.com/60e7f52377fddd08495685315e3291aa776a1b94/recipes/recipe_modules/bot_update/examples/buildbucket.expected/ci with invalid repo.json
[modify] https://crrev.com/60e7f52377fddd08495685315e3291aa776a1b94/recipes/recipe_modules/bot_update/__init__.py
Project Member

Comment 31 by bugdroid1@chromium.org, Sep 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ec1fd0d2e54002533c6c640aa101c2d76c241fe

commit 1ec1fd0d2e54002533c6c640aa101c2d76c241fe
Author: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Thu Sep 06 23:56:30 2018

Roll src/third_party/depot_tools b56a43a9064c..60e7f52377fd (3 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b56a43a9064c..60e7f52377fd


git log b56a43a9064c..60e7f52377fd --date=short --no-merges --format='%ad %ae %s'
2018-09-06 nodir@google.com [bot_update] Stop using revision and parent_got_revision properties
2018-09-06 nodir@google.com [gclient] Start actively using repo_path_map
2018-09-06 nodir@chromium.org Revert "bot_update: Specify the target branch for patch_refs."


Created with:
  gclient setdep -r src/third_party/depot_tools@60e7f52377fd

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:877161,chromium:877161,chromium:870279
TBR=agable@chromium.org

Change-Id: I1d94db4d53689165b9e5e39e067650f62a7918ca
Reviewed-on: https://chromium-review.googlesource.com/1211870
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#589372}
[modify] https://crrev.com/1ec1fd0d2e54002533c6c640aa101c2d76c241fe/DEPS
Project Member

Comment 32 by bugdroid1@chromium.org, Sep 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/recipes-py/+/6116e44efc754249e8d5f1d9cdbf21f766ca781a

commit 6116e44efc754249e8d5f1d9cdbf21f766ca781a
Author: Nodir Turakulov <nodir@google.com>
Date: Fri Sep 07 00:48:33 2018

[buildbucket] Populate gerrit project in tests

Populate GerritChange.project in buildbucket test API.

R=tandrii@chromium.org

Bug: 877161
Change-Id: I7254bdf168aa2c0db923ee865342f1af774fa846
Reviewed-on: https://chromium-review.googlesource.com/1211652
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/6116e44efc754249e8d5f1d9cdbf21f766ca781a/recipe_modules/buildbucket/test_api.py
[modify] https://crrev.com/6116e44efc754249e8d5f1d9cdbf21f766ca781a/README.recipes.md
Project Member

Comment 34 by bugdroid1@chromium.org, Sep 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/f022f91453f7c9caef7b7c7519d2e311dc0e72bd

commit f022f91453f7c9caef7b7c7519d2e311dc0e72bd
Author: Nodir Turakulov <nodir@chromium.org>
Date: Sat Sep 08 00:50:54 2018

Revert "[bot_update] Stop using repository properties"

This reverts commit 4d2b901804e0319d56594502f038d018b40afb97.

Reason for revert: https://chromium-review.googlesource.com/c/chromium/tools/build/+/1214622

Original change's description:
> [bot_update] Stop using repository properties
> 
> Stop using repository and patch_repository_url properties.
> Use self.m.buildbucket.build.input.gerrit_changes[0].{host, project}
> instead.
> 
> R=​ehmaldonado@chromium.org, tandrii@chromium.org
> 
> Recipe-Nontrivial-Roll: build
> Bug: 877161,  694348 
> Change-Id: Ideb069c6c8f8b6e6cfb5217f8a04ea18f16d3056
> Reviewed-on: https://chromium-review.googlesource.com/1208368
> Commit-Queue: Nodir Turakulov <nodir@chromium.org>
> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

TBR=nodir@chromium.org,tandrii@chromium.org,ehmaldonado@chromium.org

Change-Id: I825242124382e9f1789d4a3da0a3bdd2a5fcab37
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 877161,  694348 
Reviewed-on: https://chromium-review.googlesource.com/1214703
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/f022f91453f7c9caef7b7c7519d2e311dc0e72bd/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_gerrit_webrtc.json
[modify] https://crrev.com/f022f91453f7c9caef7b7c7519d2e311dc0e72bd/recipes/recipe_modules/bot_update/examples/full.py
[modify] https://crrev.com/f022f91453f7c9caef7b7c7519d2e311dc0e72bd/recipes/README.recipes.md
[modify] https://crrev.com/f022f91453f7c9caef7b7c7519d2e311dc0e72bd/recipes/recipe_modules/bot_update/api.py
[modify] https://crrev.com/f022f91453f7c9caef7b7c7519d2e311dc0e72bd/recipes/recipe_modules/bot_update/__init__.py
Project Member

Comment 35 by bugdroid1@chromium.org, Sep 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/494afef8c699b826c2c42e2d5bc2256f64c62259

commit 494afef8c699b826c2c42e2d5bc2256f64c62259
Author: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Sat Sep 08 02:09:00 2018

Roll src/third_party/depot_tools aca984cbf105..4d2b901804e0 (1 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/aca984cbf105..4d2b901804e0


git log aca984cbf105..4d2b901804e0 --date=short --no-merges --format='%ad %ae %s'
2018-09-08 nodir@google.com [bot_update] Stop using repository properties


Created with:
  gclient setdep -r src/third_party/depot_tools@4d2b901804e0

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:877161, chromium:694348 
TBR=agable@chromium.org

Change-Id: Id654c6bb6ee3d471ebe214dd6762179069114c79
Reviewed-on: https://chromium-review.googlesource.com/1214582
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#589753}
[modify] https://crrev.com/494afef8c699b826c2c42e2d5bc2256f64c62259/DEPS
Project Member

Comment 36 by bugdroid1@chromium.org, Sep 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c2342acb567d0b1ce9bf54638261ede5638e395

commit 1c2342acb567d0b1ce9bf54638261ede5638e395
Author: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Sat Sep 08 04:37:24 2018

Roll src/third_party/depot_tools 4d2b901804e0..f022f91453f7 (1 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4d2b901804e0..f022f91453f7


git log 4d2b901804e0..f022f91453f7 --date=short --no-merges --format='%ad %ae %s'
2018-09-08 nodir@chromium.org Revert "[bot_update] Stop using repository properties"


Created with:
  gclient setdep -r src/third_party/depot_tools@f022f91453f7

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:877161, chromium:694348 
TBR=agable@chromium.org

Change-Id: I26f83aba6c0a3e1adb3db8e4769af40c306023b5
Reviewed-on: https://chromium-review.googlesource.com/1214822
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#589770}
[modify] https://crrev.com/1c2342acb567d0b1ce9bf54638261ede5638e395/DEPS
Project Member

Comment 37 by bugdroid1@chromium.org, Sep 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/d91f0adca28010485feb68042594d59171867de3

commit d91f0adca28010485feb68042594d59171867de3
Author: Nodir Turakulov <nodir@google.com>
Date: Mon Sep 10 18:13:13 2018

Reland "[bot_update] Stop using repository properties"

This is a reland of 4d2b901804e0319d56594502f038d018b40afb97
verbatim. The problem was in the buildbucket recipe module, see
https://chromium-review.googlesource.com/c/infra/luci/recipes-py/+/1215002#message-2351f1089af71655dbaff576aa4d11f1dedc800b

Original change's description:
> [bot_update] Stop using repository properties
>
> Stop using repository and patch_repository_url properties.
> Use self.m.buildbucket.build.input.gerrit_changes[0].{host, project}
> instead.
>
> R=ehmaldonado@chromium.org, tandrii@chromium.org
>
> Recipe-Nontrivial-Roll: build
> Bug: 877161,  694348 
> Change-Id: Ideb069c6c8f8b6e6cfb5217f8a04ea18f16d3056
> Reviewed-on: https://chromium-review.googlesource.com/1208368
> Commit-Queue: Nodir Turakulov <nodir@chromium.org>
> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: skia
Bug: 877161,  694348 
Change-Id: I0a10ca7814a8f5bdfd30a491e36fb7261cdaf225
Reviewed-on: https://chromium-review.googlesource.com/1214705
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/d91f0adca28010485feb68042594d59171867de3/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_gerrit_webrtc.json
[modify] https://crrev.com/d91f0adca28010485feb68042594d59171867de3/recipes/recipe_modules/bot_update/examples/full.py
[modify] https://crrev.com/d91f0adca28010485feb68042594d59171867de3/recipes/README.recipes.md
[modify] https://crrev.com/d91f0adca28010485feb68042594d59171867de3/recipes/recipe_modules/bot_update/api.py
[modify] https://crrev.com/d91f0adca28010485feb68042594d59171867de3/recipes/recipe_modules/bot_update/__init__.py
Project Member

Comment 38 by bugdroid1@chromium.org, Sep 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e775edd2af6cadc46e26dc632e9b1d0c20c40558

commit e775edd2af6cadc46e26dc632e9b1d0c20c40558
Author: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Mon Sep 10 19:32:59 2018

Roll src/third_party/depot_tools a68660d0bb5d..d91f0adca280 (2 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a68660d0bb5d..d91f0adca280


git log a68660d0bb5d..d91f0adca280 --date=short --no-merges --format='%ad %ae %s'
2018-09-10 nodir@google.com Reland "[bot_update] Stop using repository properties"
2018-09-10 recipe-roller@chromium.org Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/depot_tools@d91f0adca280

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:877161, chromium:694348 
TBR=agable@chromium.org

Change-Id: I06098b00b5b0e4dfa95e238d33730d8926ea4de7
Reviewed-on: https://chromium-review.googlesource.com/1216888
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#590025}
[modify] https://crrev.com/e775edd2af6cadc46e26dc632e9b1d0c20c40558/DEPS
Project Member

Comment 40 by bugdroid1@chromium.org, Sep 19 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/0f3f53268348610aa53081c0ffd9d7dc055e43fe

commit 0f3f53268348610aa53081c0ffd9d7dc055e43fe
Author: Nodir Turakulov <nodir@google.com>
Date: Wed Sep 19 21:40:08 2018
Project Member

Comment 41 by bugdroid1@chromium.org, Sep 19 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/c3fed2f651b147ed53feb96dc7bf92eb9d2d1093

commit c3fed2f651b147ed53feb96dc7bf92eb9d2d1093
Author: Oleh Prypin <oprypin@google.com>
Date: Wed Sep 19 21:41:59 2018
Project Member

Comment 42 by bugdroid1@chromium.org, Sep 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/recipes-py/+/ecba3385f199e9f9aecf783d7ce8d87c23775640

commit ecba3385f199e9f9aecf783d7ce8d87c23775640
Author: Nodir Turakulov <nodir@google.com>
Date: Wed Sep 19 21:47:32 2018

[buildbucket] Add bucket_v1 property

Add bucket_v1 property so that recipes can stop interpreting "buildbucket"
property directly.

Bug: 877161
Change-Id: Ia7728b6844b69f10de8e36280b7088bb08c13a07
Reviewed-on: https://chromium-review.googlesource.com/1234715
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/ecba3385f199e9f9aecf783d7ce8d87c23775640/README.recipes.md
[modify] https://crrev.com/ecba3385f199e9f9aecf783d7ce8d87c23775640/recipe_modules/buildbucket/api.py
[modify] https://crrev.com/ecba3385f199e9f9aecf783d7ce8d87c23775640/recipe_modules/buildbucket/tests/build.py
Project Member

Comment 44 by bugdroid1@chromium.org, Sep 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/a862144ef54c6908a0c81f52c1593a5ce5e2d908

commit a862144ef54c6908a0c81f52c1593a5ce5e2d908
Author: Nodir Turakulov <nodir@google.com>
Date: Wed Sep 19 22:25:02 2018

[pdfium] use new buildbucket api

Stop interpreting buildbucket property directly.

Bug: 877161
Change-Id: Ibfcafa654829ea19bb3a1ad22484297b1598643d
Reviewed-on: https://chromium-review.googlesource.com/1234588
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/a862144ef54c6908a0c81f52c1593a5ce5e2d908/scripts/slave/README.recipes.md
[modify] https://crrev.com/a862144ef54c6908a0c81f52c1593a5ce5e2d908/scripts/slave/recipes/pdfium.py
[modify] https://crrev.com/a862144ef54c6908a0c81f52c1593a5ce5e2d908/scripts/slave/recipes/pdfium.expected/try-linux-gerrit_xfa_asan_lsan.json
Project Member

Comment 45 by bugdroid1@chromium.org, Sep 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/86ecc33d0151a9c1b6dae53177107efdb759f328

commit 86ecc33d0151a9c1b6dae53177107efdb759f328
Author: Nodir Turakulov <nodir@google.com>
Date: Wed Sep 19 23:26:23 2018

[art] Use new buildbucket API

Stop using mastername and buildername

Bug: 877161
Change-Id: Ibd6088d1ef2162b7742763666ec01a035baf0589
Reviewed-on: https://chromium-review.googlesource.com/1234591
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[rename] https://crrev.com/86ecc33d0151a9c1b6dae53177107efdb759f328/scripts/slave/recipes/art.expected/host-x86-debug__noclobber.json
[rename] https://crrev.com/86ecc33d0151a9c1b6dae53177107efdb759f328/scripts/slave/recipes/art.expected/fugu-ndebug__clobber.json
[rename] https://crrev.com/86ecc33d0151a9c1b6dae53177107efdb759f328/scripts/slave/recipes/art.expected/aosp-builder-cms__clobber.json
[rename] https://crrev.com/86ecc33d0151a9c1b6dae53177107efdb759f328/scripts/slave/recipes/art.expected/volantis-armv8-poison-ndebug__clobber.json
[rename] https://crrev.com/86ecc33d0151a9c1b6dae53177107efdb759f328/scripts/slave/recipes/art.expected/host-x86-gcstress-debug__clobber.json
[rename] https://crrev.com/86ecc33d0151a9c1b6dae53177107efdb759f328/scripts/slave/recipes/art.expected/angler-armv8-generational-cc__clobber.json
[rename] https://crrev.com/86ecc33d0151a9c1b6dae53177107efdb759f328/scripts/slave/recipes/art.expected/angler-armv8-generational-cc__noclobber.json
[rename] https://crrev.com/86ecc33d0151a9c1b6dae53177107efdb759f328/scripts/slave/recipes/art.expected/host-x86_64-cms__clobber.json
[rename] https://crrev.com/86ecc33d0151a9c1b6dae53177107efdb759f328/scripts/slave/recipes/art.expected/host-x86-gcstress-debug__noclobber.json
[rename] https://crrev.com/86ecc33d0151a9c1b6dae53177107efdb759f328/scripts/slave/recipes/art.expected/host-x86_64-ndebug__clobber.json
[rename] https://crrev.com/86ecc33d0151a9c1b6dae53177107efdb759f328/scripts/slave/recipes/art.expected/bullhead-armv7-gcstress-ndebug__noclobber.json
[rename] https://crrev.com/86ecc33d0151a9c1b6dae53177107efdb759f328/scripts/slave/recipes/art.expected/host-x86_64-poison-debug__noclobber.json
[rename] https://crrev.com/86ecc33d0151a9c1b6dae53177107efdb759f328/scripts/slave/recipes/art.expected/volantis-armv7-poison-debug__clobber.json
[rename] https://crrev.com/86ecc33d0151a9c1b6dae53177107efdb759f328/scripts/slave/recipes/art.expected/angler-armv7-generational-cc__noclobber.json
[rename] https://crrev.com/86ecc33d0151a9c1b6dae53177107efdb759f328/scripts/slave/recipes/art.expected/aosp-builder-cc__noclobber.json
[rename] https://crrev.com/86ecc33d0151a9c1b6dae53177107efdb759f328/scripts/slave/recipes/art.expected/angler-armv8-debug__noclobber.json
[rename] https://crrev.com/86ecc33d0151a9c1b6dae53177107efdb759f328/scripts/slave/recipes/art.expected/angler-armv7-debug__noclobber.json
[rename] https://crrev.com/86ecc33d0151a9c1b6dae53177107efdb759f328/scripts/slave/recipes/art.expected/fugu-ndebug__noclobber.json
[rename] https://crrev.com/86ecc33d0151a9c1b6dae53177107efdb759f328/scripts/slave/recipes/art.expected/angler-armv7-debug__clobber.json
[rename] https://crrev.com/86ecc33d0151a9c1b6dae53177107efdb759f328/scripts/slave/recipes/art.expected/bullhead-armv7-gcstress-ndebug__clobber.json
[rename] https://crrev.com/86ecc33d0151a9c1b6dae53177107efdb759f328/scripts/slave/recipes/art.expected/host-x86-debug__clobber.json
[rename] https://crrev.com/86ecc33d0151a9c1b6dae53177107efdb759f328/scripts/slave/recipes/art.expected/fugu-debug__noclobber.json
[rename] https://crrev.com/86ecc33d0151a9c1b6dae53177107efdb759f328/scripts/slave/recipes/art.expected/volantis-armv8-poison-debug__clobber.json
[delete] https://crrev.com/a862144ef54c6908a0c81f52c1593a5ce5e2d908/scripts/slave/recipes/art.expected/OWNERS
[rename] https://crrev.com/86ecc33d0151a9c1b6dae53177107efdb759f328/scripts/slave/recipes/art.expected/host-x86_64-ndebug__noclobber.json
[rename] https://crrev.com/86ecc33d0151a9c1b6dae53177107efdb759f328/scripts/slave/recipes/art.expected/host-x86_64-cdex-fast__clobber.json
[rename] https://crrev.com/86ecc33d0151a9c1b6dae53177107efdb759f328/scripts/slave/recipes/art.expected/host-x86-cms__noclobber.json
[rename] https://crrev.com/86ecc33d0151a9c1b6dae53177107efdb759f328/scripts/slave/recipes/art.expected/host-x86_64-poison-debug__clobber.json
[rename] https://crrev.com/86ecc33d0151a9c1b6dae53177107efdb759f328/scripts/slave/recipes/art.expected/host-x86-poison-debug__noclobber.json
[rename] https://crrev.com/86ecc33d0151a9c1b6dae53177107efdb759f328/scripts/slave/recipes/art.expected/bullhead-armv8-gcstress-debug__clobber.json
[rename] https://crrev.com/86ecc33d0151a9c1b6dae53177107efdb759f328/scripts/slave/recipes/art.expected/bullhead-armv8-gcstress-debug__noclobber.json
[rename] https://crrev.com/86ecc33d0151a9c1b6dae53177107efdb759f328/scripts/slave/recipes/art.expected/aosp-builder-cms__noclobber.json
[rename] https://crrev.com/86ecc33d0151a9c1b6dae53177107efdb759f328/scripts/slave/recipes/art.expected/bullhead-armv8-gcstress-ndebug__clobber.json
[rename] https://crrev.com/86ecc33d0151a9c1b6dae53177107efdb759f328/scripts/slave/recipes/art.expected/volantis-armv8-poison-ndebug__noclobber.json
[rename] https://crrev.com/86ecc33d0151a9c1b6dae53177107efdb759f328/scripts/slave/recipes/art.expected/volantis-armv7-poison-debug__noclobber.json
[rename] https://crrev.com/86ecc33d0151a9c1b6dae53177107efdb759f328/scripts/slave/recipes/art.expected/angler-armv8-ndebug__noclobber.json
[rename] https://crrev.com/86ecc33d0151a9c1b6dae53177107efdb759f328/scripts/slave/recipes/art.expected/fugu-debug__clobber.json
[modify] https://crrev.com/86ecc33d0151a9c1b6dae53177107efdb759f328/scripts/slave/recipes/art.py
[rename] https://crrev.com/86ecc33d0151a9c1b6dae53177107efdb759f328/scripts/slave/recipes/art.expected/bullhead-armv8-gcstress-ndebug__noclobber.json
[rename] https://crrev.com/86ecc33d0151a9c1b6dae53177107efdb759f328/scripts/slave/recipes/art.expected/aosp-builder-cc__clobber.json
[rename] https://crrev.com/86ecc33d0151a9c1b6dae53177107efdb759f328/scripts/slave/recipes/art.expected/angler-armv8-ndebug__clobber.json
[rename] https://crrev.com/86ecc33d0151a9c1b6dae53177107efdb759f328/scripts/slave/recipes/art.expected/angler-armv7-ndebug__clobber.json
[rename] https://crrev.com/86ecc33d0151a9c1b6dae53177107efdb759f328/scripts/slave/recipes/art.expected/angler-armv7-ndebug__noclobber.json
[rename] https://crrev.com/86ecc33d0151a9c1b6dae53177107efdb759f328/scripts/slave/recipes/art.expected/host-x86-ndebug__clobber.json
[rename] https://crrev.com/86ecc33d0151a9c1b6dae53177107efdb759f328/scripts/slave/recipes/art.expected/host-x86_64-debug__clobber.json
[rename] https://crrev.com/86ecc33d0151a9c1b6dae53177107efdb759f328/scripts/slave/recipes/art.expected/host-x86_64-cdex-fast__noclobber.json
[rename] https://crrev.com/86ecc33d0151a9c1b6dae53177107efdb759f328/scripts/slave/recipes/art.expected/angler-armv8-debug__clobber.json
[rename] https://crrev.com/86ecc33d0151a9c1b6dae53177107efdb759f328/scripts/slave/recipes/art.expected/host-x86_64-debug__noclobber.json
[modify] https://crrev.com/86ecc33d0151a9c1b6dae53177107efdb759f328/scripts/slave/README.recipes.md
[rename] https://crrev.com/86ecc33d0151a9c1b6dae53177107efdb759f328/scripts/slave/recipes/art.expected/volantis-armv8-poison-debug__noclobber.json
[rename] https://crrev.com/86ecc33d0151a9c1b6dae53177107efdb759f328/scripts/slave/recipes/art.expected/host-x86-cms__clobber.json
[rename] https://crrev.com/86ecc33d0151a9c1b6dae53177107efdb759f328/scripts/slave/recipes/art.expected/angler-armv7-generational-cc__clobber.json
[rename] https://crrev.com/86ecc33d0151a9c1b6dae53177107efdb759f328/scripts/slave/recipes/art.expected/host-x86_64-generational-cc__noclobber.json
[rename] https://crrev.com/86ecc33d0151a9c1b6dae53177107efdb759f328/scripts/slave/recipes/art.expected/host-x86_64-cms__noclobber.json
[rename] https://crrev.com/86ecc33d0151a9c1b6dae53177107efdb759f328/scripts/slave/recipes/art.expected/host-x86-ndebug__noclobber.json
[rename] https://crrev.com/86ecc33d0151a9c1b6dae53177107efdb759f328/scripts/slave/recipes/art.expected/host-x86_64-generational-cc__clobber.json
[rename] https://crrev.com/86ecc33d0151a9c1b6dae53177107efdb759f328/scripts/slave/recipes/art.expected/host-x86-poison-debug__clobber.json
Project Member

Comment 46 by bugdroid1@chromium.org, Sep 20 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/1106adc95fcae7d1c7f9b7489501a2a4f080d49d

commit 1106adc95fcae7d1c7f9b7489501a2a4f080d49d
Author: Nodir Turakulov <nodir@google.com>
Date: Thu Sep 20 13:40:48 2018
Project Member

Comment 47 by bugdroid1@chromium.org, Sep 20 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/8f789d24324a1879a4517cf510b3836755ef106c

commit 8f789d24324a1879a4517cf510b3836755ef106c
Author: Oleh Prypin <oprypin@google.com>
Date: Thu Sep 20 13:43:49 2018
Project Member

Comment 48 by bugdroid1@chromium.org, Sep 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/recipes-py/+/673743d3e861ad9c6d9a8cc71088f4be7d01a1bb

commit 673743d3e861ad9c6d9a8cc71088f4be7d01a1bb
Author: Nodir Turakulov <nodir@google.com>
Date: Thu Sep 20 21:13:00 2018

[buildbucket] add builder_name

Add a shortcut for api.buildbucket.build.builder.builder

R=tandrii@chromium.org

Bug: 877161
Change-Id: I0643a81bfb37eb396d88ef7fa2ffcc6964d1b70b
Reviewed-on: https://chromium-review.googlesource.com/1237193
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/673743d3e861ad9c6d9a8cc71088f4be7d01a1bb/recipe_modules/buildbucket/api.py
[modify] https://crrev.com/673743d3e861ad9c6d9a8cc71088f4be7d01a1bb/recipe_modules/buildbucket/tests/build.py

Comment 49 by no...@chromium.org, Sep 20

Description: Show this description

Comment 50 by no...@chromium.org, Sep 20 

narrowed down the bug to exclude buildername migration. That's hard.
Project Member

Comment 51 by bugdroid1@chromium.org, Sep 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/recipes-py/+/39df254c20b7052fed669e3319036b20f96e75e3

commit 39df254c20b7052fed669e3319036b20f96e75e3
Author: Nodir Turakulov <nodir@google.com>
Date: Thu Sep 20 21:39:38 2018

[buildbucket] Fix typo.

TBR=tandrii@chromium.org

Bug: 877161
Change-Id: Ib3ce4a953f0a9ac3480acb238ae77f69fcf4fea0
Reviewed-on: https://chromium-review.googlesource.com/1237194
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/39df254c20b7052fed669e3319036b20f96e75e3/README.recipes.md
[modify] https://crrev.com/39df254c20b7052fed669e3319036b20f96e75e3/recipe_modules/buildbucket/api.py
Project Member

Comment 52 by bugdroid1@chromium.org, Sep 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/a9397127d23fa44ae683e2d4261769b7edbdefb6

commit a9397127d23fa44ae683e2d4261769b7edbdefb6
Author: Nodir Turakulov <nodir@google.com>
Date: Thu Sep 20 22:23:57 2018

Use api.buildbucket.builder_name shortcut

R=tandrii@chromium.org

Bug: 877161
Change-Id: Ie277d6f396cbe38e62f220252634710b7471f8bd
Reviewed-on: https://chromium-review.googlesource.com/1236543
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/a9397127d23fa44ae683e2d4261769b7edbdefb6/scripts/slave/recipe_modules/goma/api.py
[modify] https://crrev.com/a9397127d23fa44ae683e2d4261769b7edbdefb6/scripts/slave/recipes/art.py
Project Member

Comment 54 by bugdroid1@chromium.org, Sep 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/recipes-py/+/66dfa7cca67be5376d6cb54b462e9ccd832e4f01

commit 66dfa7cca67be5376d6cb54b462e9ccd832e4f01
Author: Nodir Turakulov <nodir@google.com>
Date: Thu Sep 20 22:34:31 2018

[buildbucket] Add gitiles_commit shortcut

R=tandrii@chromium.org

Bug: 877161
Change-Id: Ifb02a2c488affb49d501c3fd310442fc5eb1ecf3
Reviewed-on: https://chromium-review.googlesource.com/1237195
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Auto-Submit: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/66dfa7cca67be5376d6cb54b462e9ccd832e4f01/README.recipes.md
[modify] https://crrev.com/66dfa7cca67be5376d6cb54b462e9ccd832e4f01/recipe_modules/buildbucket/api.py
[modify] https://crrev.com/66dfa7cca67be5376d6cb54b462e9ccd832e4f01/recipe_modules/buildbucket/tests/build.py
Project Member

Comment 55 by bugdroid1@chromium.org, Sep 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/7e301cfffe7fe9e1f912ecfcf0624e0fbded7517

commit 7e301cfffe7fe9e1f912ecfcf0624e0fbded7517
Author: Nodir Turakulov <nodir@google.com>
Date: Thu Sep 20 23:01:57 2018

[gclient] Use canonical URLs in solutions

Strip ".git" suffix from all solution URLs.

Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: release_scripts
Bug: 877161
Change-Id: I0cb9cc512fdd9cc5e53ade6bc1d725dc84f7563d
Reviewed-on: https://chromium-review.googlesource.com/1237332
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/7e301cfffe7fe9e1f912ecfcf0624e0fbded7517/recipes/recipe_modules/gclient/config.py
[modify] https://crrev.com/7e301cfffe7fe9e1f912ecfcf0624e0fbded7517/recipes/recipes/fetch_end_to_end_test.expected/basic.json
Project Member

Comment 56 by bugdroid1@chromium.org, Sep 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/92df4e63abbe9ffe24ff632927acea5523112aeb

commit 92df4e63abbe9ffe24ff632927acea5523112aeb
Author: Nodir Turakulov <nodir@chromium.org>
Date: Fri Sep 21 00:22:59 2018

Revert "[gclient] Use canonical URLs in solutions"

This reverts commit 7e301cfffe7fe9e1f912ecfcf0624e0fbded7517.

Reason for revert: internal builds failed, e.g. bugdroid

Original change's description:
> [gclient] Use canonical URLs in solutions
> 
> Strip ".git" suffix from all solution URLs.
> 
> Recipe-Nontrivial-Roll: build
> Recipe-Nontrivial-Roll: build_limited_scripts_slave
> Recipe-Nontrivial-Roll: infra
> Recipe-Nontrivial-Roll: release_scripts
> Bug: 877161
> Change-Id: I0cb9cc512fdd9cc5e53ade6bc1d725dc84f7563d
> Reviewed-on: https://chromium-review.googlesource.com/1237332
> Reviewed-by: Stephen Martinis <martiniss@chromium.org>
> Commit-Queue: Nodir Turakulov <nodir@chromium.org>

TBR=nodir@chromium.org,tandrii@chromium.org,martiniss@chromium.org,jbudorick@chromium.org

Change-Id: Ie24e10844ceb89071c9e665f2aa7dde9f9bf6e6c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 877161
Reviewed-on: https://chromium-review.googlesource.com/1237423
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/92df4e63abbe9ffe24ff632927acea5523112aeb/recipes/recipe_modules/gclient/config.py
[modify] https://crrev.com/92df4e63abbe9ffe24ff632927acea5523112aeb/recipes/recipes/fetch_end_to_end_test.expected/basic.json
Project Member

Comment 57 by bugdroid1@chromium.org, Sep 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/113516ef81fce9a3d6c0f8505af24f7146aefd0a

commit 113516ef81fce9a3d6c0f8505af24f7146aefd0a
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Fri Sep 21 00:39:50 2018

Roll src/third_party/depot_tools 0c22dec277af..7e301cfffe7f (2 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0c22dec277af..7e301cfffe7f


git log 0c22dec277af..7e301cfffe7f --date=short --no-merges --format='%ad %ae %s'
2018-09-20 nodir@google.com [gclient] Use canonical URLs in solutions
2018-09-20 recipe-roller@chromium.org Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/depot_tools@7e301cfffe7f

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:877161
TBR=agable@chromium.org

Change-Id: I7ef130a75c80922136ed2ef11732730b0b890ff0
Reviewed-on: https://chromium-review.googlesource.com/1236472
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#593023}
[modify] https://crrev.com/113516ef81fce9a3d6c0f8505af24f7146aefd0a/DEPS
Project Member

Comment 58 by bugdroid1@chromium.org, Sep 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bcbe1a6c13b714197b3f558ecc429625a210c400

commit bcbe1a6c13b714197b3f558ecc429625a210c400
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Fri Sep 21 02:00:40 2018

Roll src/third_party/depot_tools 7e301cfffe7f..92df4e63abbe (1 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7e301cfffe7f..92df4e63abbe


git log 7e301cfffe7f..92df4e63abbe --date=short --no-merges --format='%ad %ae %s'
2018-09-21 nodir@chromium.org Revert "[gclient] Use canonical URLs in solutions"


Created with:
  gclient setdep -r src/third_party/depot_tools@92df4e63abbe

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:877161
TBR=agable@chromium.org

Change-Id: I3b1defe71f7dadcec0a362b2d4b8cd4b36378896
Reviewed-on: https://chromium-review.googlesource.com/1237475
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#593049}
[modify] https://crrev.com/bcbe1a6c13b714197b3f558ecc429625a210c400/DEPS
Project Member

Comment 59 by bugdroid1@chromium.org, Sep 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/4dd58cdd8c544dc46167ff768d3f62d3533ec7dc

commit 4dd58cdd8c544dc46167ff768d3f62d3533ec7dc
Author: Nodir Turakulov <nodir@google.com>
Date: Fri Sep 21 16:58:13 2018

Use new recipe API

Update infra.git recipes to use new APIs.
This CL finishes the migration for infra.git

Bug:  694348 , 877161
Change-Id: I35083402166c912d46796824592df64791ad7e2f
Reviewed-on: https://chromium-review.googlesource.com/1237329
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#17792}
[modify] https://crrev.com/4dd58cdd8c544dc46167ff768d3f62d3533ec7dc/recipes/recipes/luci_py.expected/ci.json
[modify] https://crrev.com/4dd58cdd8c544dc46167ff768d3f62d3533ec7dc/recipes/recipes/luci_py.py
[modify] https://crrev.com/4dd58cdd8c544dc46167ff768d3f62d3533ec7dc/recipes/recipes/master_manager_config.py
[modify] https://crrev.com/4dd58cdd8c544dc46167ff768d3f62d3533ec7dc/recipes/recipes/recipe_simulation.py
[modify] https://crrev.com/4dd58cdd8c544dc46167ff768d3f62d3533ec7dc/recipes/recipes/master_manager_config.expected/master_manager_config.json
[modify] https://crrev.com/4dd58cdd8c544dc46167ff768d3f62d3533ec7dc/recipes/README.recipes.md
[modify] https://crrev.com/4dd58cdd8c544dc46167ff768d3f62d3533ec7dc/recipes/recipes/master_manager_config.expected/master_manager_config_patch.json
[modify] https://crrev.com/4dd58cdd8c544dc46167ff768d3f62d3533ec7dc/recipes/recipes/infra_continuous.py
Project Member

Comment 60 by bugdroid1@chromium.org, Sep 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/recipes-py/+/d5fd7cc14d7f0a82d1358617f1ec94c4417ec85e

commit d5fd7cc14d7f0a82d1358617f1ec94c4417ec85e
Author: Nodir Turakulov <nodir@google.com>
Date: Fri Sep 21 21:23:14 2018

[buildbucket] Split try_build/ci_build

Some clients need to mock a ci/try build, but also need to configured it more
than what ci_build and try_build do. For example, webrtc need to specify
created_by and chromeos needs to specify build number.

Split the functions into two: one that makes a message and one that is merely
a shortcut for calling api.buildbucket.build with the mocked build.

Bug: 877161
Change-Id: I64f3faa81336afeba6e08e5c51bc0eae7d771ca1
Reviewed-on: https://chromium-review.googlesource.com/1238948
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/d5fd7cc14d7f0a82d1358617f1ec94c4417ec85e/recipe_modules/buildbucket/test_api.py
Project Member

Comment 61 by bugdroid1@chromium.org, Sep 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/2119a47dc18c25b8fe888b0f43a3b10b2bbc466e

commit 2119a47dc18c25b8fe888b0f43a3b10b2bbc466e
Author: Nodir Turakulov <nodir@google.com>
Date: Sat Sep 22 05:39:32 2018

Stop using buildername property

Update recipes to use api.buildbucket.builder_name instead of
buildername property

Bug: 877161
Change-Id: If5200a9ded2bc06732a09ec308e71701c326b5dc
Reviewed-on: https://chromium-review.googlesource.com/1235138
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#17814}
[modify] https://crrev.com/2119a47dc18c25b8fe888b0f43a3b10b2bbc466e/recipes/recipes/recipes_py_continuous.expected/basic.json
[modify] https://crrev.com/2119a47dc18c25b8fe888b0f43a3b10b2bbc466e/recipes/recipes/gerrit_cq_test.expected/try-experimental.json
[modify] https://crrev.com/2119a47dc18c25b8fe888b0f43a3b10b2bbc466e/recipes/recipe_modules/sync_submodules/api.py
[modify] https://crrev.com/2119a47dc18c25b8fe888b0f43a3b10b2bbc466e/recipes/recipe_modules/sync_submodules/__init__.py
[modify] https://crrev.com/2119a47dc18c25b8fe888b0f43a3b10b2bbc466e/recipes/recipe_modules/windows_sdk/examples/full.py
[modify] https://crrev.com/2119a47dc18c25b8fe888b0f43a3b10b2bbc466e/recipes/recipes/lkgr_finder.py
[modify] https://crrev.com/2119a47dc18c25b8fe888b0f43a3b10b2bbc466e/recipes/recipes/recipes_py_continuous.py
[modify] https://crrev.com/2119a47dc18c25b8fe888b0f43a3b10b2bbc466e/recipes/README.recipes.md
[modify] https://crrev.com/2119a47dc18c25b8fe888b0f43a3b10b2bbc466e/recipes/recipes/build_conda_cipd_pkg.py
[modify] https://crrev.com/2119a47dc18c25b8fe888b0f43a3b10b2bbc466e/recipes/recipes/gerrit_cq_test.py
[modify] https://crrev.com/2119a47dc18c25b8fe888b0f43a3b10b2bbc466e/recipes/recipes/gerrit_cq_test.expected/try.json

Comment 62 by no...@chromium.org, Sep 24

Description: Show this description

Comment 63 by no...@chromium.org, Sep 24

Blocking: -875056

Comment 64 by no...@chromium.org, Sep 24 

i gave up (after 57 CLs). I did the heavy lifting though (updated bot_update, etc). What remains is manual updates of individual recipes and recipe modules that have some basic logic based on the deprecated properties. They should be trivially switched to new API. Here is a CL that does this kind of work in all recipes of infra.git https://chromium-review.googlesource.com/c/infra/infra/+/1237329
we need similar changes in all recipes of build.git

Another large, but less important piece of work is to update recipe tests that use outdated properties, e.g.
  api.test("basic") + properties.tryserver(.....)
these should switch to api.buildbucket.try_build

it is less important because nothing will break if this is not done. The buildbucket module has support for legacy properties for backward compatibility.
-----------

this is a large set of simple small changes in a large set of files, owned by different people/teams. I think it will be more effective to crowd source this work.

Comment 65 by tandrii@chromium.org, Sep 24 

> I think it will be more effective to crowd source this work. 

Perhaps send a PSA to owners and include list of deprecated stuff and example of change you've made for each?
Project Member

Comment 67 by bugdroid1@chromium.org, Jan 4 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/9bcc8bbefa4add27f9a5a6cf0038975e5076bd95

commit 9bcc8bbefa4add27f9a5a6cf0038975e5076bd95
Author: Nodir Turakulov <nodir@google.com>
Date: Fri Jan 04 23:30:37 2019
►

Sign in to add a comment