New issue
Advanced search Search tips

Issue 877148 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 22
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Roll out the 8.0 filter list

Project Member Reported by jkarlin@chromium.org, Aug 23

Issue description

Update to the smaller 8.0 filter list.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/825da604d1333757aaf6988200909104ab9d0c25

commit 825da604d1333757aaf6988200909104ab9d0c25
Author: Josh Karlin <jkarlin@chromium.org>
Date: Fri Aug 24 13:25:04 2018

Use the 8.0 filter list in perf tests.

The 8.0 list is comprised of the top 1000 rules used from easylist version
201808030717 when run against HttpArchive's July 15th of 2018 list of page
requests.

Bug:  877148 
Change-Id: Ib43639379c1f8b6abeea416345dd3b9468b0354f
Reviewed-on: https://chromium-review.googlesource.com/1187069
Commit-Queue: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585817}
[delete] https://crrev.com/fb6c2123f63604dba725da94e68a7b679a20ffff/components/subresource_filter/core/common/perftests/data/UnindexedRules_7.54
[add] https://crrev.com/825da604d1333757aaf6988200909104ab9d0c25/components/subresource_filter/core/common/perftests/data/UnindexedRules_8.0
[modify] https://crrev.com/825da604d1333757aaf6988200909104ab9d0c25/components/subresource_filter/core/common/perftests/indexed_ruleset_perftest.cc
[modify] https://crrev.com/825da604d1333757aaf6988200909104ab9d0c25/components/subresource_filter/tools/BUILD.gn

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c48db1834a419b83e8281fae828cfd6a1978a040

commit c48db1834a419b83e8281fae828cfd6a1978a040
Author: Josh Karlin <jkarlin@chromium.org>
Date: Fri Aug 24 17:49:49 2018

[AdTagging] Enable AdTagging field trial on bots

Bug:  877148 
Change-Id: I757fa7363dd11f4c2db534fc7dbc3b46174a623f
Reviewed-on: https://chromium-review.googlesource.com/1188602
Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Commit-Queue: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585900}
[modify] https://crrev.com/c48db1834a419b83e8281fae828cfd6a1978a040/testing/variations/fieldtrial_testing_config.json

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18154b98b420c311f2a28c7f17f7f007ab602264

commit 18154b98b420c311f2a28c7f17f7f007ab602264
Author: Josh Karlin <jkarlin@chromium.org>
Date: Tue Aug 28 14:36:02 2018

[AdTagging] Update the filter list generation doc

We're now running against the entire HttpArchive corpus of pages instead
of just the top X sites. We then select the top 1000 rules from the result.

Bug:  877148 

Change-Id: I4a19e416592e9f1be12b2371feb6805746d4aee9
Reviewed-on: https://chromium-review.googlesource.com/1191902
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586689}
[modify] https://crrev.com/18154b98b420c311f2a28c7f17f7f007ab602264/components/subresource_filter/FILTER_LIST_GENERATION.md

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4d9a948a3882a64f6d164091ab29b7c8eecf3d5

commit f4d9a948a3882a64f6d164091ab29b7c8eecf3d5
Author: Josh Karlin <jkarlin@chromium.org>
Date: Tue Aug 28 14:49:06 2018

[AdTagging] Make a filter tool test deterministic

The MatchRules test had non-deterministic sorting behavior on
different platforms. Fix this by avoiding situations in the test where
there are ties for the number of matches.

Bug:  878328 ,  877148 
Change-Id: I4883141c0c5c8ab02ace9365b4a446f132d6cea1
Reviewed-on: https://chromium-review.googlesource.com/1193902
Commit-Queue: Josh Karlin <jkarlin@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586697}
[modify] https://crrev.com/f4d9a948a3882a64f6d164091ab29b7c8eecf3d5/components/subresource_filter/tools/filter_tool_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment