New issue
Advanced search Search tips

Issue 877136 link

Starred by 1 user
Status: Fixed
Owner:
bsazonov@chromium.org
Closed: Aug 24
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

[Android] parent_accounts text is misaligned on some Android versions

Project Member Reported by bsazonov@chromium.org, Aug 23 
While fixing issue 864806, I've realized that in AccountManagementFragment TextView that shows information about custodian accounts is sometimes misaligned, because preference layout paddings are different for different Android versions and device qualifiers.
Attaching screenshot from Nexus 5 with Android K.
Screenshot_Nexus_5_2018-08-23_19:55:11.png
223 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef74bd21b44979cba3988608b2e64c1c38d60003

commit ef74bd21b44979cba3988608b2e64c1c38d60003
Author: Boris Sazonov <bsazonov@chromium.org>
Date: Fri Aug 24 08:57:58 2018

[Android] Fix parent_accounts alignment in AccountManagementFragment

This CL reimplements parent_accounts preference row in
AccountManagementFragment to fix alignment issues on older Android
versions. Instead of providing custom preference layout via aapt:attr,
TextMessagePreference is used. This CL also specifies child_content
selectability in XML file.

Bug:  877136 
Change-Id: I2428c693d3f688b33b6c727df0210465f1ab37d7
Reviewed-on: https://chromium-review.googlesource.com/1187153
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585767}
[modify] https://crrev.com/ef74bd21b44979cba3988608b2e64c1c38d60003/chrome/android/java/res/xml/account_management_preferences.xml
[modify] https://crrev.com/ef74bd21b44979cba3988608b2e64c1c38d60003/chrome/android/java/src/org/chromium/chrome/browser/signin/AccountManagementFragment.java

Comment 2 by bsazonov@chromium.org, Aug 24

Labels: Hotlist-Polish
Status: Fixed (was: Started)
►

Sign in to add a comment