New issue
Advanced search Search tips

Issue 877129 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 27
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Flaky-Test: AppWindowApiTest.Get



Sign in to add a comment

AppWindowApiTest.Get#testGetAllMultipleWindows is Flaky

Project Member Reported by Findit, Aug 23

Issue description

Cc: hablich@chromium.org
Find it blame https://chromium-review.googlesource.com/q/If28b44c49821e7aa66b03e5914af56690635d47e with 70% confidence
hablich@ how likely is it to be actually related to the flake?
 Issue 877103  has been merged into this issue.
Cc: -hablich@chromium.org
Labels: -Sheriff-Chromium
Owner: hablich@chromium.org
Status: Assigned (was: Available)
Cc: sigurds@chromium.org hablich@chromium.org
Owner: mslekova@chromium.org
How do we find which tests are suddenly flaking? I can't find a link on the flakyness report.
Cc: st...@chromium.org pras...@chromium.org
stgao and prasadv regarding my questions in #4.
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72d904599b90ad466cd8fbb602fe07f93125a69c

commit 72d904599b90ad466cd8fbb602fe07f93125a69c
Author: John Budorick <jbudorick@chromium.org>
Date: Fri Aug 24 15:22:43 2018

Disable AppWindowApiTest.Get on CrOS.

TBR=tapted@chromium.org

Bug:  877129 
Change-Id: I86a6136f304f5dde483c9b778ed1a8d058090294
Reviewed-on: https://chromium-review.googlesource.com/1187828
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585845}
[modify] https://crrev.com/72d904599b90ad466cd8fbb602fe07f93125a69c/extensions/browser/api/app_window/app_window_apitest.cc

Cc: -pras...@chromium.org liaoyuke@chromium.org
This flaky test is detected by try-flakes
http://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyHwsSBUZsYWtlIhRBcHBXaW5kb3dBcGlUZXN0LkdldAw&show_all=1


+liaoyuke@ who is working on the new flake detection. The culprit finding analysis is done by Findit.
Labels: Sheriff-Chromium
Detected 6 new flakes for test/step "AppWindowApiTest.Get". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyHwsSBUZsYWtlIhRBcHBXaW5kb3dBcGlUZXN0LkdldAw. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Detected 4 new flakes for test/step "AppWindowApiTest.Get". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyHwsSBUZsYWtlIhRBcHBXaW5kb3dBcGlUZXN0LkdldAw. This message was posted automatically by the chromium-try-flakes app.
Summary: AppWindowApiTest.Get#testGetAllMultipleWindows is Flaky (was: AppWindowApiTest.Get is Flaky)
This is failing on Desktop Linux as well.

[24884:24884:0826/154854.667920:INFO:CONSOLE(0)] "[FAIL] testGetAllMultipleWindows: API Test Error in testGetAllMultipleWindows
Actual: [{"innerBounds":{},"outerBounds":{}},{"innerBounds":{},"outerBounds":{}}]
Expected: [{"innerBounds":{},"outerBounds":{}},{"innerBounds":{},"outerBounds":{}}]
Error
    at extensions::test:238:20
    at chrome-extension://becmopefkbfeioflekbepmkcmcnmkhmn/background.js:35:27", source: chrome-extension://becmopefkbfeioflekbepmkcmcnmkhmn/_generated_background_page.html (0)
[24884:24884:0826/154854.668316:INFO:CONSOLE(138)] "Uncaught chrome.test.failure", source: extensions::test (138)


the equality test is failing, although it's not clear why from the output.

    function testGetAllMultipleWindows() {
      chrome.app.window.create('index.html', {id: 'win1'}, function(win1) {
        win1.contentWindow.addEventListener('load', function() {
          chrome.app.window.create('index.html', {id: 'win2'}, function(win2) {
            win2.contentWindow.addEventListener('load', function() {
              var windows = chrome.app.window.getAll().sort(compareId);
              chrome.test.assertEq([win1, win2], windows);


Cc: mslekova@chromium.org
Owner: tapted@chromium.org
So.. that test should never have worked. |windows| is actually [win2, win1] since the comparator being passed to sort is using > instead of <.

fix - https://chromium-review.googlesource.com/c/chromium/src/+/1188727
Status: Started (was: Assigned)
Project Member

Comment 13 by bugdroid1@chromium.org, Aug 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f631db2c2d9598a2bfe3233068bf567966536100

commit f631db2c2d9598a2bfe3233068bf567966536100
Author: Trent Apted <tapted@chromium.org>
Date: Mon Aug 27 03:12:19 2018

Fix/Deflake AppWindowApiTest.Get

Equality for chrome.app.window.AppWindow objects is not well-defined.
In fact, testGetAllMultipleWindows was passing even though it was
comparing arrays in different orders.

Fix the tests by comparing the `id` property of the objects.

Bug:  877129 
Change-Id: I1a262b5f17c97320f9602f5d4251a044ec49220e
Reviewed-on: https://chromium-review.googlesource.com/1188727
Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586185}
[modify] https://crrev.com/f631db2c2d9598a2bfe3233068bf567966536100/chrome/test/data/extensions/platform_apps/windows_api_get/background.js
[modify] https://crrev.com/f631db2c2d9598a2bfe3233068bf567966536100/extensions/browser/api/app_window/app_window_apitest.cc

Status: Fixed (was: Started)

Sign in to add a comment