Allow controlling Chrome Reporting with Chrome policies |
||
Issue descriptionWe should have Chrome policies to for the Chrome Reporting Extension, to control what gets reported. We want the 4 following policies from the extension: - report_version_data: for OS and Chrome version data - report_policy_data: for policy data and policy fetch timestamps - report_machine_id_data: for data that can identify machines - report_user_id_data: for data that can identify users The policies should use the extension policy as a fallback, if they are unset. We can do this in 3 steps: 1. Add the 4 policies, map them to prefs, and register the prefs. 2. Respect the prefs in the enterprise_reporting private API [1]. 3. Add an ExtensionPolicyMigrator [2] to use the extension's policy as a fallback, if set. [1] https://cs.chromium.org/chromium/src/chrome/browser/extensions/api/enterprise_reporting_private/enterprise_reporting_private_api.cc [2] https://docs.google.com/document/d/1_ZxQ4Rc7RIGT4NOfjhdaJJ2gSJCZIHgcwCOumjYD0Cs/edit
,
Aug 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a1824089ea567a37ccbd005da851004008c10b14 commit a1824089ea567a37ccbd005da851004008c10b14 Author: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Date: Tue Aug 28 18:38:11 2018 Implement Enterprise Reporting policies Makes the Enterprise Reporting policies from a previous CL [1] effective. They now really control what gets reported and what doesn't, instead of just serving as placeholders. [1] https://chromium-review.googlesource.com/1187066 Bug: 877120 Change-Id: I5098e55ce337fd3e8a5a56fc98bdc08d105b6a86 Reviewed-on: https://chromium-review.googlesource.com/1190542 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by: Owen Min <zmin@chromium.org> Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#586797} [modify] https://crrev.com/a1824089ea567a37ccbd005da851004008c10b14/chrome/browser/extensions/api/enterprise_reporting_private/chrome_desktop_report_request_helper.cc [modify] https://crrev.com/a1824089ea567a37ccbd005da851004008c10b14/chrome/browser/extensions/api/enterprise_reporting_private/chrome_desktop_report_request_helper_unittest.cc
,
Aug 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/808ee09c1dffa440178ad98a0cd99b27165233ad commit 808ee09c1dffa440178ad98a0cd99b27165233ad Author: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Date: Wed Aug 29 15:52:46 2018 Add policy migrator for Chrome Reporting Extension This ExtensionPolicyMigrator uses the CRE's existing policies as a fallback. That way, existing setups that set those policies will be more compatible with the new version of Enterprise Reporting. Bug: 877120 Change-Id: I6e8b8e46450ea8e3ed8e073e7b3a8c545864f0e3 Reviewed-on: https://chromium-review.googlesource.com/1191743 Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by: Owen Min <zmin@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#587131} [modify] https://crrev.com/808ee09c1dffa440178ad98a0cd99b27165233ad/chrome/browser/extensions/BUILD.gn [add] https://crrev.com/808ee09c1dffa440178ad98a0cd99b27165233ad/chrome/browser/extensions/api/enterprise_reporting_private/enterprise_reporting_policy_migrator.cc [add] https://crrev.com/808ee09c1dffa440178ad98a0cd99b27165233ad/chrome/browser/extensions/api/enterprise_reporting_private/enterprise_reporting_policy_migrator.h [add] https://crrev.com/808ee09c1dffa440178ad98a0cd99b27165233ad/chrome/browser/extensions/api/enterprise_reporting_private/enterprise_reporting_policy_migrator_unittest.cc [modify] https://crrev.com/808ee09c1dffa440178ad98a0cd99b27165233ad/chrome/browser/policy/chrome_browser_policy_connector.cc [modify] https://crrev.com/808ee09c1dffa440178ad98a0cd99b27165233ad/chrome/browser/policy/configuration_policy_handler_list_factory.cc [modify] https://crrev.com/808ee09c1dffa440178ad98a0cd99b27165233ad/chrome/test/BUILD.gn
,
Aug 29
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Aug 28