New issue
Advanced search Search tips

Issue 877118 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Nov 5
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Fix black-listed browser_tests for single-process-mash

Project Member Reported by rcui@chromium.org, Aug 23

Issue description

CL https://chromium-review.googlesource.com/c/chromium/src/+/1185637 adds single-process-mash browser tests to the FYI waterfall.  Some tests are disabled via the filter file.  This bug tracks fixing the failing tests.
 
Labels: -Pri-3 Pri-2
 Bug 883296  seems a bit related. Adding it here for visibility.
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a612d699fc5fa699bab6e8557f16372af4a5190d

commit a612d699fc5fa699bab6e8557f16372af4a5190d
Author: James Cook <jamescook@chromium.org>
Date: Thu Oct 18 20:29:00 2018

chromeos: Fix DeviceLocalAccountTest under SingleProcessMash

Window close events are sent over mojo between browser and ash. The
test needs to wait for in-flight messages to complete before making
assertions about the state of ash.

Also fix a problem where the window delete message wasn't being sent
by WindowTreeClient.

Bug:  877118 
Test: DeviceLocalAccountTest.LastWindowClosedLogoutReminder
Change-Id: I43145c8140462428a7db050489593038745c8f94
Reviewed-on: https://chromium-review.googlesource.com/c/1284059
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600886}
[modify] https://crrev.com/a612d699fc5fa699bab6e8557f16372af4a5190d/chrome/browser/chromeos/policy/device_local_account_browsertest.cc
[modify] https://crrev.com/a612d699fc5fa699bab6e8557f16372af4a5190d/testing/buildbot/filters/chromeos.single_process_mash.browser_tests.filter
[modify] https://crrev.com/a612d699fc5fa699bab6e8557f16372af4a5190d/ui/aura/mus/window_tree_client.cc

Status: WontFix (was: Untriaged)
There are bugs filed for individual failures, so I'm closing this one out.

Sign in to add a comment