[blink-gen-property-trees] Scroll snap data missing for BGPT |
||||
Issue description
Add tracing info to ScrollNode::AsValueInto
if (snap_container_data) {
std::string s = "rect " + snap_container_data->rect().ToString() +
" max " + snap_container_data->max_position().ToString();
value->SetString("snap_container_data", s);
}
Run chromium with "--vmodule=layer_tree_host=3" or "--enable-blink-gen-property-trees --vmodule=layer_tree_host=3" compare the scroll tree output.
failing test:
- fast/scroll-snap/snap-scrolls-visual-viewport.html
,
Aug 23
,
Aug 23
,
Aug 29
After I add the snap data to scroll node. fast/scroll-snap/snap-scrolls-visual-viewport.html still fails. Should be a separate issue. create a new issue for it crbug.com/878904 .
,
Aug 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9d834f393e035b7dab36e7985d830eaab7dfca8b commit 9d834f393e035b7dab36e7985d830eaab7dfca8b Author: chaopeng <chaopeng@chromium.org> Date: Thu Aug 30 18:53:06 2018 [BlinkGenPropertyTrees] Add scroll snap data for BGPT This CL add the scroll snap data to ScrollNode for BGPT. I manually tested scroll snap. TEST=fast/scroll-snap/snap-scrolls-visual-viewport.html still flaky. Bug: 877106 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I4199e4a7474c08e1b27b5d54528b1b371164fd62 Reviewed-on: https://chromium-review.googlesource.com/1195106 Reviewed-by: Philip Rogers <pdr@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#587680} [modify] https://crrev.com/9d834f393e035b7dab36e7985d830eaab7dfca8b/cc/layers/layer.h [modify] https://crrev.com/9d834f393e035b7dab36e7985d830eaab7dfca8b/cc/trees/scroll_node.cc [modify] https://crrev.com/9d834f393e035b7dab36e7985d830eaab7dfca8b/third_party/blink/renderer/core/page/scrolling/snap_coordinator.cc [modify] https://crrev.com/9d834f393e035b7dab36e7985d830eaab7dfca8b/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc [modify] https://crrev.com/9d834f393e035b7dab36e7985d830eaab7dfca8b/third_party/blink/renderer/core/paint/paint_property_tree_builder.cc [modify] https://crrev.com/9d834f393e035b7dab36e7985d830eaab7dfca8b/third_party/blink/renderer/core/paint/paint_property_tree_update_tests.cc [modify] https://crrev.com/9d834f393e035b7dab36e7985d830eaab7dfca8b/third_party/blink/renderer/platform/graphics/compositing/property_tree_manager.cc [modify] https://crrev.com/9d834f393e035b7dab36e7985d830eaab7dfca8b/third_party/blink/renderer/platform/graphics/paint/scroll_paint_property_node.cc [modify] https://crrev.com/9d834f393e035b7dab36e7985d830eaab7dfca8b/third_party/blink/renderer/platform/graphics/paint/scroll_paint_property_node.h
,
Sep 4
|
||||
►
Sign in to add a comment |
||||
Comment 1 by chaopeng@chromium.org
, Aug 23