New issue
Advanced search Search tips

Issue 877099 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 24
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Cursors don't work with singleprocessmash on webcontents or for resize

Project Member Reported by sky@chromium.org, Aug 23

Issue description

Both do not show the right cursor.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9741588275be2c76aa651ff6509cc06c8b1c770

commit b9741588275be2c76aa651ff6509cc06c8b1c770
Author: Scott Violet <sky@chromium.org>
Date: Thu Aug 23 23:45:39 2018

chromeos: fixs cursor lookup for WebContents

Only use the cursor at an embed point if the embedder isn't intercepting
events. I'm assuming that if the embedder is intercepting events, then it's
setting the cursor. This is the case for WebContents.

BUG= 877099 
TEST=covered by test

Change-Id: I04304a2ae8e668f5a7506378868c2a53eac7de0a
Reviewed-on: https://chromium-review.googlesource.com/1187409
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585659}
[modify] https://crrev.com/b9741588275be2c76aa651ff6509cc06c8b1c770/services/ui/ws2/window_delegate_impl.cc
[modify] https://crrev.com/b9741588275be2c76aa651ff6509cc06c8b1c770/services/ui/ws2/window_delegate_impl_unittest.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/603ab6b16252f90d40a270d3238ab4c2520eea3b

commit 603ab6b16252f90d40a270d3238ab4c2520eea3b
Author: Scott Violet <sky@chromium.org>
Date: Fri Aug 24 17:24:18 2018

chromeos: fixs easy resize targeter for mash

EasyResizeWindowTargeter only works if a targeter is not installed on the
children of the container. This makes EasyResizeWindowTargeter work by
explicitly checking the parent's WindowTargeter for
SubtreeShouldBeExploredForEvent().

BUG= 877099 
TEST=covered by test

Change-Id: If5de972623bfbffb87986958010f7c8c51d8b448
Reviewed-on: https://chromium-review.googlesource.com/1187625
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585891}
[modify] https://crrev.com/603ab6b16252f90d40a270d3238ab4c2520eea3b/services/ui/ws2/BUILD.gn
[modify] https://crrev.com/603ab6b16252f90d40a270d3238ab4c2520eea3b/services/ui/ws2/server_window.cc
[add] https://crrev.com/603ab6b16252f90d40a270d3238ab4c2520eea3b/services/ui/ws2/server_window_unittest.cc
[modify] https://crrev.com/603ab6b16252f90d40a270d3238ab4c2520eea3b/ui/aura/window.h

Status: Fixed (was: Started)

Sign in to add a comment