New issue
Advanced search Search tips

Issue 877096 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[📍] Pinpoint parsing errors when trying to rerun a similar job on a patch

Project Member Reported by enne@chromium.org, Aug 23

Issue description

Open https://pinpoint-dot-chromeperf.appspot.com/job/128ff12fa40000

Click on the '+' to try to rerun a job.

Click on the '->' to run a similar job with a different patch set.

Paste in https://chromium-review.googlesource.com/c/chromium/src/+/1183012

Observe 'could not convert string to float: None' error
 
I was able to rerun the job by typing everything in manually: https://pinpoint-dot-chromeperf.appspot.com/job/13b45ece640000
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 27

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/849b98fbd2fb537bf2293b863ab8313fdad1a9fa

commit 849b98fbd2fb537bf2293b863ab8313fdad1a9fa
Author: Dave Tu <dtu@chromium.org>
Date: Mon Aug 27 21:29:36 2018

[pinpoint] Ignore comparison_magnitude == 'None' for patch jobs.

TBR=simonhatch
Bug: chromium:877096
Change-Id: I24fb8b910d3ad42284cb3c07cfcacf748895b173
Reviewed-on: https://chromium-review.googlesource.com/1191764
Reviewed-by: Dave Tu <dtu@chromium.org>
Commit-Queue: Dave Tu <dtu@chromium.org>

[modify] https://crrev.com/849b98fbd2fb537bf2293b863ab8313fdad1a9fa/dashboard/dashboard/pinpoint/elements/job-page/patch-job-fab.html

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d4e3adf79b5ab9fc063c7e10dd6230bd522ed78

commit 5d4e3adf79b5ab9fc063c7e10dd6230bd522ed78
Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Tue Aug 28 00:09:06 2018

Roll src/third_party/catapult 9b4fbc6e4341..d0d714d0f2fc (4 commits)

https://chromium.googlesource.com/catapult.git/+log/9b4fbc6e4341..d0d714d0f2fc


git log 9b4fbc6e4341..d0d714d0f2fc --date=short --no-merges --format='%ad %ae %s'
2018-08-27 benjhayden@chromium.org Define CSS vars for V2SPA.
2018-08-27 dtu@chromium.org [pinpoint] Ignore comparison_magnitude == 'None' for patch jobs.
2018-08-27 zmo@chromium.org Hook up generate_telemetry_build.py to PRESUBMIT.py
2018-08-27 benjhayden@chromium.org Add web-component-tester to third_party.


Created with:
  gclient setdep -r src/third_party/catapult@d0d714d0f2fc

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:877096, chromium:872521 , chromium:877660 
TBR=sullivan@chromium.org

Change-Id: Iac0ca8d5f207af61bf173c68d57778ce1c6b91b7
Reviewed-on: https://chromium-review.googlesource.com/1192244
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#586511}
[modify] https://crrev.com/5d4e3adf79b5ab9fc063c7e10dd6230bd522ed78/DEPS

Sign in to add a comment