[Fuchsia] Switch to llvm-strip to strip binaries |
||||
Issue descriptionWe are currently using eu-strip to strip binaries. This is a tracking bug to switch to llvm-objcopy for this feature.
,
Aug 30
Following offline discussions, we'll switch to llvm-strip instead as it is a drop-in replacement.
,
Aug 31
+pasko, who has been providing input on whether we can migrate Android off eu-strip to llvm-strip, to be able to remove the former entirely.
,
Aug 31
yeah this input is hard to underestimate :) thanks for keeping in loop! Adding +thakis and +pcc who would point at potential hidden gotchas fasterbetter.
,
Aug 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0f288583be07fd5b3b1e89dfe849b641ccd1cb8c commit 0f288583be07fd5b3b1e89dfe849b641ccd1cb8c Author: Fabrice de Gans-Riberi <fdegans@chromium.org> Date: Fri Aug 31 17:55:25 2018 Add llvm-strip and llvm-ar binaries. This adds llvm-strip for Linux and Mac and llvm-ar for Mac. These are needed to build Fuchsia on Mac and Linux hosts. For now, llvm-strip is in a separate package. Bug: 877080 Change-Id: If10284d6f76b0cf2397ccbe9d64b98abf04589d0 Reviewed-on: https://chromium-review.googlesource.com/1193949 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by: Hans Wennborg <hans@chromium.org> Reviewed-by: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#588084} [modify] https://crrev.com/0f288583be07fd5b3b1e89dfe849b641ccd1cb8c/docs/updating_clang.md [add] https://crrev.com/0f288583be07fd5b3b1e89dfe849b641ccd1cb8c/tools/clang/scripts/download_strip.py [modify] https://crrev.com/0f288583be07fd5b3b1e89dfe849b641ccd1cb8c/tools/clang/scripts/package.py
,
Aug 31
I discussed this with dglazkov. What's the motivation for using llvm-strip? eu-strip works well and is like 1/30th the size.
,
Sep 9
Just to clarify, our discussion was in the context of me working on a hobby project to enable Mac build. I didn't realize there was a broader conversation.
,
Sep 9
As a result of my conversation with thakis@, I made a Mac port of eu-strip here: https://chromium-review.googlesource.com/c/chromium/src/+/1214943
,
Sep 17
fdegans: Ping. Why do we want this?
,
Sep 18
The main reason was to be able to use it easily on a Mac host. Since it's a drop-in replacement to eu-strip in our case, it seemed like a good idea. Regarding eu-strip, I think the hard part would be to get both a Linux and Mac binary for every update, and I guess we would want them to be in different folders. Currently, the eu-strip binary is pulled in via git directly. The download process with llvm-strip is more straightforward.
,
Sep 18
dglazkov figured out how to build eu-strip on mac, so we should just use that. (...and pull eu-strip via .sha1 file instead of checking in the binaries to git). |
||||
►
Sign in to add a comment |
||||
Comment 1 by w...@chromium.org
, Aug 28Labels: M-71
Owner: fdegans@chromium.org
Status: Assigned (was: Available)