pinpoint.handlers.migrate_test.MigrateTest.testJobsMigrated failing, blocking catapult CQ |
||
Issue description
,
Aug 23
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/a7fb87b3a3d1dde21cc2cb1e0fd10e6c3bf3496c commit a7fb87b3a3d1dde21cc2cb1e0fd10e6c3bf3496c Author: Nghia Nguyen <nednguyen@google.com> Date: Thu Aug 23 14:39:21 2018 Wrap all exception of websocket with telemetry's exception.Error for recoverability Telemetry benchmark loop divides exceptions which are raised during benchmark run into two types: recoverable & unrecoverable. All the exception of type telemetry.core.exceptions.Error are recoverable according the Telemetry benchmark loop. Before this CL, every client that use chrome_inspector.inspector_websocket.InspectorWebsocket is responsible for converting the exceptions of websocket library (third party) to recoverable Telemetry exception. This can be error prone, as attached bug is one of the case one client forget to convert a websocket error to recoverable Telemetry exception, thus make error in devtool connection on one benchmark test killing the whole benchmark run. With this CL, we make sure that chrome_inspector.inspector_websocket.InspectorWebsocket only raises recoverable Telemetry exception for all error related to websocket connection. Note: this CL also disables pinpoint.handlers.migrate_test.MigrateTest.testJobsMigrated ( crbug.com/877074 ) Bug: chromium:876681 , chromium:877074 Change-Id: Ic641a3b74ca21fca22c9e615135493af2bdcbdd4 TBR=dtu@chromium.org # Pinpoint test disabling Change-Id: Ic641a3b74ca21fca22c9e615135493af2bdcbdd4 Reviewed-on: https://chromium-review.googlesource.com/1184974 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> [modify] https://crrev.com/a7fb87b3a3d1dde21cc2cb1e0fd10e6c3bf3496c/telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py [modify] https://crrev.com/a7fb87b3a3d1dde21cc2cb1e0fd10e6c3bf3496c/telemetry/telemetry/internal/backends/chrome_inspector/memory_backend.py [modify] https://crrev.com/a7fb87b3a3d1dde21cc2cb1e0fd10e6c3bf3496c/telemetry/telemetry/internal/backends/chrome_inspector/inspector_runtime.py [modify] https://crrev.com/a7fb87b3a3d1dde21cc2cb1e0fd10e6c3bf3496c/telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend.py [modify] https://crrev.com/a7fb87b3a3d1dde21cc2cb1e0fd10e6c3bf3496c/telemetry/telemetry/internal/backends/chrome_inspector/inspector_websocket.py [modify] https://crrev.com/a7fb87b3a3d1dde21cc2cb1e0fd10e6c3bf3496c/telemetry/telemetry/internal/backends/chrome_inspector/inspector_memory.py [modify] https://crrev.com/a7fb87b3a3d1dde21cc2cb1e0fd10e6c3bf3496c/telemetry/telemetry/internal/backends/chrome_inspector/inspector_websocket_unittest.py [modify] https://crrev.com/a7fb87b3a3d1dde21cc2cb1e0fd10e6c3bf3496c/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py [modify] https://crrev.com/a7fb87b3a3d1dde21cc2cb1e0fd10e6c3bf3496c/dashboard/dashboard/pinpoint/handlers/migrate_test.py [modify] https://crrev.com/a7fb87b3a3d1dde21cc2cb1e0fd10e6c3bf3496c/telemetry/telemetry/testing/fakes/__init__.py [modify] https://crrev.com/a7fb87b3a3d1dde21cc2cb1e0fd10e6c3bf3496c/telemetry/telemetry/internal/backends/chrome_inspector/devtools_client_backend.py
,
Aug 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/790625b3d4eb276334589f4e0e3a0f3adf8a8262 commit 790625b3d4eb276334589f4e0e3a0f3adf8a8262 Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Thu Aug 23 15:49:23 2018 Roll src/third_party/catapult 2229a8947448..a7fb87b3a3d1 (1 commits) https://chromium.googlesource.com/catapult.git/+log/2229a8947448..a7fb87b3a3d1 git log 2229a8947448..a7fb87b3a3d1 --date=short --no-merges --format='%ad %ae %s' 2018-08-23 nednguyen@google.com Wrap all exception of websocket with telemetry's exception.Error for recoverability Created with: gclient setdep -r src/third_party/catapult@a7fb87b3a3d1 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG= chromium:876681 , chromium:877074 TBR=sullivan@chromium.org Change-Id: I71fcf38964d1c2bde5afaea5d789314b35724b0e Reviewed-on: https://chromium-review.googlesource.com/1186664 Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585496} [modify] https://crrev.com/790625b3d4eb276334589f4e0e3a0f3adf8a8262/DEPS
,
Aug 24
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/2149fcca651949152ef8f024e7f47b6b7f26f86b commit 2149fcca651949152ef8f024e7f47b6b7f26f86b Author: Simon <simonhatch@chromium.org> Date: Fri Aug 24 17:00:23 2018 Pinpoint - Fix flaky migrate tests Bug: chromium:877074 Change-Id: Ib932ed9cb75b7986ce37e3bce0ed5670540c04c4 Reviewed-on: https://chromium-review.googlesource.com/1186546 Reviewed-by: David Tu <dtu@chromium.org> Commit-Queue: Simon Hatch <simonhatch@chromium.org> [modify] https://crrev.com/2149fcca651949152ef8f024e7f47b6b7f26f86b/dashboard/dashboard/common/testing_common.py [modify] https://crrev.com/2149fcca651949152ef8f024e7f47b6b7f26f86b/dashboard/dashboard/pinpoint/handlers/migrate_test.py
,
Aug 24
,
Aug 24
Issue 874608 has been merged into this issue.
,
Aug 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bd4bed873886cf2edc11c015d7447f448dd0fd4d commit bd4bed873886cf2edc11c015d7447f448dd0fd4d Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Fri Aug 24 22:19:43 2018 Roll src/third_party/catapult 1e44d066259f..72712b0d6078 (6 commits) https://chromium.googlesource.com/catapult.git/+log/1e44d066259f..72712b0d6078 git log 1e44d066259f..72712b0d6078 --date=short --no-merges --format='%ad %ae %s' 2018-08-24 zmo@chromium.org Add a script to auto generate telemetry_chrome_test_support build target 2018-08-24 benjhayden@chromium.org Remove bot_whitelist. 2018-08-24 simonhatch@chromium.org Pinpoint - Fix flaky migrate tests 2018-08-24 anthonyalridge@google.com Use real metric data for calculating significant changes. 2018-08-24 anthonyalridge@google.com Introduce display region for statistical test results. 2018-08-24 pasko@chromium.org perf_control.py: Remove TODO for a fixed bug Created with: gclient setdep -r src/third_party/catapult@72712b0d6078 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG= chromium:872521 , chromium:868512 , chromium:877074 ,chromium:866423,chromium:866423,chromium:397118 TBR=sullivan@chromium.org Change-Id: I2a744233b5777b9b640ea4fbaff5c9fba95114e6 Reviewed-on: https://chromium-review.googlesource.com/1188518 Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#586021} [modify] https://crrev.com/bd4bed873886cf2edc11c015d7447f448dd0fd4d/DEPS |
||
►
Sign in to add a comment |
||
Comment 1 by nednguyen@chromium.org
, Aug 23