New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 877058 link

Starred by 1 user
Status: Assigned
Owner:
alph@chromium.org
Cc:
perezju@chromium.org
█ nednguyen@chromium.org
alph@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----

Blocking:
issue 877231



Sign in to add a comment

memory.top_10_mobile/after_http_en_m_wikipedia_org_wiki_Science and 14 other(s) in performance_test_suite failing on chromium.perf/android-go-perf

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Aug 23 
Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of nednguyen@chromium.org

memory.top_10_mobile/after_http_en_m_wikipedia_org_wiki_Science and 14 other(s) in performance_test_suite failing on chromium.perf/android-go-perf

Builders failed on: 
- android-go-perf: 
  https://ci.chromium.org/buildbot/chromium.perf/android-go-perf
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, Aug 23

Cc: alph@chromium.org
Owner: alph@chromium.org
Status: Assigned (was: Available)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/11b27641640000

DevTools: Restore GPU tasks recording in performance profiles. by alph@chromium.org
https://chromium.googlesource.com/chromium/src/+/088dc9df1a255473c68e534206d950ea78663840
266.6 → No values

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec5aed4281a27d8fab8b6198fb0122baef4261aa

commit ec5aed4281a27d8fab8b6198fb0122baef4261aa
Author: Ned Nguyen <nednguyen@google.com>
Date: Thu Aug 23 15:06:23 2018

Revert "DevTools: Restore GPU tasks recording in performance profiles."

This reverts commit 088dc9df1a255473c68e534206d950ea78663840.

Reason for revert: breaking memory.top_10_mobile on android-go-perf

BUG:chromium:877058

Original change's description:
> DevTools: Restore GPU tasks recording in performance profiles.
> 
> Add GPU process pid to the list of processes where tracing is enabled.
> 
> Change-Id: Ic401ee4ea7d218cad36f687be226d092cd4e54a0
> Reviewed-on: https://chromium-review.googlesource.com/1182304
> Commit-Queue: Alexei Filippov <alph@chromium.org>
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#585301}

TBR=dgozman@chromium.org,kbr@chromium.org,alph@chromium.org

Change-Id: I256ed424aa4af07ccd63b561b17d86a7d7c9dded
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1186841
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#585488}
[modify] https://crrev.com/ec5aed4281a27d8fab8b6198fb0122baef4261aa/content/browser/devtools/protocol/tracing_handler.cc
[modify] https://crrev.com/ec5aed4281a27d8fab8b6198fb0122baef4261aa/content/browser/devtools/protocol/tracing_handler.h
[modify] https://crrev.com/ec5aed4281a27d8fab8b6198fb0122baef4261aa/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/ec5aed4281a27d8fab8b6198fb0122baef4261aa/content/browser/gpu/gpu_process_host.h
[delete] https://crrev.com/5e2058f7e71ef575afbc58c9bbb2b6866a36d3ca/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-gpu-tasks-expected.txt
[delete] https://crrev.com/5e2058f7e71ef575afbc58c9bbb2b6866a36d3ca/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-gpu-tasks.js
[modify] https://crrev.com/ec5aed4281a27d8fab8b6198fb0122baef4261aa/third_party/WebKit/LayoutTests/inspector-protocol/timeline/tracing-process-filter-expected.txt
[modify] https://crrev.com/ec5aed4281a27d8fab8b6198fb0122baef4261aa/third_party/WebKit/LayoutTests/inspector-protocol/timeline/tracing-process-filter.js

Comment 5 by alph@chromium.org, Aug 23 

Is there a way to reproduce the failure locally?

Comment 6 by nednguyen@chromium.org, Aug 23 

Hi alph@,
You can grab an android-one phone (this is a GOBO device), then run:

./tools/perf/run_benchmark memory.top_10_mobile --browser=android-chromium --story-filter= after_http_en_m_wikipedia_org_wiki_Science

Also see http://go/reproduce-telemetry
Project Member

Comment 10 by 42576172...@developer.gserviceaccount.com, Aug 23 

📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/11943a61640000

Reland "DevTools: Restore GPU tasks recording in performance profiles." by alph@chromium.org
https://chromium-review.googlesource.com/c/chromium/src/+/1187085/3
254.8 → No values

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Project Member

Comment 11 by 42576172...@developer.gserviceaccount.com, Aug 23 

📍 Couldn't reproduce a difference.
https://pinpoint-dot-chromeperf.appspot.com/job/12de8fba640000
Project Member

Comment 13 by 42576172...@developer.gserviceaccount.com, Aug 23 

📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/1595a051640000

Reland "DevTools: Restore GPU tasks recording in performance profiles." by alph@chromium.org
https://chromium-review.googlesource.com/c/chromium/src/+/1187085/4
301.1 → No values

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Project Member

Comment 15 by 42576172...@developer.gserviceaccount.com, Aug 23 

📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/14e71d45640000

Reland "DevTools: Restore GPU tasks recording in performance profiles." by alph@chromium.org
https://chromium-review.googlesource.com/c/chromium/src/+/1187558/1
265.8 → No values

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Project Member

Comment 18 by 42576172...@developer.gserviceaccount.com, Aug 23 

📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/17328309640000

Reland "DevTools: Restore GPU tasks recording in performance profiles." by alph@chromium.org
https://chromium-review.googlesource.com/c/chromium/src/+/1187558/2
273.1 → No values

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Project Member

Comment 19 by 42576172...@developer.gserviceaccount.com, Aug 24 

📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/104c1906640000

Reland "DevTools: Restore GPU tasks recording in performance profiles." by alph@chromium.org
https://chromium-review.googlesource.com/c/chromium/src/+/1187558/3
307.3 → No values

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Project Member

Comment 21 by 42576172...@developer.gserviceaccount.com, Aug 24 

📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/12252e72640000

Reland "DevTools: Restore GPU tasks recording in performance profiles." by alph@chromium.org
https://chromium-review.googlesource.com/c/chromium/src/+/1187558/4
264.9 → No values

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 22 by perezju@chromium.org, Aug 24

Blocking: 877231

Comment 23 by alph@chromium.org, Aug 24 

Why is it blocking something? It has been reverted.
Project Member

Comment 25 by 42576172...@developer.gserviceaccount.com, Aug 24 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/16943a61640000

The swarming task expired. The bots are likely overloaded, dead, or misconfigured.
Project Member

Comment 26 by 42576172...@developer.gserviceaccount.com, Aug 24 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/16e2ea61640000

The swarming task expired. The bots are likely overloaded, dead, or misconfigured.
Project Member

Comment 27 by 42576172...@developer.gserviceaccount.com, Aug 24 

📍 Couldn't reproduce a difference.
https://pinpoint-dot-chromeperf.appspot.com/job/14e874c5640000
Project Member

Comment 29 by 42576172...@developer.gserviceaccount.com, Aug 24 

📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/16dcb7e9640000

Reland "DevTools: Restore GPU tasks recording in performance profiles." by alph@chromium.org
https://chromium-review.googlesource.com/c/chromium/src/+/1187558/6
262.9 → 264 (+1.061)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Project Member

Comment 30 by bugdroid1@chromium.org, Aug 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/163a84c69db5429bdeca7c4ea9db6fbb44f001a8

commit 163a84c69db5429bdeca7c4ea9db6fbb44f001a8
Author: Alexei Filippov <alph@chromium.org>
Date: Sat Aug 25 01:50:18 2018

Reland "DevTools: Restore GPU tasks recording in performance profiles."

This is a reland of 088dc9df1a255473c68e534206d950ea78663840

GpuProcessHost::Get() is now called with force_create set to false.

BUG=877058
TBR=dgozman@chromium.org,kbr@chromium.org

Original change's description:
> DevTools: Restore GPU tasks recording in performance profiles.
>
> Add GPU process pid to the list of processes where tracing is enabled.
>
> Change-Id: Ic401ee4ea7d218cad36f687be226d092cd4e54a0
> Reviewed-on: https://chromium-review.googlesource.com/1182304
> Commit-Queue: Alexei Filippov <alph@chromium.org>
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#585301}

Change-Id: I21d6bc8e28724ced518d37a128af6797addaa1c0
Reviewed-on: https://chromium-review.googlesource.com/1187085
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586102}
[modify] https://crrev.com/163a84c69db5429bdeca7c4ea9db6fbb44f001a8/content/browser/devtools/protocol/tracing_handler.cc
[modify] https://crrev.com/163a84c69db5429bdeca7c4ea9db6fbb44f001a8/content/browser/devtools/protocol/tracing_handler.h
[modify] https://crrev.com/163a84c69db5429bdeca7c4ea9db6fbb44f001a8/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/163a84c69db5429bdeca7c4ea9db6fbb44f001a8/content/browser/gpu/gpu_process_host.h
[add] https://crrev.com/163a84c69db5429bdeca7c4ea9db6fbb44f001a8/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-gpu-tasks-expected.txt
[add] https://crrev.com/163a84c69db5429bdeca7c4ea9db6fbb44f001a8/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-gpu-tasks.js
[modify] https://crrev.com/163a84c69db5429bdeca7c4ea9db6fbb44f001a8/third_party/WebKit/LayoutTests/inspector-protocol/timeline/tracing-process-filter-expected.txt
[modify] https://crrev.com/163a84c69db5429bdeca7c4ea9db6fbb44f001a8/third_party/WebKit/LayoutTests/inspector-protocol/timeline/tracing-process-filter.js
►

Sign in to add a comment