New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 877056 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 28
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: ----



Sign in to add a comment

ndering.desktop/accu_weather_2018 and 6 other(s) in performance_test_suite failing on multiple platforms

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Aug 23

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of nednguyen@chromium.org

ndering.desktop/accu_weather_2018 and 6 other(s) in performance_test_suite failing on multiple platforms

Builders failed on: 
- Win 7 Nvidia GPU Perf: 
  https://ci.chromium.org/buildbot/chromium.perf/Win%207%20Nvidia%20GPU%20Perf
- Win 7 Perf: 
  https://ci.chromium.org/buildbot/chromium.perf/Win%207%20Perf
- linux-perf: 
  https://ci.chromium.org/buildbot/chromium.perf/linux-perf
- mac-10_12_laptop_low_end-perf: 
  https://ci.chromium.org/buildbot/chromium.perf/mac-10_12_laptop_low_end-perf
- mac-10_13_laptop_high_end-perf: 
  https://ci.chromium.org/buildbot/chromium.perf/mac-10_13_laptop_high_end-perf


 
Stack trace:
TraceDataPart("telemetry")
(ERROR) 2018-08-22 21:14:28,296 page_test_results.Fail:540  Failure recorded: Error: visible_content_area is zero
    at Object.addPixelsHistograms (/tracing/metrics/rendering/pixels.html:60:17)
    at new renderingMetric (/tracing/metrics/rendering/rendering_metric.html:88:26)
    at runMetrics (c:\b\s\w\ir\third_party\catapult\tracing\tracing\metrics\metric_map_function.html:61:16)
    at metricMapFunction (c:\b\s\w\ir\third_party\catapult\tracing\tracing\metrics\metric_map_function.html:190:24)
    at Object.mapSingleTrace (/tracing/mre/map_single_trace.html:39:7)
    at eval (c:\b\s\w\ir\third_party\catapult\tracing\tracing\mre\map_single_trace_cmdline.html:61:18)
    at Object.runAndConvertErrorsToFailures (/tracing/mre/map_single_trace.html:24:10)
    at mapSingleTraceWithResult (c:\b\s\w\ir\third_party\catapult\tracing\tracing\mre\map_single_trace_cmdline.html:52:12)
    at Object.mapSingleTraceMain (c:\b\s\w\ir\third_party\catapult\tracing\tracing\mre\map_single_trace_cmdline.html:77:20)
    at eval (c:\b\s\w\ir\third_party\catapult\tracing\tracing\mre\map_single_trace_cmdline.html:90:15)

Labels: -Pri-2 Pri-1
Owner: chiniforooshan@chromium.org
Status: Assigned (was: Available)
Ehsan: can you fix the error or disable pixel_metric to get the tests green again soon?
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 23

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/7a1ed44d248aa00191dbe8682b47bb5171c73e6a

commit 7a1ed44d248aa00191dbe8682b47bb5171c73e6a
Author: Ehsan Chiniforooshan <chiniforooshan@chromium.org>
Date: Thu Aug 23 19:41:23 2018

Telemetry: fix a rendering benchmark failure

We are seeing rendering stats trace events with zero visible content
area. Maybe they are comming from renderers for out of process
iframes. Those renderers are ignored in the legacy code. This CL will
filter out those events from metric computation until we figure out
why they exist and what we should do about them.

Bug:  chromium:877056 
Change-Id: I5e2022e786891c898d29b067fda10d631e221c53
Reviewed-on: https://chromium-review.googlesource.com/1186941
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Ben Hayden <benjhayden@chromium.org>

[modify] https://crrev.com/7a1ed44d248aa00191dbe8682b47bb5171c73e6a/tracing/tracing/metrics/rendering/pixels.html

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9277ba09cc7c415155fe727a80193f0e6a0b58c

commit a9277ba09cc7c415155fe727a80193f0e6a0b58c
Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Thu Aug 23 21:13:09 2018

Roll src/third_party/catapult a7fb87b3a3d1..7a1ed44d248a (1 commits)

https://chromium.googlesource.com/catapult.git/+log/a7fb87b3a3d1..7a1ed44d248a


git log a7fb87b3a3d1..7a1ed44d248a --date=short --no-merges --format='%ad %ae %s'
2018-08-23 chiniforooshan@chromium.org Telemetry: fix a rendering benchmark failure


Created with:
  gclient setdep -r src/third_party/catapult@7a1ed44d248a

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:877056 
TBR=sullivan@chromium.org

Change-Id: Ie77f89090cb2e0537baf011a3351c19f89e8c575
Reviewed-on: https://chromium-review.googlesource.com/1187341
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#585613}
[modify] https://crrev.com/a9277ba09cc7c415155fe727a80193f0e6a0b58c/DEPS

Status: Fixed (was: Assigned)

Sign in to add a comment