New issue
Advanced search Search tips

Issue 877047 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 24
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Muted volume icon is not visible properly in ubertray in OOBE screen

Project Member Reported by kebalaji@chromium.org, Aug 23

Issue description

Chrome Version: 69.0.3497.58/10895.33.0 beta-channel Daisy,Kip and Celes
OS: Chrome OS

What steps will reproduce the problem?
(1)Recover build>> Mute volume and observe muted volume icon is not visible in properly ubertray

Actual: Muted volume icon is not visible properly in ubertray
Expected: Muted volume icon should be visible properly

This is a Regression issue as same is working fine in 69.0.3497.35/10895.21.0 beta

NOTE: Issue is not seen on M70 as muting volume doesn't show muted volume icon in ubertray 


 
ActualMuteVolume1.png
11.9 MB View Download
Labels: -ReleaseBlock-Beta ReleaseBlock-Stable
Annoying, but does not prevent using chromebook. Moving to RBS, need to assign owner and prioritize a fix. Stable is not far off.
Owner: jdufault@chromium.org
Status: Assigned (was: Untriaged)
tetsui@, is this icon no longer present in unified system tray?
#4: yes, the icon is no longer present in Unified, but M69 still uses old system tray.
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5136d3532bd49f578b03272670914474e7a9febb

commit 5136d3532bd49f578b03272670914474e7a9febb
Author: Jacob Dufault <jdufault@google.com>
Date: Fri Aug 24 16:46:37 2018

cros: Fix mute shelf icon color in OOBE

Bug:  877047 
Change-Id: If77842d8f90cfc0a09420c82745d82a1b0a2030d
Reviewed-on: https://chromium-review.googlesource.com/1187407
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585875}
[modify] https://crrev.com/5136d3532bd49f578b03272670914474e7a9febb/ash/system/audio/tray_audio.cc
[modify] https://crrev.com/5136d3532bd49f578b03272670914474e7a9febb/ash/system/audio/tray_audio.h

Labels: Merge-Request-69
Status: Fixed (was: Started)
> #4: yes, the icon is no longer present in Unified, but M69 still uses old system tray.

Sounds good, I've fixed in the old system tray.
Project Member

Comment 9 by sheriffbot@chromium.org, Aug 24

Labels: -Merge-Request-69 Merge-Review-69 Hotlist-Merge-Review
This bug requires manual review: We are only 10 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-69 Merge-Approved-69
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 29

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d64c0d761ea5e768bb573a8a2cf76d416f06a054

commit d64c0d761ea5e768bb573a8a2cf76d416f06a054
Author: Wenzhao Zang <wzang@chromium.org>
Date: Wed Aug 29 20:03:47 2018

[Merge to M69] cros: Fix mute shelf icon color in OOBE

TBR=jdufault@google.com

(cherry picked from commit 5136d3532bd49f578b03272670914474e7a9febb)

Bug:  877047 
Change-Id: If77842d8f90cfc0a09420c82745d82a1b0a2030d
Reviewed-on: https://chromium-review.googlesource.com/1187407
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#585875}
Reviewed-on: https://chromium-review.googlesource.com/1195814
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#842}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/d64c0d761ea5e768bb573a8a2cf76d416f06a054/ash/system/audio/tray_audio.cc
[modify] https://crrev.com/d64c0d761ea5e768bb573a8a2cf76d416f06a054/ash/system/audio/tray_audio.h

Sign in to add a comment