DownloadTargetDeterminerTests flaky |
||||
Issue descriptionA number of DownloadTargetDeterminerTests have been super flaky lately on Nexus 5 test bots. Will find an owner in a moment, after I disable the tests. I 545.821s run_tests_on_device(01e2bd560b89d639) [ FAILED ] 3 tests, listed below: I 545.821s run_tests_on_device(01e2bd560b89d639) [ FAILED ] DownloadTargetDeterminerTest.MaybeDangerousContent I 545.821s run_tests_on_device(01e2bd560b89d639) [ FAILED ] DownloadTargetDeterminerTest.VisitedReferrer I 545.821s run_tests_on_device(01e2bd560b89d639) [ FAILED ] DownloadTargetDeterminerTest.MIMETypeDetermination Sample runs: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20CFI/2612 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20CFI/2610 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20CFI/2608 Sample errors: I 545.449s run_tests_on_device(01e2bd560b89d639) [----------] 4 tests from DownloadTargetDeterminerTest I 545.449s run_tests_on_device(01e2bd560b89d639) [ RUN ] DownloadTargetDeterminerTest.MaybeDangerousContent I 545.449s run_tests_on_device(01e2bd560b89d639) [WARNING:file_util_posix.cc(619)] OS_ANDROID: Home directory lookup not yet implemented. I 545.449s run_tests_on_device(01e2bd560b89d639) ../../chrome/browser/download/download_target_determiner_unittest.cc:484: Failure I 545.449s run_tests_on_device(01e2bd560b89d639) Expected equality of these values: I 545.449s run_tests_on_device(01e2bd560b89d639) expected_local_path.value() I 545.449s run_tests_on_device(01e2bd560b89d639) Which is: "/data/data/org.chromium.native_test/cache/.org.chromium.Chromium.lhoswo/foo.kindabad" I 545.449s run_tests_on_device(01e2bd560b89d639) target_info->target_path.value() I 545.449s run_tests_on_device(01e2bd560b89d639) Which is: "/storage/emulated/0/Download/foo.kindabad" I 545.449s run_tests_on_device(01e2bd560b89d639) Google Test trace: I 545.449s run_tests_on_device(01e2bd560b89d639) ../../chrome/browser/download/download_target_determiner_unittest.cc:474: Running test case 0 I 545.449s run_tests_on_device(01e2bd560b89d639) Stack trace: I 545.449s run_tests_on_device(01e2bd560b89d639) #00 0xd768ca99 /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x02b16a99 I 545.449s run_tests_on_device(01e2bd560b89d639) #01 0xd704b545 /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x024d5545 I 545.449s run_tests_on_device(01e2bd560b89d639) #02 0xd704b403 /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x024d5403 I 545.449s run_tests_on_device(01e2bd560b89d639) #03 0xd705bae1 /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x024e5ae1 I 545.450s run_tests_on_device(01e2bd560b89d639) #04 0xd705f2d5 /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x024e92d5 I 545.450s run_tests_on_device(01e2bd560b89d639) #05 0xd768f7d3 /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x02b197d3 I 545.450s run_tests_on_device(01e2bd560b89d639) I 545.450s run_tests_on_device(01e2bd560b89d639) ../../chrome/browser/download/download_target_determiner_unittest.cc:507: Failure I 545.450s run_tests_on_device(01e2bd560b89d639) Expected equality of these values: I 545.450s run_tests_on_device(01e2bd560b89d639) expected_local_path.DirName().value() I 545.450s run_tests_on_device(01e2bd560b89d639) Which is: "/data/data/org.chromium.native_test/cache/.org.chromium.Chromium.lhoswo" I 545.450s run_tests_on_device(01e2bd560b89d639) target_info->intermediate_path.DirName().value() I 545.450s run_tests_on_device(01e2bd560b89d639) Which is: "/storage/emulated/0/Download" I 545.450s run_tests_on_device(01e2bd560b89d639) Google Test trace: I 545.450s run_tests_on_device(01e2bd560b89d639) ../../chrome/browser/download/download_target_determiner_unittest.cc:474: Running test case 0 I 545.450s run_tests_on_device(01e2bd560b89d639) Stack trace: I 545.450s run_tests_on_device(01e2bd560b89d639) #00 0xd768ca99 /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x02b16a99 I 545.450s run_tests_on_device(01e2bd560b89d639) #01 0xd704b8d3 /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x024d58d3 I 545.450s run_tests_on_device(01e2bd560b89d639) #02 0xd704b403 /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x024d5403 I 545.450s run_tests_on_device(01e2bd560b89d639) #03 0xd705bae1 /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x024e5ae1 I 545.450s run_tests_on_device(01e2bd560b89d639) #04 0xd705f2d5 /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x024e92d5 I 545.450s run_tests_on_device(01e2bd560b89d639) #05 0xd768f7d3 /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x02b197d3 I 545.450s run_tests_on_device(01e2bd560b89d639) I 545.450s run_tests_on_device(01e2bd560b89d639) ../../chrome/browser/download/download_target_determiner_unittest.cc:484: Failure I 545.450s run_tests_on_device(01e2bd560b89d639) Expected equality of these values: I 545.450s run_tests_on_device(01e2bd560b89d639) expected_local_path.value() I 545.450s run_tests_on_device(01e2bd560b89d639) Which is: "/data/data/org.chromium.native_test/cache/.org.chromium.Chromium.lhoswo/foo.bad" I 545.450s run_tests_on_device(01e2bd560b89d639) target_info->target_path.value() I 545.450s run_tests_on_device(01e2bd560b89d639) Which is: "/storage/emulated/0/Download/foo.bad" I 545.450s run_tests_on_device(01e2bd560b89d639) Google Test trace: I 545.450s run_tests_on_device(01e2bd560b89d639) ../../chrome/browser/download/download_target_determiner_unittest.cc:474: Running test case 1 I 545.450s run_tests_on_device(01e2bd560b89d639) Stack trace: I 545.450s run_tests_on_device(01e2bd560b89d639) #00 0xd768ca99 /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x02b16a99 I 545.450s run_tests_on_device(01e2bd560b89d639) #01 0xd704b545 /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x024d5545 I 545.450s run_tests_on_device(01e2bd560b89d639) #02 0xd704b403 /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x024d5403 I 545.450s run_tests_on_device(01e2bd560b89d639) #03 0xd705bae1 /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x024e5ae1 I 545.450s run_tests_on_device(01e2bd560b89d639) #04 0xd705f2d5 /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x024e92d5 I 545.450s run_tests_on_device(01e2bd560b89d639) #05 0xd768f7d3 /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x02b197d3 I 545.450s run_tests_on_device(01e2bd560b89d639) I 545.450s run_tests_on_device(01e2bd560b89d639) ../../chrome/browser/download/download_target_determiner_unittest.cc:507: Failure I 545.450s run_tests_on_device(01e2bd560b89d639) Expected equality of these values: I 545.450s run_tests_on_device(01e2bd560b89d639) expected_local_path.DirName().value() I 545.450s run_tests_on_device(01e2bd560b89d639) Which is: "/data/data/org.chromium.native_test/cache/.org.chromium.Chromium.lhoswo" I 545.450s run_tests_on_device(01e2bd560b89d639) target_info->intermediate_path.DirName().value() I 545.450s run_tests_on_device(01e2bd560b89d639) Which is: "/storage/emulated/0/Download" I 545.450s run_tests_on_device(01e2bd560b89d639) Google Test trace: I 545.450s run_tests_on_device(01e2bd560b89d639) ../../chrome/browser/download/download_target_determiner_unittest.cc:474: Running test case 1 I 545.450s run_tests_on_device(01e2bd560b89d639) Stack trace: I 545.450s run_tests_on_device(01e2bd560b89d639) #00 0xd768ca99 /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x02b16a99 I 545.450s run_tests_on_device(01e2bd560b89d639) #01 0xd704b8d3 /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x024d58d3 I 545.450s run_tests_on_device(01e2bd560b89d639) #02 0xd704b403 /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x024d5403 I 545.450s run_tests_on_device(01e2bd560b89d639) #03 0xd705bae1 /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x024e5ae1 I 545.450s run_tests_on_device(01e2bd560b89d639) #04 0xd705f2d5 /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x024e92d5 I 545.451s run_tests_on_device(01e2bd560b89d639) #05 0xd768f7d3 /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x02b197d3 I 545.451s run_tests_on_device(01e2bd560b89d639) I 545.451s run_tests_on_device(01e2bd560b89d639) ../../chrome/browser/download/download_target_determiner_unittest.cc:484: Failure I 545.451s run_tests_on_device(01e2bd560b89d639) Expected equality of these values: I 545.451s run_tests_on_device(01e2bd560b89d639) expected_local_path.value() I 545.451s run_tests_on_device(01e2bd560b89d639) Which is: "/data/data/org.chromium.native_test/cache/.org.chromium.Chromium.lhoswo/foo.kindabad" I 545.451s run_tests_on_device(01e2bd560b89d639) target_info->target_path.value() I 545.451s run_tests_on_device(01e2bd560b89d639) Which is: "/storage/emulated/0/Download/foo.kindabad" I 545.451s run_tests_on_device(01e2bd560b89d639) Google Test trace: I 545.451s run_tests_on_device(01e2bd560b89d639) ../../chrome/browser/download/download_target_determiner_unittest.cc:474: Running test case 2 I 545.451s run_tests_on_device(01e2bd560b89d639) Stack trace: I 545.451s run_tests_on_device(01e2bd560b89d639) #00 0xd768ca99 /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x02b16a99 I 545.451s run_tests_on_device(01e2bd560b89d639) #01 0xd704b545 /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x024d5545 I 545.451s run_tests_on_device(01e2bd560b89d639) #02 0xd704b403 /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x024d5403 I 545.451s run_tests_on_device(01e2bd560b89d639) #03 0xd705bae1 /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x024e5ae1 I 545.451s run_tests_on_device(01e2bd560b89d639) #04 0xd705f2d5 /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x024e92d5 I 545.451s run_tests_on_device(01e2bd560b89d639) #05 0xd768f7d3 /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x02b197d3 I 545.451s run_tests_on_device(01e2bd560b89d639) I 545.451s run_tests_on_device(01e2bd560b89d639) ../../chrome/browser/download/download_target_determiner_unittest.cc:507: Failure I 545.451s run_tests_on_device(01e2bd560b89d639) Expected equality of these values: I 545.451s run_tests_on_device(01e2bd560b89d639) expected_local_path.DirName().value() I 545.451s run_tests_on_device(01e2bd560b89d639) Which is: "/data/data/org.chromium.native_test/cache/.org.chromium.Chromium.lhoswo" I 545.451s run_tests_on_device(01e2bd560b89d639) target_info->intermediate_path.DirName().value() I 545.451s run_tests_on_device(01e2bd560b89d639) Which is: "/storage/emulated/0/Download" I 545.451s run_tests_on_device(01e2bd560b89d639) Google Test trace: I 545.451s run_tests_on_device(01e2bd560b89d639) ../../chrome/browser/download/download_target_determiner_unittest.cc:474: Running test case 2 I 545.451s run_tests_on_device(01e2bd560b89d639) Stack trace: I 545.451s run_tests_on_device(01e2bd560b89d639) #00 0xd768ca99 /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x02b16a99 I 545.451s run_tests_on_device(01e2bd560b89d639) #01 0xd704b8d3 /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x024d58d3 I 545.451s run_tests_on_device(01e2bd560b89d639) #02 0xd704b403 /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x024d5403 I 545.451s run_tests_on_device(01e2bd560b89d639) #03 0xd705bae1 /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x024e5ae1 I 545.451s run_tests_on_device(01e2bd560b89d639) #04 0xd705f2d5 /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x024e92d5 I 545.451s run_tests_on_device(01e2bd560b89d639) #05 0xd768f7d3 /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x02b197d3 I 545.451s run_tests_on_device(01e2bd560b89d639) I 545.451s run_tests_on_device(01e2bd560b89d639) [ FAILED ] DownloadTargetDeterminerTest.MaybeDangerousContent (274 ms) I 545.451s run_tests_on_device(01e2bd560b89d639) [ RUN ] DownloadTargetDeterminerTest.DefaultVirtual I 545.451s run_tests_on_device(01e2bd560b89d639) [WARNING:file_util_posix.cc(619)] OS_ANDROID: Home directory lookup not yet implemented. I 545.451s run_tests_on_device(01e2bd560b89d639) [ OK ] DownloadTargetDeterminerTest.DefaultVirtual (51 ms) I 545.451s run_tests_on_device(01e2bd560b89d639) [ RUN ] DownloadTargetDeterminerTest.VisitedReferrer I 545.451s run_tests_on_device(01e2bd560b89d639) [WARNING:file_util_posix.cc(619)] OS_ANDROID: Home directory lookup not yet implemented. I 545.451s run_tests_on_device(01e2bd560b89d639) ../../chrome/browser/download/download_target_determiner_unittest.cc:484: Failure I 545.451s run_tests_on_device(01e2bd560b89d639) Expected equality of these values: I 545.451s run_tests_on_device(01e2bd560b89d639) expected_local_path.value() I 545.451s run_tests_on_device(01e2bd560b89d639) Which is: "/data/data/org.chromium.native_test/cache/.org.chromium.Chromium.lqtnkv/foo.kindabad" I 545.451s run_tests_on_device(01e2bd560b89d639) target_info->target_path.value() I 545.452s run_tests_on_device(01e2bd560b89d639) Which is: "/storage/emulated/0/Download/foo.kindabad" I 545.452s run_tests_on_device(01e2bd560b89d639) Google Test trace: I 545.452s run_tests_on_device(01e2bd560b89d639) ../../chrome/browser/download/download_target_determiner_unittest.cc:474: Running test case 0 I 545.452s run_tests_on_device(01e2bd560b89d639) Stack trace: I 545.452s run_tests_on_device(01e2bd560b89d639) #00 0xd768ca99 /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x02b16a99 I 545.452s run_tests_on_device(01e2bd560b89d639) #01 0xd704b545 /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x024d5545 I 545.452s run_tests_on_device(01e2bd560b89d639) #02 0xd704b403 /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x024d5403 I 545.452s run_tests_on_device(01e2bd560b89d639) #03 0xd705bae1 /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x024e5ae1 I 545.452s run_tests_on_device(01e2bd560b89d639) #04 0xd705d29f /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x024e729f I 545.452s run_tests_on_device(01e2bd560b89d639) #05 0xd768f7d3 /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x02b197d3 I 545.452s run_tests_on_device(01e2bd560b89d639) I 545.452s run_tests_on_device(01e2bd560b89d639) ../../chrome/browser/download/download_target_determiner_unittest.cc:484: Failure I 545.452s run_tests_on_device(01e2bd560b89d639) Expected equality of these values: I 545.452s run_tests_on_device(01e2bd560b89d639) expected_local_path.value() I 545.452s run_tests_on_device(01e2bd560b89d639) Which is: "/data/data/org.chromium.native_test/cache/.org.chromium.Chromium.lqtnkv/foo.kindabad" I 545.452s run_tests_on_device(01e2bd560b89d639) target_info->target_path.value() I 545.452s run_tests_on_device(01e2bd560b89d639) Which is: "/storage/emulated/0/Download/foo.kindabad" I 545.452s run_tests_on_device(01e2bd560b89d639) Google Test trace: I 545.452s run_tests_on_device(01e2bd560b89d639) ../../chrome/browser/download/download_target_determiner_unittest.cc:474: Running test case 1 I 545.452s run_tests_on_device(01e2bd560b89d639) Stack trace: I 545.452s run_tests_on_device(01e2bd560b89d639) #00 0xd768ca99 /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x02b16a99 I 545.452s run_tests_on_device(01e2bd560b89d639) #01 0xd704b545 /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x024d5545 I 545.452s run_tests_on_device(01e2bd560b89d639) #02 0xd704b403 /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x024d5403 I 545.452s run_tests_on_device(01e2bd560b89d639) #03 0xd705bae1 /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x024e5ae1 I 545.452s run_tests_on_device(01e2bd560b89d639) #04 0xd705d29f /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x024e729f I 545.452s run_tests_on_device(01e2bd560b89d639) #05 0xd768f7d3 /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x02b197d3 I 545.452s run_tests_on_device(01e2bd560b89d639) I 545.452s run_tests_on_device(01e2bd560b89d639) ../../chrome/browser/download/download_target_determiner_unittest.cc:507: Failure I 545.452s run_tests_on_device(01e2bd560b89d639) Expected equality of these values: I 545.452s run_tests_on_device(01e2bd560b89d639) expected_local_path.DirName().value() I 545.452s run_tests_on_device(01e2bd560b89d639) Which is: "/data/data/org.chromium.native_test/cache/.org.chromium.Chromium.lqtnkv" I 545.452s run_tests_on_device(01e2bd560b89d639) target_info->intermediate_path.DirName().value() I 545.452s run_tests_on_device(01e2bd560b89d639) Which is: "/storage/emulated/0/Download" I 545.452s run_tests_on_device(01e2bd560b89d639) Google Test trace: I 545.452s run_tests_on_device(01e2bd560b89d639) ../../chrome/browser/download/download_target_determiner_unittest.cc:474: Running test case 1 I 545.452s run_tests_on_device(01e2bd560b89d639) Stack trace: I 545.452s run_tests_on_device(01e2bd560b89d639) #00 0xd768ca99 /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x02b16a99 I 545.452s run_tests_on_device(01e2bd560b89d639) #01 0xd704b8d3 /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x024d58d3 I 545.452s run_tests_on_device(01e2bd560b89d639) #02 0xd704b403 /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x024d5403 I 545.452s run_tests_on_device(01e2bd560b89d639) #03 0xd705bae1 /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x024e5ae1 I 545.452s run_tests_on_device(01e2bd560b89d639) #04 0xd705d29f /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x024e729f I 545.452s run_tests_on_device(01e2bd560b89d639) #05 0xd768f7d3 /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x02b197d3 I 545.452s run_tests_on_device(01e2bd560b89d639) I 545.452s run_tests_on_device(01e2bd560b89d639) ../../chrome/browser/download/download_target_determiner_unittest.cc:484: Failure I 545.452s run_tests_on_device(01e2bd560b89d639) Expected equality of these values: I 545.452s run_tests_on_device(01e2bd560b89d639) expected_local_path.value() I 545.452s run_tests_on_device(01e2bd560b89d639) Which is: "/data/data/org.chromium.native_test/cache/.org.chromium.Chromium.lqtnkv/foo.kindabad" I 545.452s run_tests_on_device(01e2bd560b89d639) target_info->target_path.value() I 545.452s run_tests_on_device(01e2bd560b89d639) Which is: "/storage/emulated/0/Download/foo.kindabad" I 545.452s run_tests_on_device(01e2bd560b89d639) Google Test trace: I 545.453s run_tests_on_device(01e2bd560b89d639) ../../chrome/browser/download/download_target_determiner_unittest.cc:474: Running test case 2 I 545.453s run_tests_on_device(01e2bd560b89d639) Stack trace: I 545.453s run_tests_on_device(01e2bd560b89d639) #00 0xd768ca99 /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x02b16a99 I 545.453s run_tests_on_device(01e2bd560b89d639) #01 0xd704b545 /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x024d5545 I 545.453s run_tests_on_device(01e2bd560b89d639) #02 0xd704b403 /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x024d5403 I 545.453s run_tests_on_device(01e2bd560b89d639) #03 0xd705bae1 /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x024e5ae1 I 545.453s run_tests_on_device(01e2bd560b89d639) #04 0xd705d29f /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x024e729f I 545.453s run_tests_on_device(01e2bd560b89d639) #05 0xd768f7d3 /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x02b197d3 I 545.453s run_tests_on_device(01e2bd560b89d639) I 545.453s run_tests_on_device(01e2bd560b89d639) [ FAILED ] DownloadTargetDeterminerTest.VisitedReferrer (230 ms) I 545.453s run_tests_on_device(01e2bd560b89d639) [ RUN ] DownloadTargetDeterminerTest.MIMETypeDetermination I 545.453s run_tests_on_device(01e2bd560b89d639) [WARNING:file_util_posix.cc(619)] OS_ANDROID: Home directory lookup not yet implemented. I 545.453s run_tests_on_device(01e2bd560b89d639) ../../chrome/browser/download/download_target_determiner_unittest.cc:2098: Failure I 545.453s run_tests_on_device(01e2bd560b89d639) Expected equality of these values: I 545.453s run_tests_on_device(01e2bd560b89d639) test_case.expected_mime_type I 545.453s run_tests_on_device(01e2bd560b89d639) Which is: "image/png" I 545.453s run_tests_on_device(01e2bd560b89d639) target_info->mime_type I 545.453s run_tests_on_device(01e2bd560b89d639) Which is: "" I 545.453s run_tests_on_device(01e2bd560b89d639) Google Test trace: I 545.453s run_tests_on_device(01e2bd560b89d639) ../../chrome/browser/download/download_target_determiner_unittest.cc:2091: Running test case 0 I 545.453s run_tests_on_device(01e2bd560b89d639) Stack trace: I 545.453s run_tests_on_device(01e2bd560b89d639) #00 0xd768ca99 /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x02b16a99 I 545.453s run_tests_on_device(01e2bd560b89d639) #01 0xd7058e9b /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x024e2e9b I 545.453s run_tests_on_device(01e2bd560b89d639) #02 0xd768f7d3 /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x02b197d3 I 545.453s run_tests_on_device(01e2bd560b89d639) I 545.453s run_tests_on_device(01e2bd560b89d639) ../../chrome/browser/download/download_target_determiner_unittest.cc:2098: Failure I 545.453s run_tests_on_device(01e2bd560b89d639) Expected equality of these values: I 545.453s run_tests_on_device(01e2bd560b89d639) test_case.expected_mime_type I 545.453s run_tests_on_device(01e2bd560b89d639) Which is: "image/png" I 545.453s run_tests_on_device(01e2bd560b89d639) target_info->mime_type I 545.453s run_tests_on_device(01e2bd560b89d639) Which is: "" I 545.453s run_tests_on_device(01e2bd560b89d639) Google Test trace: I 545.453s run_tests_on_device(01e2bd560b89d639) ../../chrome/browser/download/download_target_determiner_unittest.cc:2091: Running test case 1 I 545.453s run_tests_on_device(01e2bd560b89d639) Stack trace: I 545.453s run_tests_on_device(01e2bd560b89d639) #00 0xd768ca99 /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x02b16a99 I 545.453s run_tests_on_device(01e2bd560b89d639) #01 0xd7058e9b /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x024e2e9b I 545.453s run_tests_on_device(01e2bd560b89d639) #02 0xd768f7d3 /data/app/org.chromium.native_test-1/lib/arm/lib_unit_tests__library.so+0x02b197d3 I 545.453s run_tests_on_device(01e2bd560b89d639) I 545.453s run_tests_on_device(01e2bd560b89d639) [ FAILED ] DownloadTargetDeterminerTest.MIMETypeDetermination (82 ms) I 545.453s run_tests_on_device(01e2bd560b89d639) [----------] 4 tests from DownloadTargetDeterminerTest (640 ms total)
,
Aug 23
Asanka, I didn't find an obvious CL culprit, can you take a look or triage this further? Thanks!
,
Aug 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1da47c695212a3339801db10f08fa944a3bbb17d commit 1da47c695212a3339801db10f08fa944a3bbb17d Author: Finnur Thorarinsson <finnur@chromium.org> Date: Thu Aug 23 12:22:00 2018 Disable a few flaky DownloadTargetDeterminerTests. TBR: asanka Bug: 877026 Change-Id: I4ebda150350f73839e357497a66d3f4a8a252f71 Reviewed-on: https://chromium-review.googlesource.com/1186418 Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#585458} [modify] https://crrev.com/1da47c695212a3339801db10f08fa944a3bbb17d/chrome/browser/download/download_target_determiner_unittest.cc
,
Aug 23
,
Aug 23
Looks like there is a race condition setting up the default download dir for test.
,
Aug 25
Ok, I think I figured out the problem. On the Android_cfi bot, global lazy instances don't get reset when running each individual test cases. As a result, if any test runs first and sets the default download dir, the default download dir instance will live until all tests are finished. And overriding the default download dir in DownloadTargetDeterminerTests doesn't help since the singleton has already been created.
,
Aug 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ad7fdb672c5b9b873facb026b6c9d3be23d6d7f5 commit ad7fdb672c5b9b873facb026b6c9d3be23d6d7f5 Author: Min Qin <qinmin@chromium.org> Date: Tue Aug 28 06:23:13 2018 Fix flaky DownloadTargetDeterminerTests on nexus 5x bots The issue is introduced by https://chromium-review.googlesource.com/c/chromium/src/+/948852. If g_default_download_directory in download_prefs.cc is already set by a previous testcase, DownloadTargetDeterminerTest will not be able to reset that global variable. That's causing many tests to fail. This CL fixes the problem by reintroducing the SetDownloadPath() call to set download path tied to the DownloadPrefs. BUG= 877026 Change-Id: I235cddd6e28bc2803610bf559528d0722bc61f15 Reviewed-on: https://chromium-review.googlesource.com/1192336 Reviewed-by: Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#586597} [modify] https://crrev.com/ad7fdb672c5b9b873facb026b6c9d3be23d6d7f5/chrome/browser/download/download_target_determiner_unittest.cc
,
Aug 28
|
||||
►
Sign in to add a comment |
||||
Comment 1 by finnur@chromium.org
, Aug 23