Issue metadata
Sign in to add a comment
|
frame caption buttons don't change color after applying theme |
||||||||||||||||||||||
Issue descriptionChrome Version: 69.0.3497.58/10895.33.0 beta-channel Daisy,Kip and Celes OS: Chrome Theme URL : https://chrome.google.com/webstore/detail/black-blue-shards/hgoflmajhinnohnhkfeggflmmppiilck?hl=en What steps will reproduce the problem? (1)Sign into User -> go to above Theme URL -> now add that Theme (2)Observe Close,Restore and Minimize Icons are not highlighted -> now open any Window , for example open Files App (3)Now Use 'Alt+Tab' key to switch tabs -> observe Close,Restore and Minimize Icons are getting highlighted i.e. Icons are not getting highlighted unless we switch tabs (Please refer Video) Expected: a)Close,Restore and Minimize Icons should get highlighted after applying Theme or b)Close,Restore and Minimize Icons should remain same even after switching or not switching tabs Actual: Instead a)Close,Restore and Minimize Icons are not highlighted after applying Theme b)Icons get highlighted after switching tabs This is Regression Issue as in M-67 Icons remains same even after switching or not switching tabs
,
Aug 23
,
Aug 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/adaab7dace8096f2522ca83d13821a99234d59aa commit adaab7dace8096f2522ca83d13821a99234d59aa Author: Evan Stade <estade@chromium.org> Date: Fri Aug 24 21:53:01 2018 Chrome OS: Fix caption button color after theme install Make sure the caption buttons are updated right away when the theme changes. The bug occurs in classic Ash; it works properly in Mash. This patch adds a test which only covers Mash to make it sure it doesn't regress. Bug: 877022 Change-Id: Ic4d9824396e196dd368ae896d269f862af883bbd Reviewed-on: https://chromium-review.googlesource.com/1187406 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#586008} [modify] https://crrev.com/adaab7dace8096f2522ca83d13821a99234d59aa/ash/frame/caption_buttons/frame_caption_button.h [modify] https://crrev.com/adaab7dace8096f2522ca83d13821a99234d59aa/ash/frame/non_client_frame_view_ash_unittest.cc [modify] https://crrev.com/adaab7dace8096f2522ca83d13821a99234d59aa/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
,
Aug 27
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by est...@chromium.org
, Aug 23