New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 877018 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 30
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature


Sign in to add a comment

Migrate chromium.webrtc and chromium.webrtc.fyi to LUCI

Project Member Reported by phoglund@chromium.org, Aug 23

Issue description

Master tracking bug
 
Blockedon: 877471
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/396f2763c261a492558ce84fb8cdc59780c86846

commit 396f2763c261a492558ce84fb8cdc59780c86846
Author: Kenneth Russell <kbr@chromium.org>
Date: Fri Aug 24 18:16:20 2018

Substitute arguments for GTest steps.

This provides information like the builder name and Chromium git
revision to tests.

Bug:  877018 
Change-Id: Ia30201cc2be52e8f0fcf358a8dca3172b9eb32e1
Reviewed-on: https://chromium-review.googlesource.com/1188626
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>

[modify] https://crrev.com/396f2763c261a492558ce84fb8cdc59780c86846/scripts/slave/recipe_modules/chromium_tests/steps.py

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77d27b30a38e862b4e1eab213e5b9a203454519a

commit 77d27b30a38e862b4e1eab213e5b9a203454519a
Author: Patrik Höglund <phoglund@chromium.org>
Date: Mon Aug 27 13:25:22 2018

Move chromium.webrtc[.fyi] flags source-side.

This adds experimental test suites I can call from my new LUCI
bots.

Depends on a change which makes variable substitutions available
to gtests.

Bug:  chromium:877018 
Change-Id: Iadf529513e5a92a4e731d3adcaff874101356646
Reviewed-on: https://chromium-review.googlesource.com/1186412
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586243}
[modify] https://crrev.com/77d27b30a38e862b4e1eab213e5b9a203454519a/content/test/BUILD.gn
[add] https://crrev.com/77d27b30a38e862b4e1eab213e5b9a203454519a/testing/buildbot/chromium.webrtc.experimental.json
[add] https://crrev.com/77d27b30a38e862b4e1eab213e5b9a203454519a/testing/buildbot/chromium.webrtc.fyi.experimental.json
[modify] https://crrev.com/77d27b30a38e862b4e1eab213e5b9a203454519a/testing/buildbot/filters/BUILD.gn
[add] https://crrev.com/77d27b30a38e862b4e1eab213e5b9a203454519a/testing/buildbot/filters/webrtc.content_unittests.filter
[add] https://crrev.com/77d27b30a38e862b4e1eab213e5b9a203454519a/testing/buildbot/filters/webrtc_functional.browser_tests.filter
[add] https://crrev.com/77d27b30a38e862b4e1eab213e5b9a203454519a/testing/buildbot/filters/webrtc_perf.browser_tests.filter
[modify] https://crrev.com/77d27b30a38e862b4e1eab213e5b9a203454519a/testing/buildbot/test_suites.pyl
[modify] https://crrev.com/77d27b30a38e862b4e1eab213e5b9a203454519a/testing/buildbot/waterfalls.pyl

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 28

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/aa3043a77f17df14977ac73e7af8d482524bb62a

commit aa3043a77f17df14977ac73e7af8d482524bb62a
Author: Patrik Höglund <phoglund@chromium.org>
Date: Tue Aug 28 07:20:41 2018

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/ecf25dd7e81a86ca20b70d87c2d526dfafe1730b

commit ecf25dd7e81a86ca20b70d87c2d526dfafe1730b
Author: Patrik Höglund <phoglund@chromium.org>
Date: Fri Aug 31 09:56:05 2018

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/fc05dc583841885cfb966d5f06298043bdc60678

commit fc05dc583841885cfb966d5f06298043bdc60678
Author: Patrik Höglund <phoglund@chromium.org>
Date: Fri Aug 31 10:16:26 2018

Project Member

Comment 7 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/cccf6ac7d8566289ae7eb341c4513eed6fc65ad1

commit cccf6ac7d8566289ae7eb341c4513eed6fc65ad1
Author: Patrik Höglund <phoglund@chromium.org>
Date: Fri Aug 31 11:30:51 2018

Blocking: 870625
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 5

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/e62af52813bf29d28da23304f2390a0a985b0c21

commit e62af52813bf29d28da23304f2390a0a985b0c21
Author: Patrik Höglund <phoglund@chromium.org>
Date: Wed Sep 05 08:56:20 2018

Project Member

Comment 10 by bugdroid1@chromium.org, Sep 5

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/4d2b4c99f20702a39350f0b58c01b49402a6536f

commit 4d2b4c99f20702a39350f0b58c01b49402a6536f
Author: Patrik Höglund <phoglund@chromium.org>
Date: Wed Sep 05 07:43:56 2018

Add experimental webrtc chromium fyi master.

The idea is to duplicate the config for chromium.webrtc.fyi
everywhere so I can safely experiment with my new test suites and
make sure the config is in the right place.

Bug:  877018 
Change-Id: I159b3f5e74c77effca0dce71672a843bb6e2d8c3
Reviewed-on: https://chromium-review.googlesource.com/1202082
Reviewed-by: Joanna Wang <jojwang@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#17398}
[modify] https://crrev.com/4d2b4c99f20702a39350f0b58c01b49402a6536f/go/src/infra/appengine/test-results/masters/masters.go

Project Member

Comment 11 by bugdroid1@chromium.org, Sep 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/f89dc0a03a2e3a18f3feb7f3d0c37e5b4cfc603d

commit f89dc0a03a2e3a18f3feb7f3d0c37e5b4cfc603d
Author: Patrik Höglund <phoglund@chromium.org>
Date: Wed Sep 05 07:51:17 2018

Add config for chromium.webrtc.fyi.experimental.

The idea is to duplicate the config for chromium.webrtc.fyi
everywhere so I can safely experiment with my new test suites and
make sure the config is in the right place. It's possible that there
is unnecessary config in the new SPEC; I just generated it out of the
old one. The only modification is that I removed tests, which will be
specified by waterfalls.pyl.

I also need CLs for mb_config.pyl and maybe test_results as well.

Bug:  877018 
Change-Id: I46f6735dcd10ca299ea60a32029a79ecf181ad07
Reviewed-on: https://chromium-review.googlesource.com/1201588
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>

[add] https://crrev.com/f89dc0a03a2e3a18f3feb7f3d0c37e5b4cfc603d/scripts/slave/recipe_modules/chromium_tests/chromium_webrtc_fyi_experimental.py
[modify] https://crrev.com/f89dc0a03a2e3a18f3feb7f3d0c37e5b4cfc603d/scripts/slave/bot_update.py
[modify] https://crrev.com/f89dc0a03a2e3a18f3feb7f3d0c37e5b4cfc603d/scripts/slave/recipe_modules/chromium_tests/builders.py
[modify] https://crrev.com/f89dc0a03a2e3a18f3feb7f3d0c37e5b4cfc603d/scripts/slave/logdog-params.pyl
[modify] https://crrev.com/f89dc0a03a2e3a18f3feb7f3d0c37e5b4cfc603d/scripts/slave/recipe_modules/chromium_tests/tests/steps/webrtc_perf_test.py
[add] https://crrev.com/f89dc0a03a2e3a18f3feb7f3d0c37e5b4cfc603d/scripts/slave/recipe_modules/chromium_tests/tests/steps/webrtc_perf_test.expected/webrtc_fyi_experimental_tester.json

Blockedon: 881118
Project Member

Comment 13 by bugdroid1@chromium.org, Sep 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b37a343c4298d98114ea17bf7a016bdf9d8c3ec1

commit b37a343c4298d98114ea17bf7a016bdf9d8c3ec1
Author: Patrik Höglund <phoglund@chromium.org>
Date: Mon Sep 10 07:34:53 2018

Add chromium.webrtc.fyi.experimental to mb.

The idea is to duplicate the config for chromium.webrtc.fyi
everywhere so I can safely experiment with my new test suites and
make sure the config is in the right place.

Bug:  877018 
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: I96b62965369a28b0984ec8aa8464899c89ce875c
Reviewed-on: https://chromium-review.googlesource.com/1201857
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589845}
[modify] https://crrev.com/b37a343c4298d98114ea17bf7a016bdf9d8c3ec1/tools/mb/mb_config.pyl
[modify] https://crrev.com/b37a343c4298d98114ea17bf7a016bdf9d8c3ec1/tools/perf/core/perf_dashboard_machine_group_mapping.json

Remove the experimental FYI waterfall.

After a discussion on luci-taskforce we decided it makes more sense
to put the WebRTC chromium bots into Chromium's config. This will
make the resulting waterfalls easier to maintain since we don't have
to sync permissions between the WebRTC and chromium service accounts
and/or sync configuration. The WebRTC bots will just be regular bots
with some magic in them.

Bug:  877018 
Change-Id: I758d58a245d39bf098a90c0258e20e2ed6911e2e
Reviewed-on: https://webrtc-review.googlesource.com/99640
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Commit-Queue: Patrik Höglund <phoglund@webrtc.org>
Project Member

Comment 15 by bugdroid1@chromium.org, Sep 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1e0489a0bb6bbaa0e9c4ba121b2b321f94fa0af

commit a1e0489a0bb6bbaa0e9c4ba121b2b321f94fa0af
Author: Patrik Höglund <phoglund@chromium.org>
Date: Wed Sep 12 12:49:32 2018

Add LUCI waterfall for chromium.webrtc.fyi.experimental.

I started constructing this waterfall in the WebRTC project, but
after a discussion on luci-taskforce@ we decided it's a better idea
to place these bots in the Chromium config. That way all the config is
in one repo. These bots are just mildly WebRTC-flavored Chromium bots
anyway, so keeping them with other chrome bots makes sense.

There is a small change in waterfalls.pyl so that we run tests
on actual testers and not builders, as is the case now. That
was an error I'm now correcting.

Also, we can use the presubmit checks for waterfalls.pyl since these
bots will be in Chromium's luci-milo.cfg rather than the one in the
WebRTC repo. Furthermore, these bots will use Chromium's service
account rather than the WebRTC service account, which means we don't
have to keep the permissions in sync for the two accounts.

Bug:  877018 
Change-Id: I16543b16a171971fa9c29bc96bd89bb344e17a6b
Reviewed-on: https://chromium-review.googlesource.com/1219346
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590652}
[modify] https://crrev.com/a1e0489a0bb6bbaa0e9c4ba121b2b321f94fa0af/infra/config/global/cr-buildbucket.cfg
[modify] https://crrev.com/a1e0489a0bb6bbaa0e9c4ba121b2b321f94fa0af/infra/config/global/luci-milo.cfg
[modify] https://crrev.com/a1e0489a0bb6bbaa0e9c4ba121b2b321f94fa0af/infra/config/global/luci-scheduler.cfg
[modify] https://crrev.com/a1e0489a0bb6bbaa0e9c4ba121b2b321f94fa0af/testing/buildbot/chromium.webrtc.fyi.experimental.json
[modify] https://crrev.com/a1e0489a0bb6bbaa0e9c4ba121b2b321f94fa0af/testing/buildbot/generate_buildbot_json.py
[modify] https://crrev.com/a1e0489a0bb6bbaa0e9c4ba121b2b321f94fa0af/testing/buildbot/waterfalls.pyl

Project Member

Comment 16 by bugdroid1@chromium.org, Sep 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/14d39da8773879dd517f9e490a5a7f57ca3c479d

commit 14d39da8773879dd517f9e490a5a7f57ca3c479d
Author: Patrik Höglund <phoglund@chromium.org>
Date: Thu Sep 13 11:35:42 2018

Rename WebRTC FYI experimental builders.

It turns out LUCI assumes that buildbucket job names must be the same
as the builder name for triggering here:

https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium_tests/api.py?l=568

Therefore, rename builders to match job names. It makes sense to
name them like this anyway, to disambiguate from regular WebRTC
CI bots.

Tbr: dpranke@chromium.org
Bug:  chromium:877018 
Change-Id: Ie38d47d6d90da032d39a3cfcacb7618cade7989b
Reviewed-on: https://chromium-review.googlesource.com/1215167
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Reviewed-by: Oleh Prypin <oprypin@chromium.org>

[modify] https://crrev.com/14d39da8773879dd517f9e490a5a7f57ca3c479d/scripts/slave/recipe_modules/chromium_tests/chromium_webrtc_fyi_experimental.py
[modify] https://crrev.com/14d39da8773879dd517f9e490a5a7f57ca3c479d/scripts/slave/recipe_modules/chromium_tests/tests/steps/webrtc_perf_test.py
[modify] https://crrev.com/14d39da8773879dd517f9e490a5a7f57ca3c479d/scripts/slave/recipe_modules/chromium_tests/tests/steps/webrtc_perf_test.expected/webrtc_fyi_experimental_tester.json

Project Member

Comment 17 by bugdroid1@chromium.org, Sep 13

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/ec1044c9f31a367c2faea14cd6d4a2c3059d514e

commit ec1044c9f31a367c2faea14cd6d4a2c3059d514e
Author: Patrik Höglund <phoglund@chromium.org>
Date: Thu Sep 13 11:49:49 2018

Project Member

Comment 18 by bugdroid1@chromium.org, Sep 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/512a36c7db57ff4808a21aa2ee80ed16ff129e16

commit 512a36c7db57ff4808a21aa2ee80ed16ff129e16
Author: Patrik Höglund <phoglund@chromium.org>
Date: Thu Sep 13 13:40:47 2018

Revert "Rename WebRTC FYI experimental builders."

This reverts commit 14d39da8773879dd517f9e490a5a7f57ca3c479d.

Reason for revert: In case this is breaking the infra wct tester?

Original change's description:
> Rename WebRTC FYI experimental builders.
> 
> It turns out LUCI assumes that buildbucket job names must be the same
> as the builder name for triggering here:
> 
> https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium_tests/api.py?l=568
> 
> Therefore, rename builders to match job names. It makes sense to
> name them like this anyway, to disambiguate from regular WebRTC
> CI bots.
> 
> Tbr: dpranke@chromium.org
> Bug:  chromium:877018 
> Change-Id: Ie38d47d6d90da032d39a3cfcacb7618cade7989b
> Reviewed-on: https://chromium-review.googlesource.com/1215167
> Commit-Queue: Patrik Höglund <phoglund@chromium.org>
> Reviewed-by: Patrik Höglund <phoglund@chromium.org>
> Reviewed-by: Oleh Prypin <oprypin@chromium.org>

TBR=phoglund@chromium.org,dpranke@chromium.org,oprypin@chromium.org

Change-Id: I83fe08dd9523303a8246726647faf8e06b8e871d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  chromium:877018 
Reviewed-on: https://chromium-review.googlesource.com/1224318
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>

[modify] https://crrev.com/512a36c7db57ff4808a21aa2ee80ed16ff129e16/scripts/slave/recipe_modules/chromium_tests/chromium_webrtc_fyi_experimental.py
[modify] https://crrev.com/512a36c7db57ff4808a21aa2ee80ed16ff129e16/scripts/slave/recipe_modules/chromium_tests/tests/steps/webrtc_perf_test.py
[modify] https://crrev.com/512a36c7db57ff4808a21aa2ee80ed16ff129e16/scripts/slave/recipe_modules/chromium_tests/tests/steps/webrtc_perf_test.expected/webrtc_fyi_experimental_tester.json

Project Member

Comment 19 by bugdroid1@chromium.org, Sep 13

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/4fab4aecee8fa4ce46873ef75c9c9921b243ec04

commit 4fab4aecee8fa4ce46873ef75c9c9921b243ec04
Author: Patrik Höglund <phoglund@chromium.org>
Date: Thu Sep 13 14:01:05 2018

Project Member

Comment 20 by bugdroid1@chromium.org, Sep 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/075ab6a01cf3c49b133b50a2f45cb2ecddaa587e

commit 075ab6a01cf3c49b133b50a2f45cb2ecddaa587e
Author: Patrik Höglund <phoglund@chromium.org>
Date: Fri Sep 14 07:33:29 2018

Reland "Rename WebRTC FYI experimental builders."

This is a reland of 14d39da8773879dd517f9e490a5a7f57ca3c479d

Original change's description:
> Rename WebRTC FYI experimental builders.
>
> It turns out LUCI assumes that buildbucket job names must be the same
> as the builder name for triggering here:
>
> https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium_tests/api.py?l=568
>
> Therefore, rename builders to match job names. It makes sense to
> name them like this anyway, to disambiguate from regular WebRTC
> CI bots.
>
> Tbr: dpranke@chromium.org
> Bug:  chromium:877018 
> Change-Id: Ie38d47d6d90da032d39a3cfcacb7618cade7989b
> Reviewed-on: https://chromium-review.googlesource.com/1215167
> Commit-Queue: Patrik Höglund <phoglund@chromium.org>
> Reviewed-by: Patrik Höglund <phoglund@chromium.org>
> Reviewed-by: Oleh Prypin <oprypin@chromium.org>

Tbr: dpranke@chromium.org
Bug:  chromium:877018 
Change-Id: I3997c8aca43e8b031ca723a62f54dd3b2501ee36
Reviewed-on: https://chromium-review.googlesource.com/1224319
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Reviewed-by: Patrik Höglund <phoglund@chromium.org>

[modify] https://crrev.com/075ab6a01cf3c49b133b50a2f45cb2ecddaa587e/scripts/slave/recipe_modules/chromium_tests/chromium_webrtc_fyi_experimental.py
[modify] https://crrev.com/075ab6a01cf3c49b133b50a2f45cb2ecddaa587e/scripts/slave/recipe_modules/chromium_tests/tests/steps/webrtc_perf_test.py
[modify] https://crrev.com/075ab6a01cf3c49b133b50a2f45cb2ecddaa587e/scripts/slave/recipe_modules/chromium_tests/tests/steps/webrtc_perf_test.expected/webrtc_fyi_experimental_tester.json

Project Member

Comment 21 by bugdroid1@chromium.org, Sep 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f5924df224f88c7618a4cd98849de08b5a25570

commit 6f5924df224f88c7618a4cd98849de08b5a25570
Author: Patrik Höglund <phoglund@chromium.org>
Date: Mon Sep 17 08:10:13 2018

Allow WebRTC admins to trigger WebRTC FYI Chromium bots.

Chromium troopers still retain access. This should enable
me to click "run now" in luci-scheduler, which is nice for
debugging.

Bug:  chromium:877018 
Change-Id: Ibecdce8248b3dcf341faf3d57da2a8c9426e106f
Reviewed-on: https://chromium-review.googlesource.com/1224393
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591620}
[modify] https://crrev.com/6f5924df224f88c7618a4cd98849de08b5a25570/infra/config/global/luci-scheduler.cfg

Project Member

Comment 22 by bugdroid1@chromium.org, Sep 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85e83b20d24f0f2d8f5de3a7ecef4b6fc13dae82

commit 85e83b20d24f0f2d8f5de3a7ecef4b6fc13dae82
Author: Patrik Höglund <phoglund@chromium.org>
Date: Mon Sep 17 19:14:51 2018

Fix builder names in new experimental WebRTC FYI waterfall.

Tbr: kbr@chromium.org
Bug:  chromium:877018 
Change-Id: I1d0e3d144f1aeb73407f2990d41c6b7c5c446b94
Reviewed-on: https://chromium-review.googlesource.com/1227111
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591765}
[modify] https://crrev.com/85e83b20d24f0f2d8f5de3a7ecef4b6fc13dae82/tools/mb/mb_config.pyl

Project Member

Comment 23 by bugdroid1@chromium.org, Sep 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/36b0732ad50d4efab0330446853dcda31657efed

commit 36b0732ad50d4efab0330446853dcda31657efed
Author: Patrik Höglund <phoglund@chromium.org>
Date: Tue Sep 18 09:39:49 2018

Fix parent builder names to fix triggering.

I renamed all builders but forgot parents, so triggering doesn't work.

Tbr: kbr@chromium.org
Bug:  chromium:877018 
Change-Id: I6a71fed3fbaf9746478bbaff41521a60989bea8f
Reviewed-on: https://chromium-review.googlesource.com/1230133
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>

[modify] https://crrev.com/36b0732ad50d4efab0330446853dcda31657efed/scripts/slave/recipe_modules/chromium_tests/chromium_webrtc_fyi_experimental.py

Project Member

Comment 24 by bugdroid1@chromium.org, Sep 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/496e8666b58d391b813221bfc96279f5cc195ca7

commit 496e8666b58d391b813221bfc96279f5cc195ca7
Author: Patrik Höglund <phoglund@chromium.org>
Date: Wed Sep 19 08:24:52 2018

Only run content_browsertests on experimental WebRTC FYI android bots.

It turns out that's how it works in the old waterfall, so let's
keep doing that.

Bug:  877018 
Change-Id: If3132684e299a8b090e4b9ed82b3f5be1cb7fe74
Reviewed-on: https://chromium-review.googlesource.com/1230061
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592344}
[modify] https://crrev.com/496e8666b58d391b813221bfc96279f5cc195ca7/testing/buildbot/chromium.webrtc.fyi.experimental.json
[modify] https://crrev.com/496e8666b58d391b813221bfc96279f5cc195ca7/testing/buildbot/test_suites.pyl
[modify] https://crrev.com/496e8666b58d391b813221bfc96279f5cc195ca7/testing/buildbot/waterfalls.pyl

Project Member

Comment 25 by bugdroid1@chromium.org, Sep 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a2ceef04f4a1efdecd858d4bce0c6135b13d9b2

commit 1a2ceef04f4a1efdecd858d4bce0c6135b13d9b2
Author: Patrik Höglund <phoglund@chromium.org>
Date: Wed Sep 19 10:11:39 2018

Add temporary configs for experimental WebRTC waterfall.

This temporary waterfall is because I'm rewriting all the configs while
also porting chromium.webrtc.fyi to LUCI. It will be removed later.

The configs are just copies from chromium.webrtc.fyi.

Bug:  877018 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ibe26cdf714a7048f90373dfc0a7eec8ddcead1e2
Reviewed-on: https://chromium-review.googlesource.com/1230023
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592359}
[add] https://crrev.com/1a2ceef04f4a1efdecd858d4bce0c6135b13d9b2/ios/build/bots/chromium.webrtc.fyi.experimental/WebRTC Chromium FYI ios-device.json
[add] https://crrev.com/1a2ceef04f4a1efdecd858d4bce0c6135b13d9b2/ios/build/bots/chromium.webrtc.fyi.experimental/WebRTC Chromium FYI ios-simulator.json

Project Member

Comment 26 by bugdroid1@chromium.org, Sep 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da85afa63edcce63927391f743bb72587770d9a7

commit da85afa63edcce63927391f743bb72587770d9a7
Author: Patrik Höglund <phoglund@chromium.org>
Date: Mon Sep 24 09:41:27 2018

Hard-code targets to build for FYI builders that have no testers.

We only want to build targets related to WebRTC. Building all is
troublesome because very few Chromium bots do that, and some
peripheral targets become prone to breaking as a result.

We don't have to specify binaries for bots with testers, in that
case the builder will simply build what the tester requests. If
there is no associated tester, the builder builds all targets
by default, so override this default.

Bug:  877018 
Change-Id: Ie393d7d4390d2cd33f6ff7aec132f24047189c44
Reviewed-on: https://chromium-review.googlesource.com/1230014
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593495}
[modify] https://crrev.com/da85afa63edcce63927391f743bb72587770d9a7/testing/buildbot/chromium.webrtc.fyi.experimental.json
[modify] https://crrev.com/da85afa63edcce63927391f743bb72587770d9a7/testing/buildbot/waterfalls.pyl

Blockedon: 888429
Project Member

Comment 28 by bugdroid1@chromium.org, Sep 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ed5aec83b0e2e24b618388460164be1677d4003

commit 2ed5aec83b0e2e24b618388460164be1677d4003
Author: Patrik Höglund <phoglund@chromium.org>
Date: Tue Sep 25 06:56:59 2018

Always build a handful of edge-case WebRTC targets.

We don't run tests on frame_analyzer or remoting/webapp, but we have
found we should build them. The former checks our quality toolchain
builds in chromium, and remoting/webapp builds WebRTC through the
extremely strange pnacl build process.

I reckoned the regular builders should build those, otherwise regular
compile failures in the two above components look like dbg-only
failures, which is misleading. The bots will compute what other
binaries they need based off what the triggered tester is using.

Bug:  877018 
Change-Id: I7282bef2a8a0fd24409f4a4bb493549b4e688ae0
Reviewed-on: https://chromium-review.googlesource.com/1238727
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593841}
[modify] https://crrev.com/2ed5aec83b0e2e24b618388460164be1677d4003/testing/buildbot/chromium.webrtc.fyi.experimental.json
[modify] https://crrev.com/2ed5aec83b0e2e24b618388460164be1677d4003/testing/buildbot/waterfalls.pyl

Project Member

Comment 29 by bugdroid1@chromium.org, Sep 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf9213185f4b30e2467ada974274a0eae7ccd601

commit bf9213185f4b30e2467ada974274a0eae7ccd601
Author: Patrik Höglund <phoglund@chromium.org>
Date: Tue Sep 25 10:27:46 2018

Force apprtc test to run locally for now.

It runs locally in the old BuildBot waterfall as well, so
let's keep it that way until we can get time to port this
test.

Bug: 888429, 877018 
Change-Id: I78b4bf6a2205c7c77ccf4f681f4f53bca2879f20
Reviewed-on: https://chromium-review.googlesource.com/1240273
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593884}
[modify] https://crrev.com/bf9213185f4b30e2467ada974274a0eae7ccd601/testing/buildbot/chromium.webrtc.fyi.experimental.json
[modify] https://crrev.com/bf9213185f4b30e2467ada974274a0eae7ccd601/testing/buildbot/test_suites.pyl

Project Member

Comment 30 by bugdroid1@chromium.org, Sep 26

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/3f7a0913a6a2ec20760cde9d3119057b0ed11693

commit 3f7a0913a6a2ec20760cde9d3119057b0ed11693
Author: Patrik Höglund <phoglund@chromium.org>
Date: Wed Sep 26 09:45:11 2018

Project Member

Comment 31 by bugdroid1@chromium.org, Sep 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0d962f31bd173a66fb34109777646d843175d2f

commit e0d962f31bd173a66fb34109777646d843175d2f
Author: Patrik Höglund <phoglund@chromium.org>
Date: Thu Sep 27 05:33:34 2018

Prepare for switching chromium.webrtc.fyi LUCI to prod.

This should get my new builders side-by-side with the old ones
so I can compare them in luci-migration.appspot.com and switch LUCI
to prod if it looks good.

I realize now it was unnecessary to create the experimental fyi
"waterfall" in luci-milo - this is better.

Bug:  877018 
Change-Id: I3de02a6d94f3349018395a16ede5d0f665a68e0d
Reviewed-on: https://chromium-review.googlesource.com/1245466
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594600}
[modify] https://crrev.com/e0d962f31bd173a66fb34109777646d843175d2f/infra/config/global/luci-milo.cfg

Project Member

Comment 32 by bugdroid1@chromium.org, Sep 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4409df58d7e45e9223a91c20c411218109214294

commit 4409df58d7e45e9223a91c20c411218109214294
Author: Patrik Höglund <phoglund@chromium.org>
Date: Thu Sep 27 05:35:35 2018

Fix typo in WebRTC config.

Bug:  877018 
Change-Id: I3502e8ce9c8410f3af1c52581adbc0d708806a7f
Reviewed-on: https://chromium-review.googlesource.com/1245365
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594601}
[modify] https://crrev.com/4409df58d7e45e9223a91c20c411218109214294/infra/config/global/luci-scheduler.cfg

Project Member

Comment 33 by bugdroid1@chromium.org, Sep 27

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/e4b18d61be60bb8944f04a16cdcd1eb3c11bab38

commit e4b18d61be60bb8944f04a16cdcd1eb3c11bab38
Author: Patrik Höglund <phoglund@chromium.org>
Date: Thu Sep 27 09:13:37 2018

Project Member

Comment 34 by bugdroid1@chromium.org, Sep 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3f16847aee5713fe84d8a7c16d3bec217d53583

commit c3f16847aee5713fe84d8a7c16d3bec217d53583
Author: Patrik Höglund <phoglund@chromium.org>
Date: Fri Sep 28 09:36:23 2018

Merge experimental config to the master config for WebRTC Chromium FYI.

I have a green waterfall which confirms the experimental src-side
config works now, so make BuildBot use the new config. This will make
it easier to switch from BuildBot to LUCI.

This CL needs to land concurrently with the infra CLs + restart of the
WebRTC Chromium FYI master since the bots change names as a part of
this process.

Bug:  877018 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I2811718874bb9f6079488fc0ee17e6f324ae50b0
Reviewed-on: https://chromium-review.googlesource.com/1249103
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595033}
[modify] https://crrev.com/c3f16847aee5713fe84d8a7c16d3bec217d53583/infra/config/global/cr-buildbucket.cfg
[modify] https://crrev.com/c3f16847aee5713fe84d8a7c16d3bec217d53583/infra/config/global/luci-milo.cfg
[delete] https://crrev.com/bc52bfa040bc44d7f8c4ae9d7e2a6f94584f33d8/ios/build/bots/chromium.webrtc.fyi.experimental/WebRTC Chromium FYI ios-device.json
[delete] https://crrev.com/bc52bfa040bc44d7f8c4ae9d7e2a6f94584f33d8/ios/build/bots/chromium.webrtc.fyi.experimental/WebRTC Chromium FYI ios-simulator.json
[delete] https://crrev.com/bc52bfa040bc44d7f8c4ae9d7e2a6f94584f33d8/testing/buildbot/chromium.webrtc.fyi.experimental.json
[modify] https://crrev.com/c3f16847aee5713fe84d8a7c16d3bec217d53583/testing/buildbot/chromium.webrtc.fyi.json
[modify] https://crrev.com/c3f16847aee5713fe84d8a7c16d3bec217d53583/testing/buildbot/waterfalls.pyl
[modify] https://crrev.com/c3f16847aee5713fe84d8a7c16d3bec217d53583/tools/mb/mb_config.pyl

Project Member

Comment 35 by bugdroid1@chromium.org, Sep 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/3debbbb90bd16461f227ebc398c24632af3773ff

commit 3debbbb90bd16461f227ebc398c24632af3773ff
Author: Patrik Höglund <phoglund@chromium.org>
Date: Fri Sep 28 09:49:15 2018

Merge experimental config to the master config for WebRTC Chromium FYI.

I have a green waterfall which confirms the experimental src-side
config works now, so make BuildBot use the new config. This will make
it easier to switch from BuildBot to LUCI.

CL for changing LKGR names:
https://chromium-review.googlesource.com/c/infra/infra/+/1249362
Chromium-side CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1249103

Bug:  877018 
Change-Id: I2d38fccb7b47f5a3cbdfdde9ed7e754a5bcf7f2d
Reviewed-on: https://chromium-review.googlesource.com/1249024
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Reviewed-by: Oleh Prypin <oprypin@google.com>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

[modify] https://crrev.com/3debbbb90bd16461f227ebc398c24632af3773ff/scripts/slave/recipe_modules/chromium_tests/chromium_webrtc_fyi.py
[delete] https://crrev.com/66af208afea0f93035b0637766f5d920e47a7712/scripts/slave/recipe_modules/chromium_tests/chromium_webrtc_fyi_experimental.py
[modify] https://crrev.com/3debbbb90bd16461f227ebc398c24632af3773ff/masters/master.chromium.webrtc.fyi/slaves.cfg
[modify] https://crrev.com/3debbbb90bd16461f227ebc398c24632af3773ff/scripts/slave/bot_update.py
[modify] https://crrev.com/3debbbb90bd16461f227ebc398c24632af3773ff/scripts/slave/recipe_modules/chromium_tests/builders.py
[modify] https://crrev.com/3debbbb90bd16461f227ebc398c24632af3773ff/scripts/slave/recipe_modules/chromium_tests/tests/steps/webrtc_perf_test.expected/webrtc_fyi_tester.json
[modify] https://crrev.com/3debbbb90bd16461f227ebc398c24632af3773ff/masters/master.chromium.webrtc.fyi/master_builders_cfg.py
[modify] https://crrev.com/3debbbb90bd16461f227ebc398c24632af3773ff/scripts/slave/recipe_modules/chromium_tests/tests/steps/webrtc_perf_test.py
[delete] https://crrev.com/66af208afea0f93035b0637766f5d920e47a7712/scripts/slave/recipe_modules/chromium_tests/tests/steps/webrtc_perf_test.expected/webrtc_fyi_experimental_tester.json

Project Member

Comment 36 by bugdroid1@chromium.org, Sep 28

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/3f939bf215bd6793578d403f44af64161ade23f6

commit 3f939bf215bd6793578d403f44af64161ade23f6
Author: Patrik Höglund <phoglund@webrtc.org>
Date: Fri Sep 28 09:57:36 2018

Whitespace change to kick bots.

Tbr: oprypin@webrtc.org
Bug:  chromium:877018 
Change-Id: I29a619de34fa299753b856e0f813d314c5a8cba6
Reviewed-on: https://webrtc-review.googlesource.com/102542
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24885}
[modify] https://crrev.com/3f939bf215bd6793578d403f44af64161ade23f6/tools_webrtc/whitespace.txt

Project Member

Comment 37 by bugdroid1@chromium.org, Sep 28

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/1074581164c75050400281ad5f6b0ae100d12990

commit 1074581164c75050400281ad5f6b0ae100d12990
Author: Patrik Höglund <phoglund@chromium.org>
Date: Fri Sep 28 10:27:49 2018

Update WebRTC Chromium FYI builder names.

The names will change because the upcoming LUCI bots will have these
names. I will change the names of the existing builders before to
make the migration easier.

https://chromium-review.googlesource.com/c/chromium/src/+/1249103
has more context.

Bug:  877018 
Change-Id: I2e07b95a05ecdc130fc7b37faf92458d362a6cc0
Reviewed-on: https://chromium-review.googlesource.com/1249362
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#17941}
[modify] https://crrev.com/1074581164c75050400281ad5f6b0ae100d12990/infra/services/lkgr_finder/config/webrtc_cfg.pyl

Project Member

Comment 38 by bugdroid1@chromium.org, Sep 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6748fbc093a778e58b83adfce66065220a1178f5

commit 6748fbc093a778e58b83adfce66065220a1178f5
Author: Patrik Höglund <phoglund@chromium.org>
Date: Fri Sep 28 10:29:42 2018

Correct iOS config names for WebRTC Chromium FYI.

I forgot to rename these in the last patch.

No-try since no trybots run these configs.

Tbr: justincohen@chromium.org.
Bug:  877018 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: If9213ceabdeb70b2feb21fddbb446d7b742bbccc
No-try: True
Reviewed-on: https://chromium-review.googlesource.com/1251084
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595042}
[rename] https://crrev.com/6748fbc093a778e58b83adfce66065220a1178f5/ios/build/bots/chromium.webrtc.fyi/WebRTC Chromium FYI ios-device.json
[rename] https://crrev.com/6748fbc093a778e58b83adfce66065220a1178f5/ios/build/bots/chromium.webrtc.fyi/WebRTC Chromium FYI ios-simulator.json

Project Member

Comment 39 by bugdroid1@chromium.org, Sep 28

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/d9664b8249882b114c46da6931a046cf82289085

commit d9664b8249882b114c46da6931a046cf82289085
Author: Patrik Höglund <phoglund@webrtc.org>
Date: Fri Sep 28 11:06:55 2018

Whitespace change 2 to kick bots.

TBR=oprypin@webrtc.org

Change-Id: I3e2fb1278d4729c8419a29f9516c2f064696f29f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  chromium:877018 
Reviewed-on: https://webrtc-review.googlesource.com/102562
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24887}
[modify] https://crrev.com/d9664b8249882b114c46da6931a046cf82289085/tools_webrtc/whitespace.txt

Project Member

Comment 40 by bugdroid1@chromium.org, Oct 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f025b26750c63fd97f8ae3a721e1d162b649a49a

commit f025b26750c63fd97f8ae3a721e1d162b649a49a
Author: Patrik Höglund <phoglund@chromium.org>
Date: Mon Oct 01 07:17:34 2018

Actually run WebRTC Win7/Win8 tests on Win7 and Win8.

Bug:  877018 
Change-Id: I5258360d3ca5175b6dcc2072c82a1f792f241836
Reviewed-on: https://chromium-review.googlesource.com/1245445
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595395}
[modify] https://crrev.com/f025b26750c63fd97f8ae3a721e1d162b649a49a/infra/config/global/cr-buildbucket.cfg

Project Member

Comment 41 by bugdroid1@chromium.org, Oct 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/185d120cf604691b33d9703cd3b695a31310610d

commit 185d120cf604691b33d9703cd3b695a31310610d
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Mon Oct 01 08:16:34 2018

Roll src/third_party/webrtc 1ee9160a2e0b..156d11ddd939 (26 commits)

https://webrtc.googlesource.com/src.git/+log/1ee9160a2e0b..156d11ddd939


git log 1ee9160a2e0b..156d11ddd939 --date=short --no-merges --format='%ad %ae %s'
2018-09-29 srte@webrtc.org Adds packet_size to rtc::SentPacket in testing code.
2018-09-29 buildbot@webrtc.org Roll chromium_revision d54862fccc..11cc0bafaf (595183:595285)
2018-09-28 buildbot@webrtc.org Roll chromium_revision a20c193cad..d54862fccc (595072:595183)
2018-09-28 steveanton@webrtc.org Throw exception if MediaStreamTrack is constructed with a null native track.
2018-09-28 buildbot@webrtc.org Roll chromium_revision f63f90fb1f..a20c193cad (594935:595072)
2018-09-28 phensman@webrtc.org Reland "Add option to call VMAF in compare_videos.py."
2018-09-28 saza@webrtc.org Revert "Remove APM-internal usage of EchoControlMobile"
2018-09-28 sakal@webrtc.org Throw IllegalStateException if native objects are used after dispose.
2018-09-28 oprypin@webrtc.org Autoroller: switch back to old-style "=" tags for TBR to work
2018-09-28 saza@webrtc.org Use low cut filtering whenever NS or AEC are enabled
2018-09-28 mbonadei@webrtc.org Enforce LGTM from owners of depends-on paths in DEPS via presubmit.
2018-09-28 srte@webrtc.org Adds simulated time scenario client.
2018-09-28 nisse@webrtc.org Change ReceiveStatistics to implement RtpPacketSinkInterface, part 1
2018-09-28 saza@webrtc.org Remove APM-internal usage of EchoControlMobile
2018-09-28 phoglund@webrtc.org Whitespace change 2 to kick bots.
2018-09-28 mbonadei@webrtc.org Remove backwards compatible macro RTC_EXPORT from sdk/.
2018-09-28 phoglund@webrtc.org Whitespace change to kick bots.
2018-09-28 nisse@webrtc.org Delete unused HTTP server code
2018-09-28 sakal@webrtc.org Revert "Add option to call VMAF in compare_videos.py."
2018-09-28 nisse@webrtc.org Reland "Replace VideoDecoder with VideoDecoderFactory in VideoReceiveStream config."
2018-09-28 kron@webrtc.org Parse two-byte header extensions.
2018-09-28 henrika@webrtc.org Improves threading model in AudioDeviceTest.
2018-09-28 crodbro@webrtc.org Move network trace calculation from analyzer to rtc_event_log_parser.
2018-09-28 mbonadei@webrtc.org Remove deprecated field_trial_default and metrics_default.
2018-09-28 peah@webrtc.org AEC3: Remove killswitches in AecState
2018-09-28 phensman@webrtc.org Add option to call VMAF in compare_videos.py.


Created with:
  gclient setdep -r src/third_party/webrtc@156d11ddd939

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:None,chromium:None,chromium:888417,chromium:877018,chromium:877018,chromium:b/116768521
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I6c08ca97517d14263adc6de3b649334aa9a895a1
Reviewed-on: https://chromium-review.googlesource.com/1253438
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#595401}
[modify] https://crrev.com/185d120cf604691b33d9703cd3b695a31310610d/DEPS

Project Member

Comment 42 by bugdroid1@chromium.org, Oct 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5830d00a6a86c79bbd37a5b7f5c874c5064f5b6

commit c5830d00a6a86c79bbd37a5b7f5c874c5064f5b6
Author: Patrik Höglund <phoglund@chromium.org>
Date: Wed Oct 10 07:46:24 2018

Move the WebRTC FYI waterfall to the ci acl_set.

This is mostly so I can bump build numbers on the flag day.
I think this waterfall should be on the ci acl_set anyway.

Tbr: vadimsh@chromium.org
Bug:  chromium:877018 
Change-Id: I9ee9768d2aca3e7d6809d763f9b4fdc9a6984b2d
Reviewed-on: https://chromium-review.googlesource.com/c/1273035
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598249}
[modify] https://crrev.com/c5830d00a6a86c79bbd37a5b7f5c874c5064f5b6/infra/config/global/cr-buildbucket.cfg

Project Member

Comment 43 by bugdroid1@chromium.org, Oct 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/372dd1882fa85750623989d4a220ca534f8927a2

commit 372dd1882fa85750623989d4a220ca534f8927a2
Author: Patrik Höglund <phoglund@chromium.org>
Date: Tue Oct 16 06:42:27 2018

Remove chromium.webrtc.fyi buildbot bots from luci-milo.

LUCI is prod now for this master and the buildbot master is being
turned down.

Bug:  chromium:877018 
Change-Id: I7e71f0da927e1f2d8f79857814f2fbce831894b8
Reviewed-on: https://chromium-review.googlesource.com/c/1280267
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599892}
[modify] https://crrev.com/372dd1882fa85750623989d4a220ca534f8927a2/infra/config/global/luci-milo.cfg

Project Member

Comment 44 by bugdroid1@chromium.org, Oct 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/53fc481a017024d5f319c8a24cb4aebaa010441d

commit 53fc481a017024d5f319c8a24cb4aebaa010441d
Author: Patrik Höglund <phoglund@chromium.org>
Date: Tue Oct 16 11:42:07 2018

Move chromium.webrtc config source-side.

This means the bots will look up their test suites from
test_suites.pyl and its generated json files instead.
This is how other chromium_tests users do it, so we
should do the same.

The bot configs are unchanged except that tests aren't
added here anymore, but listed src-side as described
above.

Bug:  877018 
Change-Id: Ic0a3d301ce659167fb337bf2d38cfa438603cb8a
Reviewed-on: https://chromium-review.googlesource.com/c/1280247
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>

[modify] https://crrev.com/53fc481a017024d5f319c8a24cb4aebaa010441d/scripts/slave/recipe_modules/chromium_tests/chromium_webrtc_fyi.py
[modify] https://crrev.com/53fc481a017024d5f319c8a24cb4aebaa010441d/scripts/slave/recipe_modules/chromium_tests/chromium_webrtc.py
[modify] https://crrev.com/53fc481a017024d5f319c8a24cb4aebaa010441d/scripts/slave/recipe_modules/chromium_tests/tryserver_webrtc.py

Project Member

Comment 45 by bugdroid1@chromium.org, Oct 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81928eb265af7b0724b582026d36ed5a80025855

commit 81928eb265af7b0724b582026d36ed5a80025855
Author: Patrik Höglund <phoglund@chromium.org>
Date: Tue Oct 16 11:44:33 2018

Configure chromium.webrtc test suites.

This should make the chromium.webrtc waterfall work like the old
test config in recipes. It incorporates some fixes made in the
recipe code and creates composite test suites for the chromium.webrtc
bots.

Bug:  877018 
Change-Id: I11b91c4e9516844086978b5a63b816576197585b
Reviewed-on: https://chromium-review.googlesource.com/c/1280669
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599947}
[delete] https://crrev.com/43b75585c11e9aee0bc40f3a8a26fb70c4216c2d/testing/buildbot/chromium.webrtc.experimental.json
[modify] https://crrev.com/81928eb265af7b0724b582026d36ed5a80025855/testing/buildbot/chromium.webrtc.json
[modify] https://crrev.com/81928eb265af7b0724b582026d36ed5a80025855/testing/buildbot/test_suites.pyl
[modify] https://crrev.com/81928eb265af7b0724b582026d36ed5a80025855/testing/buildbot/waterfalls.pyl

Project Member

Comment 46 by bugdroid1@chromium.org, Oct 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58c0355850303c73aa92189190e7068b95bcca7e

commit 58c0355850303c73aa92189190e7068b95bcca7e
Author: Patrik Höglund <phoglund@chromium.org>
Date: Tue Oct 16 13:59:48 2018

Inline filter file for WebRTC non swarmed tests.

Appears you can't have filter files for non swarmed tests.

Bug:  877018 
Tbr: kbr@chromium.org
Change-Id: If294ff3679889978fe27e7eced642b00f7102508
Reviewed-on: https://chromium-review.googlesource.com/c/1283289
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599965}
[modify] https://crrev.com/58c0355850303c73aa92189190e7068b95bcca7e/testing/buildbot/chromium.webrtc.json
[modify] https://crrev.com/58c0355850303c73aa92189190e7068b95bcca7e/testing/buildbot/filters/BUILD.gn
[delete] https://crrev.com/c546cc71380f01685a84ff04f7704b5cabdd1820/testing/buildbot/filters/webrtc_perf.browser_tests.filter
[modify] https://crrev.com/58c0355850303c73aa92189190e7068b95bcca7e/testing/buildbot/test_suites.pyl

Project Member

Comment 47 by bugdroid1@chromium.org, Oct 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9727e94dad3174e8fd3224eb775a121718cbeee

commit d9727e94dad3174e8fd3224eb775a121718cbeee
Author: Patrik Höglund <phoglund@chromium.org>
Date: Tue Oct 16 14:06:55 2018

Make WebRTC content_browsertests swarmed again.

I made a mistake in my earlier config CL: these tests are supposed
to be swarmed. There are no phones on the Android tester so it fails
when it tries to run locally.

Bug:  877018 
Tbr: kbr@chromium.org
Change-Id: Id1cdef0c68ce3a50c9b7d2dec6bcd0d4c8f3e86b
Reviewed-on: https://chromium-review.googlesource.com/c/1282950
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599967}
[modify] https://crrev.com/d9727e94dad3174e8fd3224eb775a121718cbeee/testing/buildbot/chromium.webrtc.json
[modify] https://crrev.com/d9727e94dad3174e8fd3224eb775a121718cbeee/testing/buildbot/test_suites.pyl

Project Member

Comment 48 by bugdroid1@chromium.org, Oct 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/b84f1a177990d9303514ee83ed4891ed7a3dc959

commit b84f1a177990d9303514ee83ed4891ed7a3dc959
Author: Patrik Höglund <phoglund@chromium.org>
Date: Wed Oct 17 09:27:41 2018

Delete chromium.webrtc.fyi master.

LUCI is prod for this master.

This also cleans up some migrated masters from logdog-params.

Bug:  chromium:877018 
Change-Id: I63bc7f215f4c24e250f54bdfb420bca0d2e36c85
Reviewed-on: https://chromium-review.googlesource.com/c/1280243
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Auto-Submit: Patrik Höglund <phoglund@chromium.org>

[delete] https://crrev.com/09a25a8628030eff9cf3929910c891abc8a0842f/masters/master.chromium.webrtc.fyi/master_source_cfg.py
[modify] https://crrev.com/b84f1a177990d9303514ee83ed4891ed7a3dc959/tests/masters_test.py
[delete] https://crrev.com/09a25a8628030eff9cf3929910c891abc8a0842f/masters/master.chromium.webrtc.fyi/slaves.cfg
[delete] https://crrev.com/09a25a8628030eff9cf3929910c891abc8a0842f/masters/master.chromium.webrtc.fyi/master.cfg
[delete] https://crrev.com/09a25a8628030eff9cf3929910c891abc8a0842f/masters/master.chromium.webrtc.fyi/master_builders_cfg.py
[delete] https://crrev.com/09a25a8628030eff9cf3929910c891abc8a0842f/masters/master.chromium.webrtc.fyi/templates/description.html
[delete] https://crrev.com/09a25a8628030eff9cf3929910c891abc8a0842f/masters/master.chromium.webrtc.fyi/Makefile
[delete] https://crrev.com/09a25a8628030eff9cf3929910c891abc8a0842f/masters/master.chromium.webrtc.fyi/OWNERS
[modify] https://crrev.com/b84f1a177990d9303514ee83ed4891ed7a3dc959/scripts/slave/logdog-params.pyl
[delete] https://crrev.com/09a25a8628030eff9cf3929910c891abc8a0842f/masters/master.chromium.webrtc.fyi/master_site_config.py

chromium.webrtc.fyi is now completely migrated and the old master turned down. Now onto chromium.webrtc...
Project Member

Comment 50 by bugdroid1@chromium.org, Oct 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/df78c5197a24b8eb507312d5df4e5b5156605e21

commit df78c5197a24b8eb507312d5df4e5b5156605e21
Author: Patrik Höglund <phoglund@chromium.org>
Date: Wed Oct 17 13:34:05 2018

Temporarily add back browser tests to chromium.webrtc bots.

It appears they stop uploading to the perf dashboard in test_suites.pyl.
Let's put them back and remove from test_suites.pyl for now while
we figure out a better solution. Hopefully this means it will take
one test from this config and the others from test_suites.pyl.

Bug:  chromium:877018 , chromium:888429
Tbr: kbr@chromium.org
Change-Id: I0e589457a3f29d7bd8fa5326a8947e838e9dc80c
Reviewed-on: https://chromium-review.googlesource.com/c/1286458
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Reviewed-by: Patrik Höglund <phoglund@chromium.org>

[modify] https://crrev.com/df78c5197a24b8eb507312d5df4e5b5156605e21/scripts/slave/recipe_modules/chromium_tests/chromium_webrtc.py

Project Member

Comment 51 by bugdroid1@chromium.org, Oct 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/ff9ee116d7efbff64a6a62a80d59348de06d1d10

commit ff9ee116d7efbff64a6a62a80d59348de06d1d10
Author: Patrik Höglund <phoglund@chromium.org>
Date: Wed Oct 17 15:46:30 2018

Fix mistake in test list from previous CL.

Bug:  877018 
Tbr: kbr@chromium.org
Change-Id: I285cfac702fc89aa4b3d3b9976f4f5926ddaa607
Reviewed-on: https://chromium-review.googlesource.com/c/1286653
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>

[modify] https://crrev.com/ff9ee116d7efbff64a6a62a80d59348de06d1d10/scripts/slave/recipe_modules/chromium_tests/chromium_webrtc.py

Project Member

Comment 52 by bugdroid1@chromium.org, Oct 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/58e28a463675f201c911a93fb826e5fa1e0f307c

commit 58e28a463675f201c911a93fb826e5fa1e0f307c
Author: Patrik Höglund <phoglund@chromium.org>
Date: Thu Oct 18 16:43:27 2018

Fix id for win7 bot.

Turns out the id is -7 rather than -win7.

Bug:  877018 
Change-Id: I341b60cbc30c607ee0ef4c75950baab66933a3b0
Reviewed-on: https://chromium-review.googlesource.com/c/1288410
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>

[modify] https://crrev.com/58e28a463675f201c911a93fb826e5fa1e0f307c/scripts/slave/recipe_modules/chromium_tests/chromium_webrtc.py

Project Member

Comment 53 by bugdroid1@chromium.org, Nov 15

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/5325d50e24c3d533d5f5a168a7790560ccbe13cd

commit 5325d50e24c3d533d5f5a168a7790560ccbe13cd
Author: Patrik Höglund <phoglund@chromium.org>
Date: Thu Nov 15 08:50:07 2018

Project Member

Comment 55 by bugdroid1@chromium.org, Nov 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/254e299adaf8f1372bfeedc4ab89d48a855e4bf6

commit 254e299adaf8f1372bfeedc4ab89d48a855e4bf6
Author: Patrik Höglund <phoglund@chromium.org>
Date: Thu Nov 15 10:59:56 2018

Configure chromium.webrtc on LUCI, flip over Linux builder-tester.

This will switch over to LUCI on the existing buildbot machines.
This waterfall is a non-critical postsubmit waterfall so we
believe we can take a few days of downtime on it if necessary.
The machines in question have webcams and exotic configs, so
standing up a new waterfall is rather expensive.

The plan is
1) take linux bots out of the old master and restart
2) swarm-bootstrap current chromium.webrtc machines
2a) maybe delete old stuff off machines (?)
3) land CL to infradata that makes machines available as
   dimensions:<builder name>
4) Land this CL

Certainly, if the above fails it's going to be hard to go back
but I think it will work :)

Tbr: jbudorick@chromium.org
Bug:  877018 
Change-Id: I7ddb3e8764e717b29de9c0eeb55cf6bc2ccb002a
Reviewed-on: https://chromium-review.googlesource.com/c/1288596
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608316}
[modify] https://crrev.com/254e299adaf8f1372bfeedc4ab89d48a855e4bf6/infra/config/global/cr-buildbucket.cfg
[modify] https://crrev.com/254e299adaf8f1372bfeedc4ab89d48a855e4bf6/infra/config/global/luci-milo.cfg
[modify] https://crrev.com/254e299adaf8f1372bfeedc4ab89d48a855e4bf6/infra/config/global/luci-scheduler.cfg
[modify] https://crrev.com/254e299adaf8f1372bfeedc4ab89d48a855e4bf6/testing/buildbot/chromium.webrtc.json
[modify] https://crrev.com/254e299adaf8f1372bfeedc4ab89d48a855e4bf6/testing/buildbot/waterfalls.pyl

Project Member

Comment 56 by bugdroid1@chromium.org, Nov 15

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/c00943b407e76550df4b2e19c30f4a883d9c39b2

commit c00943b407e76550df4b2e19c30f4a883d9c39b2
Author: Patrik Höglund <phoglund@chromium.org>
Date: Thu Nov 15 12:16:10 2018

Project Member

Comment 57 by bugdroid1@chromium.org, Nov 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0779bc1ada5022dc0c98712e8a41505d62920dcf

commit 0779bc1ada5022dc0c98712e8a41505d62920dcf
Author: Patrik Höglund <phoglund@chromium.org>
Date: Thu Nov 15 13:53:44 2018

Rename WebRTC Linux builder.

Missed mb_config.pyl in my previous CL.

Bug:  877018 
Change-Id: I897caf43b76190a8e59e07e99436f5b5e48f1b07
Tbr: jbudorick@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1337342
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608350}
[modify] https://crrev.com/0779bc1ada5022dc0c98712e8a41505d62920dcf/tools/mb/mb_config.pyl

Project Member

Comment 58 by bugdroid1@chromium.org, Nov 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/12748af33908d138d71019cbf9b99e8cbf1d00db

commit 12748af33908d138d71019cbf9b99e8cbf1d00db
Author: Patrik Höglund <phoglund@chromium.org>
Date: Thu Nov 15 16:50:13 2018

Hack to fix WebRTC perf tests on LUCI.

TBR: oprypin@google.com
Bug:  877018 
Change-Id: Ie2d7980d3b4e01bbb18c0173e0ddbf9b94908b8d
Reviewed-on: https://chromium-review.googlesource.com/c/1337595
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Reviewed-by: Oleh Prypin <oprypin@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Oleh Prypin <oprypin@chromium.org>
Auto-Submit: Patrik Höglund <phoglund@chromium.org>

[modify] https://crrev.com/12748af33908d138d71019cbf9b99e8cbf1d00db/scripts/slave/recipe_modules/chromium_tests/steps.py

Project Member

Comment 59 by bugdroid1@chromium.org, Nov 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/6d2fd267a399f1d2d3288739a52ec3476c1ea1fc

commit 6d2fd267a399f1d2d3288739a52ec3476c1ea1fc
Author: Oleh Prypin <oprypin@chromium.org>
Date: Thu Nov 15 19:36:38 2018

Revert "Hack to fix WebRTC perf tests on LUCI."

This reverts commit 12748af33908d138d71019cbf9b99e8cbf1d00db.

Reason for revert: The change had no effect.

Original change's description:
> Hack to fix WebRTC perf tests on LUCI.
> 
> TBR: oprypin@google.com
> Bug:  877018 
> Change-Id: Ie2d7980d3b4e01bbb18c0173e0ddbf9b94908b8d
> Reviewed-on: https://chromium-review.googlesource.com/c/1337595
> Reviewed-by: Patrik Höglund <phoglund@chromium.org>
> Reviewed-by: Oleh Prypin <oprypin@chromium.org>
> Commit-Queue: Patrik Höglund <phoglund@chromium.org>
> Commit-Queue: Oleh Prypin <oprypin@chromium.org>
> Auto-Submit: Patrik Höglund <phoglund@chromium.org>

TBR=phoglund@chromium.org,oprypin@chromium.org

Change-Id: I1422b464b8700a17fc9d15012d3a9fb9f0efcc1b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  877018 
Reviewed-on: https://chromium-review.googlesource.com/c/1337437
Reviewed-by: Oleh Prypin <oprypin@chromium.org>
Commit-Queue: Oleh Prypin <oprypin@chromium.org>

[modify] https://crrev.com/6d2fd267a399f1d2d3288739a52ec3476c1ea1fc/scripts/slave/recipe_modules/chromium_tests/steps.py

Project Member

Comment 60 by bugdroid1@chromium.org, Nov 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5ded28260fdd9b1b15b2f92186be9be5cbdeb29

commit a5ded28260fdd9b1b15b2f92186be9be5cbdeb29
Author: Oleh Prypin <oprypin@chromium.org>
Date: Fri Nov 16 07:17:05 2018

Add perf_dashboard_machine_group property to chromium.webrtc bots

This seems to be the only way to pass this property to runtest.py if we're not on Buildbot:
https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium/api.py?rcl=0547a2d019f638868abffa0bd525d9e0ea9631d1&l=709
https://cs.chromium.org/chromium/build/scripts/slave/runtest.py?l=367&rcl=ccdd71cae2e6bce819a6d8f8b1dcaa27a9e31141

TBR: jbudorick@chromium.org
Bug:  877018 
Change-Id: Icadb0abfd036a90735a6b194a0de1958e49107f3
Reviewed-on: https://chromium-review.googlesource.com/c/1338185
Commit-Queue: Oleh Prypin <oprypin@chromium.org>
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608689}
[modify] https://crrev.com/a5ded28260fdd9b1b15b2f92186be9be5cbdeb29/infra/config/global/cr-buildbucket.cfg

Cc: artit@chromium.org
The bots in chromium.webrtc have been swarm-bootstrapped, so I might as well turn it down. There's kind of no way back anyway. I will now run:

cit restart -s offline chromium.webrtc
Project Member

Comment 62 by bugdroid1@chromium.org, Nov 29

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/aeb201e3e97f125f33c6ab91a367a9cc0cd0f871

commit aeb201e3e97f125f33c6ab91a367a9cc0cd0f871
Author: Patrik Höglund <phoglund@chromium.org>
Date: Thu Nov 29 09:28:49 2018

Project Member

Comment 64 by bugdroid1@chromium.org, Nov 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/850e921dcbeff1c9bd221f682d062f40d4d124b1

commit 850e921dcbeff1c9bd221f682d062f40d4d124b1
Author: Patrik Höglund <phoglund@chromium.org>
Date: Thu Nov 29 11:22:47 2018

Rename chromium.webrtc bots for LUCI migration.

As a part of the LUCI migration, the bots change name. Also clean up
some dead bots.

Bug:  877018 
Change-Id: I5d16c2984d2fbf55b8fecf02e2dfa11ae8c4bdd2
Reviewed-on: https://chromium-review.googlesource.com/c/1352198
Reviewed-by: Oleh Prypin <oprypin@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>

[modify] https://crrev.com/850e921dcbeff1c9bd221f682d062f40d4d124b1/scripts/slave/recipe_modules/chromium_tests/chromium_webrtc.py

Project Member

Comment 65 by bugdroid1@chromium.org, Nov 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a4417e0942c8c496d13ca65cc1f09dd5d585962

commit 3a4417e0942c8c496d13ca65cc1f09dd5d585962
Author: Patrik Höglund <phoglund@chromium.org>
Date: Thu Nov 29 14:21:42 2018

Fix incorrect chromium.webrtc dimensions for win7 and win8.

These are called WindowsServer2008 and Windows-2012ServerR2-SP0 and
stuff like that nowadays. This CL just drops the OS dimension since
bots.cfg ensures each builder runs on the right OS, anyway.

Tbr: jbudorick@chromium.org
Bug:  877018 
Change-Id: Ib71ee5f1d26ed90b38fb0b9868994f4bd0c29ad3
Reviewed-on: https://chromium-review.googlesource.com/c/1354924
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612183}
[modify] https://crrev.com/3a4417e0942c8c496d13ca65cc1f09dd5d585962/infra/config/global/cr-buildbucket.cfg

Project Member

Comment 66 by bugdroid1@chromium.org, Nov 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0186601471d3a5866736a3c8146b8f23113f379b

commit 0186601471d3a5866736a3c8146b8f23113f379b
Author: Patrik Höglund <phoglund@chromium.org>
Date: Thu Nov 29 15:25:59 2018

Fix chromium.webrtc win dimensions.

I made a mistake in my previous patch and actually removed dimensions
for chromium.webrtc.fyi. That's fine though, it made sense to do
anyway. Here is the correct fix.

Bug:  877018 
Change-Id: Ia45c80a3c4bb2487198766e936c28f953c4a4e41
Reviewed-on: https://chromium-review.googlesource.com/c/1355182
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612199}
[modify] https://crrev.com/0186601471d3a5866736a3c8146b8f23113f379b/infra/config/global/cr-buildbucket.cfg

Project Member

Comment 67 by bugdroid1@chromium.org, Nov 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc8aad4eb501f27dfb975ddcec2aa50e3a16e0ee

commit bc8aad4eb501f27dfb975ddcec2aa50e3a16e0ee
Author: Patrik Höglund <phoglund@chromium.org>
Date: Fri Nov 30 07:00:10 2018

Make it possible for humans to debug WebRTC video tests on bots.

The bot fails with stale video, let's see what it looks like.

Bug:  877018 
Change-Id: I9432dcfa9d420ea44bef14f81e502b11eb840f84
Reviewed-on: https://chromium-review.googlesource.com/c/1355159
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612588}
[modify] https://crrev.com/bc8aad4eb501f27dfb975ddcec2aa50e3a16e0ee/chrome/test/data/webrtc/webrtc_jsep01_test.html

Project Member

Comment 68 by bugdroid1@chromium.org, Nov 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70016768d9859af64eb1f4c3b5f212424e5701bc

commit 70016768d9859af64eb1f4c3b5f212424e5701bc
Author: Patrik Höglund <phoglund@chromium.org>
Date: Fri Nov 30 10:04:51 2018

Remove dead bots from chromium.webrtc waterfalls in luci-milo.cfg.

Long-running bots have been removed and the buildbot master is gone.

Tbr: jbudorick@chromium.org
Bug:  chromium:877018 
Change-Id: If9e6ccbcf4ccb2e31ae1a76bb44ebdd22401a2fb
Reviewed-on: https://chromium-review.googlesource.com/c/1356580
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612607}
[modify] https://crrev.com/70016768d9859af64eb1f4c3b5f212424e5701bc/infra/config/global/luci-milo.cfg

Status: Fixed (was: Assigned)
The only remaining patch out is for deleting the old master code, so all work here is done.
Project Member

Comment 70 by bugdroid1@chromium.org, Nov 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/fe9a1622f39a21e983caee636d3ef72f76d927c0

commit fe9a1622f39a21e983caee636d3ef72f76d927c0
Author: Patrik Höglund <phoglund@chromium.org>
Date: Fri Nov 30 17:10:41 2018

Delete master chromium.webrtc.

It has been migrated to LUCI.

Bug:  877018 
Change-Id: Ifb5d4d58a0bd77dab5794e8c22b5760744117ed9
Reviewed-on: https://chromium-review.googlesource.com/c/1356519
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
Auto-Submit: Patrik Höglund <phoglund@chromium.org>

[delete] https://crrev.com/bd261424c727962e7c51643f0746e81109c4bbe7/masters/master.chromium.webrtc/master.cfg
[modify] https://crrev.com/fe9a1622f39a21e983caee636d3ef72f76d927c0/tests/masters_test.py
[delete] https://crrev.com/bd261424c727962e7c51643f0746e81109c4bbe7/masters/master.chromium.webrtc/master_source_cfg.py
[delete] https://crrev.com/bd261424c727962e7c51643f0746e81109c4bbe7/masters/master.chromium.webrtc/slaves.cfg
[delete] https://crrev.com/bd261424c727962e7c51643f0746e81109c4bbe7/masters/master.chromium.webrtc/master_builders_cfg.py
[delete] https://crrev.com/bd261424c727962e7c51643f0746e81109c4bbe7/masters/master.chromium.webrtc/OWNERS
[delete] https://crrev.com/bd261424c727962e7c51643f0746e81109c4bbe7/masters/master.chromium.webrtc/Makefile
[delete] https://crrev.com/bd261424c727962e7c51643f0746e81109c4bbe7/masters/master.chromium.webrtc/master_site_config.py
[delete] https://crrev.com/bd261424c727962e7c51643f0746e81109c4bbe7/masters/master.chromium.webrtc/templates/description.html

Blockedon: 911096

Sign in to add a comment