New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 877009 link

Starred by 2 users
Status: Fixed
Owner:
alancutter@chromium.org
Closed: Aug 27
Cc:
dominickn@chromium.org
█ bgalbs@google.com
pcovell@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

Desktop PWAs: Incorrect tab/window is closed when uninstalling PWA

Project Member Reported by alancutter@chromium.org, Aug 23 
Chrome Version: 70
OS: Windows

What steps will reproduce the problem?
(1) Install PWA (soft-puppy.glitch.me > app menu > Install)
(2) Open chrome:apps
(3) Open new Soft Puppy window > app menu > Open in Chrome
(3) Uninstall Soft Puppy

What is the expected result?

The window should close and the tab should stay open.

What happens instead?

The window stays open and the tab closes.

Please use labels and text to provide additional information.

If this is a regression (i.e., worked before), please consider using the
bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help
us identify the root cause and more rapidly triage the issue.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.
expected.webm
2.7 MB View Download
actual.webm
2.5 MB View Download

Comment 1 by alancutter@chromium.org, Aug 23

Labels: M-70
Marking as P1 for M70 because installing then uninstalling is probably going to be a common occurrence. Also the left over window crashes if you open the app menu in a future patch with this bug...

Comment 2 by mgiuca@chromium.org, Aug 24 

Good catch!
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00eb4b9cc96f6fae7e923eece76321d3104f88fe

commit 00eb4b9cc96f6fae7e923eece76321d3104f88fe
Author: Alan Cutter <alancutter@chromium.org>
Date: Fri Aug 24 06:55:53 2018

Fix incorrect PWA window/tab closing on uninstallation

This CL ensures the TabHelper of a PWA WebContents is updated to indicate
whether it has it's own "extension" window or not to ensure it gets
cleaned up appropriately on uninstall.

Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=354491&signed_aid=mELqu3AB-QBQpk1qojP7qg==&inline=1
After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=354490&signed_aid=4RqFYkoMkmsndSMnrq5inA==&inline=1

Bug:  877009 
Change-Id: I81e7888260a40df68f5e9a5443ea2a815b8a686f
Reviewed-on: https://chromium-review.googlesource.com/1186388
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585732}
[modify] https://crrev.com/00eb4b9cc96f6fae7e923eece76321d3104f88fe/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc
[modify] https://crrev.com/00eb4b9cc96f6fae7e923eece76321d3104f88fe/chrome/browser/ui/browser_browsertest.cc
[modify] https://crrev.com/00eb4b9cc96f6fae7e923eece76321d3104f88fe/chrome/browser/ui/browser_commands.cc
[modify] https://crrev.com/00eb4b9cc96f6fae7e923eece76321d3104f88fe/chrome/browser/ui/browser_commands.h
[modify] https://crrev.com/00eb4b9cc96f6fae7e923eece76321d3104f88fe/chrome/browser/ui/extensions/hosted_app_browser_controller.cc
[modify] https://crrev.com/00eb4b9cc96f6fae7e923eece76321d3104f88fe/chrome/browser/ui/extensions/hosted_app_browsertest.cc

Comment 4 by alancutter@chromium.org, Aug 27

Status: Fixed (was: Assigned)
►

Sign in to add a comment