factory: add arguments in finalize to set report upload retry interval |
|||
Issue descriptionChrome Version: ToT OS: ChromeOS It is requested that we can customize retry interval in finalize report upload. The current finalize always use default 60s interval. It is better to add another argument for maximum fail times. If the upload fails too many times it can skip uploading.
,
Sep 7
There are three CLs pending CL:1186389 CL:1186566 CL:1188061
,
Sep 7
ok - I guess then assigning back to you is easier :)
,
Sep 20
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/3d4b0c037fb175f98e1bab410ad3f43a97e9db32 commit 3d4b0c037fb175f98e1bab410ad3f43a97e9db32 Author: Cheng-Han Yang <chenghan@google.com> Date: Thu Sep 20 12:15:18 2018 gooftool: Add an argument to specify upload retry interval Add an argument in gooftool and finalize pytest to specify upload retry interval. If not specified, use the default value. BUG= chromium:877002 TEST=make test; manually test on DUT Change-Id: I7f130cf36b462d77df76cc9e0c3e0efd705126d5 Reviewed-on: https://chromium-review.googlesource.com/1186389 Commit-Ready: Cheng-Han Yang <chenghan@chromium.org> Tested-by: Cheng-Han Yang <chenghan@chromium.org> Reviewed-by: Yong Hong <yhong@google.com> [modify] https://crrev.com/3d4b0c037fb175f98e1bab410ad3f43a97e9db32/py/test/pytests/finalize.py [modify] https://crrev.com/3d4b0c037fb175f98e1bab410ad3f43a97e9db32/py/gooftool/report_upload.py [modify] https://crrev.com/3d4b0c037fb175f98e1bab410ad3f43a97e9db32/py/gooftool/commands.py
,
Sep 21
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/31a3bd95b6c9f219f1e4606255c0a72d440b6d3c commit 31a3bd95b6c9f219f1e4606255c0a72d440b6d3c Author: Cheng-Han Yang <chenghan@google.com> Date: Fri Sep 21 13:58:44 2018 gooftool: Add an argument to specify number of upload tries. Add an argument in gooftool and finalize pytest to specify number of tries to upload report. Set the argument to 0 to retry infinitely. Remove special case for retry_interval=0 to disable retrying. It can be done by max_retry_times=1. BUG= chromium:877002 TEST=make test; manually test on DUT Change-Id: Ia85f95320c0fc8bc90724864f67c22b19f27c132 Reviewed-on: https://chromium-review.googlesource.com/1186566 Commit-Ready: Cheng-Han Yang <chenghan@chromium.org> Tested-by: Cheng-Han Yang <chenghan@chromium.org> Reviewed-by: Yong Hong <yhong@google.com> [modify] https://crrev.com/31a3bd95b6c9f219f1e4606255c0a72d440b6d3c/py/test/pytests/finalize.py [modify] https://crrev.com/31a3bd95b6c9f219f1e4606255c0a72d440b6d3c/py/gooftool/report_upload.py [modify] https://crrev.com/31a3bd95b6c9f219f1e4606255c0a72d440b6d3c/py/gooftool/commands.py
,
Sep 28
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/c1697e2d3a62b0c5313da105b3ae3c94cf3d8f3d commit c1697e2d3a62b0c5313da105b3ae3c94cf3d8f3d Author: Cheng-Han Yang <chenghan@google.com> Date: Fri Sep 28 02:45:06 2018 gooftool: Allow report upload fail and continue finalize Add an argument to allow report upload fail in finalize. When the flag is set and upload fails, skip upload and continue finalze instead of raising an exception. BUG= chromium:877002 TEST=make test; manually test on DUT Change-Id: Iecb355d89cbc68ca81c7c83aef90844dab1af1d5 Reviewed-on: https://chromium-review.googlesource.com/1188061 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Cheng-Han Yang <chenghan@chromium.org> Reviewed-by: Wei-Han Chen <stimim@chromium.org> [modify] https://crrev.com/c1697e2d3a62b0c5313da105b3ae3c94cf3d8f3d/py/test/pytests/finalize.py [modify] https://crrev.com/c1697e2d3a62b0c5313da105b3ae3c94cf3d8f3d/py/gooftool/report_upload.py [modify] https://crrev.com/c1697e2d3a62b0c5313da105b3ae3c94cf3d8f3d/py/gooftool/commands.py
,
Sep 28
|
|||
►
Sign in to add a comment |
|||
Comment 1 by hungte@chromium.org
, Sep 7Owner: fshao@chromium.org
Status: Assigned (was: Untriaged)