New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 876997 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Aug 27
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Newer features work even when attaching to debugger using old protocol version

Reported by m...@mostlystatic.com, Aug 23

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.106 Safari/537.36

Steps to reproduce the problem:
1. Open http://www.example.com/
2. In a chrome extension with debugger permissions run this code:

chrome.debugger.getTargets(function(targets){
   const target = targets.find(t => t.url === "http://www.example.com/")
   const targetArg = { targetId: target.id}
   chrome.debugger.attach(targetArg, "1.3", function(){
     chrome.debugger.sendCommand(
        targetArg,
        "Network.setRequestInterception",
        { patterns: [{ urlPattern: "*", interceptionStage: "Request" }] }
     )
     chrome.debugger.onEvent.addListener(console.log)
   })
})

3. Reload example.com

What is the expected behavior?
Request interception is not supported in the 1.3 version of the DevTools Protocol https://chromedevtools.github.io/devtools-protocol/1-3/Network

Therefore:
- Network.setRequestInterception should fail
- There should be no "Network.requestIntercepted" events being fired

However, everything works fine. (Same behavior when specifying version 1.2.)

What went wrong?
Everything works as it would for the tip-of-tree protocol version and requests are intercepted.

Did this work before? N/A 

Chrome version: 68.0.3440.106  Channel: stable
OS Version: OS X 10.11.6
Flash Version: 

The goal here is to prevent developers unknowingly relying on unstable APIs.

This shouldn't be done retroactively for version 1.0-1.3 as it would break existing extensions.
 
Labels: Needs-Triage-M68
Cc: krajshree@chromium.org
Labels: Triaged-ET Needs-Feedback
matt@ - Thanks for filing the issue...!!

Could you please provide a sample extension or url to test the issue from TE-end.
This will help us in triaging the issue further.

Thanks...!!

Status: WontFix (was: Unconfirmed)
>> The goal here is to prevent developers unknowingly relying on unstable APIs.

While I completely agree with this, we rely upon the documentation when it comes to the experimental methods and versioning. Users will be able to use experimental methods in 1.3 at their own risk for the sake of hackability of the protocol.

Sign in to add a comment