Unable to close PiP window using 'Alt + F4' keyboard shortcut in Windows OS.
Reported by
avsha...@etouch.net,
Aug 23
|
||||
Issue descriptionChrome Version : 69.0.3497.57 (Official Build) e402c249d541b436015a3068d1867bf697ff4c9e-refs/branch-heads/3497@{#783} 32/64 bit OS : Windows(7, 8, 8.1, 10) Test URL : http://googlechrome.github.io/samples/picture-in-picture What steps will reproduce the problem? 1. Launch chrome and navigate to above test URL. 2. Click on three dot menu icon in the video and switch to 'Picture-in-Picture' mode. 3. Now try to close PiP window using 'Alt + F4' keyboard shortcut and observe. Actual Result : Unable to close PiP window using 'Alt + F4' keys (though the same keyboard shortcut is present in right click context menu). Expected Result : PiP window should get closed when user presses 'Alt + F4' keyboard shortcut. This is a Non-regression issue seen from M-69 series, as the new 'Picture-in-picture' feature was introduced in build #69.0.3483.0 Note : 1. This issue can be reproduced with any test URL. 2. 'Alt + F4' shortcut works as expected in PiP window on Linux(14.04 LTS) OS. 3. Unable to reproduce this issue in Mac(10.12.6, 10.13.1, 10.14, 10.13.6) OS. 4. Issue is also reproducible in latest Canary build #70.0.3530.0 Kindly review the attached screen-cast for reference. Thank you..!
,
Aug 28
,
Aug 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c85f48c47cc6bedf4de64f10faaca4c2d67148ad commit c85f48c47cc6bedf4de64f10faaca4c2d67148ad Author: Jennifer Apacible <apacible@chromium.org> Date: Wed Aug 29 02:03:25 2018 [Picture in Picture] Support Alt+F4 to close window on Windows OS. On Windows OS, Alt+F4 is used to close windows. This change handles this key combination on Windows. Bug: 876995 Change-Id: I48cf3ba26c38be30d5e2eb45663dc33cf5235d62 Reviewed-on: https://chromium-review.googlesource.com/1194681 Commit-Queue: apacible <apacible@chromium.org> Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org> Cr-Commit-Position: refs/heads/master@{#586994} [modify] https://crrev.com/c85f48c47cc6bedf4de64f10faaca4c2d67148ad/chrome/browser/ui/views/overlay/overlay_window_views.cc
,
Aug 29
,
Aug 30
Update : --------- Tested above issue in Canary build #70.0.3536.0 on Windows(7, 8, 8.1, 10) OS and the issue is fixed. Now, user can close PiP window using 'Alt + F4' keyboard shortcut, hence adding TE-Verified labels. Kindly review an attached screen-cast for reference. Thank you..! |
||||
►
Sign in to add a comment |
||||
Comment 1 by nyerramilli@chromium.org
, Aug 23