Consistent failures on webui_polymer2_browser_tests (CrSettingsPrivacyPageTest.All, CrExtensionsPackDialogTest.PackSuccess)

We got consistent failures report at Sheriff-O-Matic, Mac10.12 Tests [7 out of the last 7 builds have failed].

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests
CrSettingsPrivacyPageTest.All
CrExtensionsPackDialogTest.PackSuccess

Regression ranges: chromium: 585122 - 585171
https://chromium.googlesource.com/chromium/src/+log/ae376588a7f3735891160342bd3567cf616a4b0a%5E..a75983ce848a502513d4be86e91afb7bfc8418fe?pretty=fuller&n=

It looks failures started at: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/15035

I couldn't find a clear culprit there.

Could UI>Settings owners have a chance to take a look?

These are the list of the failing tests:
-CrExtensionsPackDialogTest.PackWarning
-CrSettingsPrivacyPageTest.All
-CrExtensionsPackDialogTest.PackSuccess

And from the regression range f44299c2123609f028752778b6a50f68eb7cc5a4 looks like the mostly related one.

kaznacheev@ Please feel free to assign it back to me if you are not the proper owner. 

The files affected by this change are part of ChromeOS Launcher. This code does should not be linked into the Chrome binary on other platforms such as Mac.

twellington@chromium.org please take a look or help find an owner.

sheriff says: this is causing tree redness since https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/15035

my best guess is https://chromium-review.googlesource.com/c/chromium/src/+/1183684

Errors are:

[ RUN      ] CrSettingsPrivacyPageTest.All
[12519:4611:0822/133308.980906:WARNING:notification_platform_bridge_mac.mm(510)] AlertNotificationService: XPC connection invalidated.
[12519:775:0822/133310.782780:INFO:CONSOLE(1236)] "Running TestCase CrSettingsPrivacyPageTest.All", source: file:///b/s/w/ir/chrome/test/data/webui/test_api.js (1236)
[12519:775:0822/133311.180195:ERROR:CONSOLE(48)] "Mocha test failed: ClearBrowsingData showHistoryDeletionDialog
Error: Script error. (:0)
", source: file:///b/s/w/ir/chrome/test/data/webui/mocha_adapter.js (48)
[12519:775:0822/133311.180308:ERROR:CONSOLE(206)] "Uncaught AssertionError: expected true to be false", source: file:///b/s/w/ir/third_party/chaijs/chai.js (206)
[12519:775:0822/133311.685221:ERROR:web_ui_test_handler.cc(100)] Test Errors: 1/10 tests had failed assertions.
[12519:775:0822/133311.685383:ERROR:web_ui_browser_test.cc(481)] CONDITION FAILURE: encountered javascript console error(s):
[12519:775:0822/133311.685398:ERROR:web_ui_browser_test.cc(483)] JS ERROR: '[12519:775:0822/133311.180195:ERROR:CONSOLE(48)] "Mocha test failed: ClearBrowsingData showHistoryDeletionDialog
Error: Script error. (:0)
", source: file:///b/s/w/ir/chrome/test/data/webui/mocha_adapter.js (48)
'
[12519:775:0822/133311.685407:ERROR:web_ui_browser_test.cc(483)] JS ERROR: '[12519:775:0822/133311.180308:ERROR:CONSOLE(206)] "Uncaught AssertionError: expected true to be false", source: file:///b/s/w/ir/third_party/chaijs/chai.js (206)
'
[12519:775:0822/133311.685414:ERROR:web_ui_browser_test.cc(485)] JS call assumed failed, because JS console error(s) found.
gen/chrome/test/data/webui/settings/cr_settings_browsertest-gen.cc:1318: Failure
Value of: RunJavascriptTestF( true, "CrSettingsPrivacyPageTest", "All")
  Actual: false
Expected: true
Stack trace:
0   browser_tests                       0x0000000102f9560b testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop(int) + 91
1   browser_tests                       0x0000000102f94fd9 testing::internal::AssertHelper::operator=(testing::Message const&) const + 89
2   browser_tests                       0x0000000102e2e84f CrSettingsPrivacyPageTest_All_Test::RunTestOnMainThread() + 1151
3   browser_tests                       0x000000010567749b content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() + 491
4   browser_tests                       0x0000000105147f07 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() + 4375
5   browser_tests                       0x0000000105146cee ChromeBrowserMainParts::PreMainMessageLoopRun() + 62
6   browser_tests                       0x0000000103c22193 content::BrowserMainLoop::PreMainMessageLoopRun() + 67
7   browser_tests                       0x000000010402c3c7 content::StartupTaskRunner::RunAllTasksNow() + 39
8   browser_tests                       0x0000000103c208c8 content::BrowserMainLoop::CreateStartupTasks() + 712
9   browser_tests                       0x0000000103c246b0 content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) + 96
10  browser_tests                       0x0000000103c1e9e4 content::BrowserMain(content::MainFunctionParams const&) + 180
11  browser_tests                       0x0000000104f78690 content::ContentMainRunnerImpl::Run(bool) + 592
12  browser_tests                       0x000000010704e0b1 service_manager::Main(service_manager::MainParams const&) + 2849
13  browser_tests                       0x0000000104f77894 content::ContentMain(content::ContentMainParams const&) + 68
14  browser_tests                       0x00000001056770c9 content::BrowserTestBase::SetUp() + 2697
15  browser_tests                       0x00000001050d0873 InProcessBrowserTest::SetUp() + 723
[12519:775:0822/133311.841843:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown.
[12519:775:0822/133311.841879:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown.
[  FAILED  ] CrSettingsPrivacyPageTest.All, where TypeParam =  and GetParam() =  (3023 ms)

[ RUN      ] CrExtensionsPackDialogTest.PackSuccess
[13301:52995:0822/133437.390845:WARNING:notification_platform_bridge_mac.mm(510)] AlertNotificationService: XPC connection invalidated.
[13301:775:0822/133438.976230:INFO:CONSOLE(1236)] "Running TestCase CrExtensionsPackDialogTest.MAYBE_PackSuccess", source: file:///b/s/w/ir/chrome/test/data/webui/test_api.js (1236)
[13301:775:0822/133439.050328:ERROR:web_ui_test_handler.cc(100)] Failed: RUN_TEST_F("CrExtensionsPackDialogTest","MAYBE_PackSuccess")
AssertionError: expected true to be false
    at Function.assert.isFalse (file:///b/s/w/ir/third_party/chaijs/chai.js:2459:31)
    at assertFalse (file:///b/s/w/ir/chrome/test/data/webui/test_api.js:873:15)
    at file:///b/s/w/ir/chrome/test/data/webui/test_api.js:1030:18
    at mockDelegate.rootPromise.promise.then.then.then (file:///b/s/w/ir/chrome/test/data/webui/extensions/pack_dialog_test.js:140:13)
gen/chrome/test/data/webui/extensions/cr_extensions_browsertest-gen.cc:2195: Failure
Value of: RunJavascriptTestF( true, "CrExtensionsPackDialogTest", "MAYBE_PackSuccess")
  Actual: false
Expected: true
Stack trace:
0   browser_tests                       0x000000010543860b testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop(int) + 91
1   browser_tests                       0x0000000105437fd9 testing::internal::AssertHelper::operator=(testing::Message const&) const + 89
2   browser_tests                       0x000000010536d61b CrExtensionsPackDialogTest_PackSuccess_Test::RunTestOnMainThread() + 1403
3   browser_tests                       0x0000000107b1a49b content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() + 491
4   browser_tests                       0x00000001075eaf07 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() + 4375
5   browser_tests                       0x00000001075e9cee ChromeBrowserMainParts::PreMainMessageLoopRun() + 62
6   browser_tests                       0x00000001060c5193 content::BrowserMainLoop::PreMainMessageLoopRun() + 67
7   browser_tests                       0x00000001064cf3c7 content::StartupTaskRunner::RunAllTasksNow() + 39
8   browser_tests                       0x00000001060c38c8 content::BrowserMainLoop::CreateStartupTasks() + 712
9   browser_tests                       0x00000001060c76b0 content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) + 96
10  browser_tests                       0x00000001060c19e4 content::BrowserMain(content::MainFunctionParams const&) + 180
11  browser_tests                       0x000000010741b690 content::ContentMainRunnerImpl::Run(bool) + 592
12  browser_tests                       0x00000001094f10b1 service_manager::Main(service_manager::MainParams const&) + 2849
13  browser_tests                       0x000000010741a894 content::ContentMain(content::ContentMainParams const&) + 68
14  browser_tests                       0x0000000107b1a0c9 content::BrowserTestBase::SetUp() + 2697
15  browser_tests                       0x0000000107573873 InProcessBrowserTest::SetUp() + 723
[13301:775:0822/133439.217265:WARNING:ipc_message_attachment_set.cc(49)] MessageAttachmentSet destroyed with unconsumed attachments: 0/1
[13301:775:0822/133439.217359:WARNING:ipc_message_attachment_set.cc(49)] MessageAttachmentSet destroyed with unconsumed attachments: 0/1
[13301:775:0822/133439.261391:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown.
[13301:775:0822/133439.261431:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown.
[  FAILED  ] CrExtensionsPackDialogTest.PackSuccess, where TypeParam =  and GetParam() =  (2007 ms)

PackSuccess was disabled in 877109. I'll disable CrSettingsPrivacyPageTest.All as well.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6707023ab8873753b9c569583273c1f0c92662ce

commit 6707023ab8873753b9c569583273c1f0c92662ce
Author: Trent Apted <tapted@chromium.org>
Date: Mon Aug 27 01:19:11 2018

Disable CrSettingsPrivacyPageTest.All in webui_polymer2_browser_tests

Fails reliably on macOS 10.12 since
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/15035

NOTRY=true
TBR=dpapad@chromium.org, scottchen@chromium.org, rbpotter@chromium.org

Bug:  877109 ,  876990 
Change-Id: I360d6766bffd48178894d9023fcc1758c0e7eba3
Reviewed-on: https://chromium-review.googlesource.com/1189683
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586179}
[modify] https://crrev.com/6707023ab8873753b9c569583273c1f0c92662ce/testing/buildbot/filters/webui_polymer2_browser_tests.filter

fwiw, the CL identified in #1 only affects Android so it would be quite odd if it had been causing a webui failure on Mac.