New issue
Advanced search Search tips

Issue 876982 link

Starred by 1 user
Status: Fixed
Owner:
gambard@chromium.org
Closed: Aug 31
Cc:
ios-bugs@chromium.org
pkasting@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Vertical Offset for the TabGrid menu after a cold start

Project Member Reported by gambard@chromium.org, Aug 23 
iPad only.

What steps will reproduce the problem?
(1) Relaunch the app
(2) Long Press on the TabStrip TabGrid button

What is the expected result?
The Popup menu should be displayed below the button.

What happens instead?
The popup menu is overlapping with the button.

The problem disappear if the user interact with the page (scroll, open a new tab...)
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b44216ef90dfe6d5edd4aab1bf547ec7772f9e62

commit b44216ef90dfe6d5edd4aab1bf547ec7772f9e62
Author: Gauthier Ambard <gambard@chromium.org>
Date: Fri Aug 31 13:45:18 2018

[iOS] Fix TabStrip PopupMenu on launch

This CL makes sure that the PopupMenu displayed on the TabGrid button in
the TabStrip has a correct positioning on the first launch of the app.

Bug:  876982 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs
Change-Id: I5eb288baae93ce9df8e5e7fc5f21f4eb3c4b7060
Reviewed-on: https://chromium-review.googlesource.com/1199045
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588009}
[modify] https://crrev.com/b44216ef90dfe6d5edd4aab1bf547ec7772f9e62/ios/chrome/browser/ui/tabs/tab_strip_view.h
[modify] https://crrev.com/b44216ef90dfe6d5edd4aab1bf547ec7772f9e62/ios/chrome/browser/ui/tabs/tab_strip_view.mm

Comment 2 by gambard@chromium.org, Aug 31

Status: Fixed (was: Assigned)
►

Sign in to add a comment