There's no clear way to test this function with all the static helper functions involved from extensions, etc. We should figure this out.
I'll fix this as part of the refactors required for issue 918943 .
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/235a38d21ad50442fd4a3362e143aa5bedf89bf3 commit 235a38d21ad50442fd4a3362e143aa5bedf89bf3 Author: Kyle Horimoto <khorimoto@chromium.org> Date: Thu Jan 10 23:26:41 2019 [CrOS MultiDevice] Make AndroidSmsService own related classes. This CL makes AndroidSmsService the owner of AndroidSmsAppHelperDelegate and AndroidSmsPairingStateTracker (previously, objects of these classes belonged to MultiDeviceSetupService). Upcoming changes require that these classes be shared among multiple clients, so it is necessary that they be accessible outside of the service. As part of this change, I updated AndroidSmsService's constructor to take other KeyedServices as explicit parameters to make dependencies clear, and I updated its factory to depend on the other KeyedServices' factories. Bug: 918943 , 876972 Change-Id: Iee064d97349bccb191533056ceea5cb52984dcba Reviewed-on: https://chromium-review.googlesource.com/c/1402022 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Stefan Kuhne <skuhne@chromium.org> Cr-Commit-Position: refs/heads/master@{#621800} [modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chrome/browser/chromeos/android_sms/android_sms_app_helper_delegate_impl.cc [modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chrome/browser/chromeos/android_sms/android_sms_app_helper_delegate_impl.h [modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chrome/browser/chromeos/android_sms/android_sms_app_helper_delegate_impl_unittest.cc [modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chrome/browser/chromeos/android_sms/android_sms_pairing_state_tracker_impl.cc [modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chrome/browser/chromeos/android_sms/android_sms_pairing_state_tracker_impl.h [modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chrome/browser/chromeos/android_sms/android_sms_service.cc [modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chrome/browser/chromeos/android_sms/android_sms_service.h [modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chrome/browser/chromeos/android_sms/android_sms_service_factory.cc [modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chrome/browser/chromeos/android_sms/android_sms_urls.cc [modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chrome/browser/chromeos/android_sms/android_sms_urls.h [modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chrome/browser/profiles/profile_impl.cc [modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chrome/browser/ui/webui/settings/chromeos/multidevice_handler.cc [modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chrome/browser/ui/webui/settings/chromeos/multidevice_handler.h [modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chrome/browser/ui/webui/settings/chromeos/multidevice_handler_unittest.cc [modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chrome/browser/ui/webui/settings/md_settings_ui.cc [modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chromeos/services/multidevice_setup/android_sms_app_installing_status_observer.cc [modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chromeos/services/multidevice_setup/android_sms_app_installing_status_observer.h [modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chromeos/services/multidevice_setup/android_sms_app_installing_status_observer_unittest.cc [modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chromeos/services/multidevice_setup/feature_state_manager_impl.cc [modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chromeos/services/multidevice_setup/feature_state_manager_impl.h [modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chromeos/services/multidevice_setup/feature_state_manager_impl_unittest.cc [modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chromeos/services/multidevice_setup/multidevice_setup_impl.cc [modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chromeos/services/multidevice_setup/multidevice_setup_impl.h [modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chromeos/services/multidevice_setup/multidevice_setup_impl_unittest.cc [modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chromeos/services/multidevice_setup/multidevice_setup_initializer.cc [modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chromeos/services/multidevice_setup/multidevice_setup_initializer.h [modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chromeos/services/multidevice_setup/multidevice_setup_service.cc [modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chromeos/services/multidevice_setup/multidevice_setup_service.h [modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chromeos/services/multidevice_setup/multidevice_setup_service_unittest.cc [modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chromeos/services/multidevice_setup/public/cpp/multidevice_setup_client_impl_unittest.cc
Comment 1 by khorimoto@chromium.org
, Aug 24